| CC: | shay [...] cpan.org |
| Subject: | Thread-Queue tests emitting warnings with Test::Simple 1.302138 |
See: https://rt.perl.org/Ticket/Display.html?id=133382
Test::Simple 1.302138 was recently merged into Perl 5 blead. When I run the Perl 5 core distribution test suite, I get warnings in several of the dist/Thread-Queue/t/*.t tests as documented in the bug ticket listed above.
A patch to silence these warnings is attached.
I hope that you can review and apply this patch at your earliest convenience and issue a new CPAN release that we can then synch into blead. (From what I read in Porting/Maintainers.pl, this will result in a better git history than if I applied it directly to blead.) We anticipate a release of perl-5.29.1 on Friday July 20.
Thank you very much.
Jim Keenan
| Subject: | 0001-Wrap-test-functionality-in-BEGIN-block.patch |
From c717b7e425983a745e8bb75e01004178a8883a3f Mon Sep 17 00:00:00 2001
From: James E Keenan <jkeenan@cpan.org>
Date: Tue, 17 Jul 2018 14:55:37 -0400
Subject: [PATCH] Wrap test functionality in BEGIN block.
This is to accommodate changes in Test::Simple 1.302138, which is now merged
into blead. That was generating warnings:
Too late to run INIT block at ../../lib/Test2/IPC.pm line 22.
For: perl RT 133382
---
dist/Thread-Queue/t/01_basic.t | 2 ++
dist/Thread-Queue/t/02_refs.t | 2 ++
dist/Thread-Queue/t/03_peek.t | 2 ++
dist/Thread-Queue/t/05_extract.t | 2 ++
dist/Thread-Queue/t/06_insert.t | 2 ++
dist/Thread-Queue/t/07_lock.t | 2 ++
dist/Thread-Queue/t/10_timed.t | 2 ++
7 files changed, 14 insertions(+)
diff --git a/dist/Thread-Queue/t/01_basic.t b/dist/Thread-Queue/t/01_basic.t
index 2983f0b..91244db 100644
--- a/dist/Thread-Queue/t/01_basic.t
+++ b/dist/Thread-Queue/t/01_basic.t
@@ -12,12 +12,14 @@ BEGIN {
use threads;
use Thread::Queue;
+BEGIN { # perl RT 133382
if ($] == 5.008) {
require 't/test.pl'; # Test::More work-alike for Perl 5.8.0
} else {
require Test::More;
}
Test::More->import();
+} # end BEGIN
plan('tests' => 81);
### Basic usage with multiple threads ###
diff --git a/dist/Thread-Queue/t/02_refs.t b/dist/Thread-Queue/t/02_refs.t
index 0cebdc1..758c97e 100644
--- a/dist/Thread-Queue/t/02_refs.t
+++ b/dist/Thread-Queue/t/02_refs.t
@@ -13,12 +13,14 @@ use threads;
use threads::shared;
use Thread::Queue;
+BEGIN { # perl RT 133382
if ($] == 5.008) {
require 't/test.pl'; # Test::More work-alike for Perl 5.8.0
} else {
require Test::More;
}
Test::More->import();
+} # end BEGIN
plan('tests' => 46);
# Regular array
diff --git a/dist/Thread-Queue/t/03_peek.t b/dist/Thread-Queue/t/03_peek.t
index d543b59..7b9ca05 100644
--- a/dist/Thread-Queue/t/03_peek.t
+++ b/dist/Thread-Queue/t/03_peek.t
@@ -12,12 +12,14 @@ BEGIN {
use threads;
use Thread::Queue;
+BEGIN { # perl RT 133382
if ($] == 5.008) {
require 't/test.pl'; # Test::More work-alike for Perl 5.8.0
} else {
require Test::More;
}
Test::More->import();
+} # end BEGIN
plan('tests' => 19);
my $q = Thread::Queue->new(1..10);
diff --git a/dist/Thread-Queue/t/05_extract.t b/dist/Thread-Queue/t/05_extract.t
index de0e78b..823bd0c 100644
--- a/dist/Thread-Queue/t/05_extract.t
+++ b/dist/Thread-Queue/t/05_extract.t
@@ -12,12 +12,14 @@ BEGIN {
use threads;
use Thread::Queue;
+BEGIN { # perl RT 133382
if ($] == 5.008) {
require 't/test.pl'; # Test::More work-alike for Perl 5.8.0
} else {
require Test::More;
}
Test::More->import();
+} # end BEGIN
plan('tests' => 20);
my $q = Thread::Queue->new(1..10);
diff --git a/dist/Thread-Queue/t/06_insert.t b/dist/Thread-Queue/t/06_insert.t
index 4f9d1df..64dc4e3 100644
--- a/dist/Thread-Queue/t/06_insert.t
+++ b/dist/Thread-Queue/t/06_insert.t
@@ -12,12 +12,14 @@ BEGIN {
use threads;
use Thread::Queue;
+BEGIN { # perl RT 133382
if ($] == 5.008) {
require 't/test.pl'; # Test::More work-alike for Perl 5.8.0
} else {
require Test::More;
}
Test::More->import();
+} # end BEGIN
plan('tests' => 16);
my $q = Thread::Queue->new(1..10);
diff --git a/dist/Thread-Queue/t/07_lock.t b/dist/Thread-Queue/t/07_lock.t
index b20e060..66c4550 100644
--- a/dist/Thread-Queue/t/07_lock.t
+++ b/dist/Thread-Queue/t/07_lock.t
@@ -13,12 +13,14 @@ use threads;
use Thread::Queue;
use Thread::Semaphore;
+BEGIN { # perl RT 133382
if ($] == 5.008) {
require 't/test.pl'; # Test::More work-alike for Perl 5.8.0
} else {
require Test::More;
}
Test::More->import();
+} # end BEGIN
plan('tests' => 3);
# The following tests locking a queue
diff --git a/dist/Thread-Queue/t/10_timed.t b/dist/Thread-Queue/t/10_timed.t
index 8404720..896954c 100644
--- a/dist/Thread-Queue/t/10_timed.t
+++ b/dist/Thread-Queue/t/10_timed.t
@@ -12,12 +12,14 @@ BEGIN {
use threads;
use Thread::Queue;
+BEGIN { # perl RT 133382
if ($] == 5.008) {
require 't/test.pl'; # Test::More work-alike for Perl 5.8.0
} else {
require Test::More;
}
Test::More->import();
+} # end BEGIN
plan('tests' => 19);
### ->dequeue_timed(TIMEOUT, COUNT) test ###
--
2.7.4