Skip Menu |

This queue is for tickets about the PPR CPAN distribution.

Report information
The Basics
Id: 125751
Status: resolved
Priority: 0/
Queue: PPR

People
Owner: Nobody in particular
Requestors: a.r.ferreira [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Simplify StatementSequence and PodSequence usage
Date: Tue, 3 Jul 2018 17:44:03 -0700
To: bug-ppr [...] rt.cpan.org
From: Adriano Ferreira <a.r.ferreira [...] gmail.com>
At the latest release, 0.000021 <https://metacpan.org/release/PPR>, one of the changes you added looked like this: @@ -66,7 +66,7 @@ our $GRAMMAR = qr{ (?<PerlDocument> (?<PerlStdDocument> \x{FEFF}?+ # Optional BOM marker - (?&PerlStatementSequence)?+ + (?&PerlStatementSequence) )) # End of rule (?<PerlStatementSequence> (?<PerlStdStatementSequence> That made remember that PerlStatementSequence and PerlPodSequence match sequences of zero or more "things", and thus may get away without the ?+ quantifier (which is implied). If that holds true, you may consider the attached patch that applies this simplification throughout the code.

Message body is not shown because sender requested not to inline it.

Subject: Re: [rt.cpan.org #125751] Simplify StatementSequence and PodSequence usage
Date: Thu, 5 Jul 2018 10:36:07 +1000
To: bug-PPR [...] rt.cpan.org
From: Damian Conway <damian [...] conway.org>
Thanks, Adriano. Patch applied! Damian