Bug #125469 for PPR: Inlining makes PPR::X less fun

Sun Jun 03 15:59:59 2018 mst [...] shadowcat.co.uk - Ticket created

Subject:	Inlining makes PPR::X less fun
Date:	Sun, 3 Jun 2018 19:16:57 +0000
To:	bug-PPR [...] rt.cpan.org
From:	Matt S Trout <mst [...] shadowcat.co.uk>

All of the bits like # Inlined (?&PerlReturnStatement)... seems to me to make the PerlStdFoo thing distinctly less useful because even if I override one it's not going to get picked up by the things that inline it. Is this structural or performance? If "performance", I would dearly love for PPR::X to uninline everything (or at least have an optional uninlined version I can use). If "structural", then please enlighten me as to why so I can try and figure out what my options are. -- Matt S Trout - Shadowcat Systems - Perl consulting with a commit bit and a clue http://shadowcat.co.uk/blog/matt-s-trout/ http://twitter.com/shadowcat_mst/ Email me now on mst (at) shadowcat.co.uk and let's chat about how our CPAN commercial support, training and consultancy packages could help your team.

Mon Jun 04 00:04:54 2018 DCONWAY [...] cpan.org - Status changed from 'new' to 'resolved'

Mon Jun 04 00:04:56 2018 damian [...] conway.org - Correspondence added

Subject:	Re: [rt.cpan.org #125469] Inlining makes PPR::X less fun
Date:	Mon, 4 Jun 2018 14:04:10 +1000
To:	bug-PPR [...] rt.cpan.org
From:	Damian Conway <damian [...] conway.org>

Hi Matt, Thanks for raising this issue. The inlinings improve performance 3% to 5% (depending on which version of Perl it's matching under). So I'm loathe to remove them from PPR. But you're entirely correct that their presence makes using PPR::X much less fun, and much more prone to error. So bin/gen_PPRX.pl in the latest release (0.000016, just uploaded to CPAN) now un-inlines them. I hope this increases the utility (and fun) of the module for you. Damian