Subject: | some inputs make the parser crash / log undefined values |
Date: | Sat, 02 Jun 2018 15:01:56 +0200 |
To: | bug-Parse-EDID [...] rt.cpan.org |
From: | Boudewijn Visser <bvisser1 [...] xs4all.nl> |
Hello Mr. Rousse ,
I happened to be parsing a large(-ish) set of EDID data (190.000)
samples using the Parse-EDID module.
One sample caused the module to crash with error
'x' outside of string in unpack at Parse/EDID.pm line 452
And a fairly large number of samples (8900) log the following errors
when
parsing :
Use of uninitialized value in subtraction (-) at Parse/EDID.pm line 532.
Use of uninitialized value $edid{"ratio_precision"} in string eq at
Parse/EDID.pm line 532.
These 8900 are spread over a number of models and vendors :
63 unique manufacturers, and 371 models (EISA_ID) .
Although manufacturer 'MEI' dominates with 7900 examples.
The version of Parse::EDID was 1.0.6 .
The undefined messages are mainly a nuisance, but the crash when parsing
is inconvenient.
I have not dived deep enough in the EDID specs to see if and how those
cases are violating a standard, but I hope you can make the module more
robust (and quiet) against this input data.
Attached a small script with some edid samples included that
demonstrates the issues.
Best regards, Boudewijn
Message body is not shown because sender requested not to inline it.