Bug #125383 for CGI-Simple: MANIFEST and MANIFEST.SKIP have circular dependencies

Tue May 22 16:22:43 2018 SREZIC [...] cpan.org - Ticket created

CC:	BINGOS [...] cpan.org
Subject:	MANIFEST and MANIFEST.SKIP have circular dependencies

I see a new test failure: ... # Unable to parse MANIFEST.SKIP file: # No such file or directory # Using default skip data from ExtUtils::Manifest 1.71 # MANIFEST and MANIFEST.SKIP have circular dependencies: # .travis.yml # Failed test 'No files are in both MANIFEST and MANIFEST.SKIP' # at t/manifest.t line 7. # Looks like you failed 1 test of 4. t/manifest.t ......... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests ... This seems to happen if Test::DistManifest is installed (otherwise the test is skipped) and a fresh ExtUtils::Manifest (i.e. 1.71) is installed. I guess this change is responsible for the problem: https://metacpan.org/source/BINGOS/ExtUtils-Manifest-1.71/Changes#L4

Wed May 23 06:56:05 2018 MANWAR [...] cpan.org - Correspondence added

Hi @SREZIC, Thanks for reporting the issue and advise. However I am unable to replicate the same in my local environment. Please take a look below: manwar@ubuntu:~/github/CGI--Simple$ perl -v This is perl 5, version 18, subversion 2 (v5.18.2) built for x86_64-linux-gnu-thread-multi (with 52 registered patches, see perl -V for more detail) Copyright 1987-2013, Larry Wall Perl may be copied only under the terms of either the Artistic License or the GNU General Public License, which may be found in the Perl 5 source kit. Complete documentation for Perl, including FAQ lists, should be found on this system using "man perl" or "perldoc perl". If you have access to the Internet, point your browser at http://www.perl.org/, the Perl Home Page. manwar@ubuntu:~/github/CGI--Simple$ sudo cpanm --info Test::DistManifest ETHER/Test-DistManifest-1.014.tar.gz manwar@ubuntu:~/github/CGI--Simple$ sudo cpanm --info ExtUtils::Manifest BINGOS/ExtUtils-Manifest-1.71.tar.gz manwar@ubuntu:~/github/CGI--Simple$ make test PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "-MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/000.load.t ......... 1/1 # Testing CGI::Simple 1.15 t/000.load.t ......... ok t/020.cookie.t ....... ok t/030.function.t ..... ok t/040.request.t ...... ok t/041.multipart.t .... ok t/050.simple.t ....... ok t/060.slow_post.t .... ok t/070.standard.t ..... ok t/080.util.t ......... ok t/090.14838.t ........ ok t/100.set-cookie.t ... ok t/110.bad-upload.t ... ok t/120.header-crlf.t .. ok t/headers.t .......... ok t/manifest.t ......... ok t/pod-coverage.t ..... ok t/pod.t .............. ok t/upload_info.t ...... ok t/version.t .......... ok All tests successful. Files=19, Tests=879, 13 wallclock secs ( 0.14 usr 0.02 sys + 1.53 cusr 0.20 csys = 1.89 CPU) Result: PASS

Wed May 23 06:56:06 2018 The RT System itself - Status changed from 'new' to 'open'

Wed May 23 06:56:06 2018 MANWAR [...] cpan.org - Taken

Sat Jun 02 05:14:03 2018 SREZIC [...] cpan.org - Correspondence added

RT-Send-CC:

BINGOS [...] cpan.org

On 2018-05-23 06:56:05, MANWAR wrote: Show quoted text

> Hi @SREZIC, > > Thanks for reporting the issue and advise. > However I am unable to replicate the same in my local environment. > > Please take a look below: > > manwar@ubuntu:~/github/CGI--Simple$ perl -v > > This is perl 5, version 18, subversion 2 (v5.18.2) built for x86_64- > linux-gnu-thread-multi > (with 52 registered patches, see perl -V for more detail) > > Copyright 1987-2013, Larry Wall > > Perl may be copied only under the terms of either the Artistic License > or the > GNU General Public License, which may be found in the Perl 5 source > kit. > > Complete documentation for Perl, including FAQ lists, should be found > on > this system using "man perl" or "perldoc perl". If you have access to > the > Internet, point your browser at http://www.perl.org/, the Perl Home > Page. > > manwar@ubuntu:~/github/CGI--Simple$ sudo cpanm --info > Test::DistManifest > ETHER/Test-DistManifest-1.014.tar.gz > > manwar@ubuntu:~/github/CGI--Simple$ sudo cpanm --info > ExtUtils::Manifest > BINGOS/ExtUtils-Manifest-1.71.tar.gz > > manwar@ubuntu:~/github/CGI--Simple$ make test > PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "- > MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, > 'blib/lib', 'blib/arch')" t/*.t > t/000.load.t ......... 1/1 # Testing CGI::Simple 1.15 > t/000.load.t ......... ok > t/020.cookie.t ....... ok > t/030.function.t ..... ok > t/040.request.t ...... ok > t/041.multipart.t .... ok > t/050.simple.t ....... ok > t/060.slow_post.t .... ok > t/070.standard.t ..... ok > t/080.util.t ......... ok > t/090.14838.t ........ ok > t/100.set-cookie.t ... ok > t/110.bad-upload.t ... ok > t/120.header-crlf.t .. ok > t/headers.t .......... ok > t/manifest.t ......... ok > t/pod-coverage.t ..... ok > t/pod.t .............. ok > t/upload_info.t ...... ok > t/version.t .......... ok > All tests successful. > Files=19, Tests=879, 13 wallclock secs ( 0.14 usr 0.02 sys + 1.53 > cusr 0.20 csys = 1.89 CPU) > Result: PASS

Try the following Dockerfile to ensure a really clean environment: FROM debian:stretch RUN apt-get -y update RUN apt-get -y install cpanminus RUN apt-get -y install make RUN cpanm --notest Test::DistManifest ExtUtils::Manifest CMD cpanm --verbose MANWAR/CGI-Simple-1.15.tar.gz Run then: $ docker build . ... Successfully built 80c3a153b9cb $ docker run 80c3a153b9cb ... # Unable to parse MANIFEST.SKIP file: # No such file or directory # Using default skip data from ExtUtils::Manifest 1.71 # MANIFEST and MANIFEST.SKIP have circular dependencies: # .travis.yml # Failed test 'No files are in both MANIFEST and MANIFEST.SKIP' # at t/manifest.t line 7. # Looks like you failed 1 test of 4. t/manifest.t ......... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests ...

Sat Jun 02 05:20:05 2018 SREZIC [...] cpan.org - Correspondence added

RT-Send-CC:

BINGOS [...] cpan.org

On 2018-06-02 05:14:03, SREZIC wrote: Show quoted text

> On 2018-05-23 06:56:05, MANWAR wrote:

> > Hi @SREZIC, > > > > Thanks for reporting the issue and advise. > > However I am unable to replicate the same in my local environment. > > > > Please take a look below: > > > > manwar@ubuntu:~/github/CGI--Simple$ perl -v > > > > This is perl 5, version 18, subversion 2 (v5.18.2) built for x86_64- > > linux-gnu-thread-multi > > (with 52 registered patches, see perl -V for more detail) > > > > Copyright 1987-2013, Larry Wall > > > > Perl may be copied only under the terms of either the Artistic License > > or the > > GNU General Public License, which may be found in the Perl 5 source > > kit. > > > > Complete documentation for Perl, including FAQ lists, should be found > > on > > this system using "man perl" or "perldoc perl". If you have access to > > the > > Internet, point your browser at http://www.perl.org/, the Perl Home > > Page. > > > > manwar@ubuntu:~/github/CGI--Simple$ sudo cpanm --info > > Test::DistManifest > > ETHER/Test-DistManifest-1.014.tar.gz > > > > manwar@ubuntu:~/github/CGI--Simple$ sudo cpanm --info > > ExtUtils::Manifest > > BINGOS/ExtUtils-Manifest-1.71.tar.gz > > > > manwar@ubuntu:~/github/CGI--Simple$ make test > > PERL_DL_NONLAZY=1 "/usr/bin/perl" "-MExtUtils::Command::MM" "- > > MTest::Harness" "-e" "undef *Test::Harness::Switches; test_harness(0, > > 'blib/lib', 'blib/arch')" t/*.t > > t/000.load.t ......... 1/1 # Testing CGI::Simple 1.15 > > t/000.load.t ......... ok > > t/020.cookie.t ....... ok > > t/030.function.t ..... ok > > t/040.request.t ...... ok > > t/041.multipart.t .... ok > > t/050.simple.t ....... ok > > t/060.slow_post.t .... ok > > t/070.standard.t ..... ok > > t/080.util.t ......... ok > > t/090.14838.t ........ ok > > t/100.set-cookie.t ... ok > > t/110.bad-upload.t ... ok > > t/120.header-crlf.t .. ok > > t/headers.t .......... ok > > t/manifest.t ......... ok > > t/pod-coverage.t ..... ok > > t/pod.t .............. ok > > t/upload_info.t ...... ok > > t/version.t .......... ok > > All tests successful. > > Files=19, Tests=879, 13 wallclock secs ( 0.14 usr 0.02 sys + 1.53 > > cusr 0.20 csys = 1.89 CPU) > > Result: PASS

> > Try the following Dockerfile to ensure a really clean environment: > > FROM debian:stretch

It also fails if using ubuntu:precise or ubuntu:trusty here.

Sun Jul 22 18:26:19 2018 ether [...] cpan.org - Correspondence added

I also see failures on darwin, OSX version 10.12.6 (Sierra). At any rate I would suggest not having this test run for normal user installations, as it is more of an author test: either move this test to xt/, or guard it with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Wed Jul 25 11:15:07 2018 MANWAR [...] cpan.org - Correspondence added

Thanks for the suggestions. I would release the patch soon.

Wed Jul 25 11:15:21 2018 MANWAR [...] cpan.org - Severity Normal added

Sun Feb 09 01:54:20 2020 MANWAR [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Feb 09 01:54:21 2020 MANWAR [...] cpan.org - Fixed in 1.24 added