Bug #125361 for CPAN-Testers-Common-DBUtils: t/10database.t: test failures with perl-5.27.11 on FreeBSD-11.1

Sat May 19 22:52:57 2018 jkeenan [...] cpan.org - Ticket created

Subject:

t/10database.t: test failures with perl-5.27.11 on FreeBSD-11.1

Today, as part of an effort to assess the perl-5.28.0-readiness of "CPAN river" modules, I attempted to install this library against perl-5.27.11 on FreeBSD-11.1. I got these failures (excerpt): ##### $ this_prove -vb t/10database.t t/10database.t .. # drivers all: (CSV DBM Pg SQLite SQLite2 mysql), available: (CSV DBM Pg SQLite mysql) ok 1 - An object of class 'CPAN::Testers::Common::DBUtils' isa 'CPAN::Testers::Common::DBUtils' [snip] ok 33 - .. quoted ok 34 - .. inserted all records [SQLite] ok 35 - .. inserted all records ok 36 - .. inserted all records ok 37 - .. inserted all records ok 38 - .. inserted all records ok 39 - .. empty SQL to get_query ok 40 - .. got a result with valid SQL DBD::SQLite::db prepare failed: incomplete input at /usr/home/jkeenan/var/tad/testing/perl-5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils-0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 167. not ok 41 - .. bad SQL spotted # Failed test '.. bad SQL spotted' # at t/10database.t line 179. # 'err=incomplete input, sql=[SELECT], args[] at t/10database.t line 178. # ' # doesn't match '(?^:You have an error in your SQL syntax|syntax error)' ok 42 - .. empty SQL to iterator ok 43 - .. got a result with valid SQL DBD::SQLite::db prepare failed: incomplete input at /usr/home/jkeenan/var/tad/testing/perl-5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils-0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 223. not ok 44 - .. bad SQL spotted # Failed test '.. bad SQL spotted' # at t/10database.t line 186. # 'err=incomplete input, sql=[SELECT], args[] at t/10database.t line 185. # ' # doesn't match '(?^:You have an error in your SQL syntax|syntax error)' ok 45 - .. empty SQL to do_query ok 46 - .. got a result with valid SQL DBD::SQLite::db do failed: near "array": syntax error at /usr/home/jkeenan/var/tad/testing/perl-5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils-0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 334. ok 47 - .. bad SQL spotted ok 48 - .. empty SQL to id_query ok 49 - .. got a result with valid SQL ok 50 # skip Driver 'mysql' not supported [snip] ok 98 # skip Driver 'mysql' not supported # Looks like you failed 2 tests of 98. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/98 subtests (less 52 skipped subtests: 44 okay) Test Summary Report ------------------- t/10database.t (Wstat: 512 Tests: 98 Failed: 2) Failed tests: 41, 44 Non-zero exit status: 2 Files=1, Tests=98, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.23 cusr 0.08 csys = 0.38 CPU) Result: FAIL Failed 2/98 subtests (less 52 skipped subtests: 44 okay) Test Summary Report ------------------- t/10database.t (Wstat: 512 Tests: 98 Failed: 2) Failed tests: 41, 44 Non-zero exit status: 2 Files=1, Tests=98, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.23 cusr 0.08 csys = 0.38 CPU) Result: FAIL ##### Thank you very much. Jim Keenan

Sat Jun 09 04:54:46 2018 SREZIC [...] cpan.org - Correspondence added

On 2018-05-19 22:52:57, JKEENAN wrote: Show quoted text

> Today, as part of an effort to assess the perl-5.28.0-readiness of > "CPAN river" modules, I attempted to install this library against > perl-5.27.11 on FreeBSD-11.1. I got these failures (excerpt): > > ##### > $ this_prove -vb t/10database.t > t/10database.t .. # drivers all: (CSV DBM Pg SQLite SQLite2 mysql), > available: (CSV DBM Pg SQLite mysql) > ok 1 - An object of class 'CPAN::Testers::Common::DBUtils' isa > 'CPAN::Testers::Common::DBUtils' > [snip] > ok 33 - .. quoted > ok 34 - .. inserted all records [SQLite] > ok 35 - .. inserted all records > ok 36 - .. inserted all records > ok 37 - .. inserted all records > ok 38 - .. inserted all records > ok 39 - .. empty SQL to get_query > ok 40 - .. got a result with valid SQL > DBD::SQLite::db prepare failed: incomplete input at > /usr/home/jkeenan/var/tad/testing/perl- > 5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils- > 0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 167. > not ok 41 - .. bad SQL spotted > # Failed test '.. bad SQL spotted' > # at t/10database.t line 179. > # 'err=incomplete input, sql=[SELECT], args[] at > t/10database.t line 178. > # ' > # doesn't match '(?^:You have an error in your SQL syntax|syntax > error)' > ok 42 - .. empty SQL to iterator > ok 43 - .. got a result with valid SQL > DBD::SQLite::db prepare failed: incomplete input at > /usr/home/jkeenan/var/tad/testing/perl- > 5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils- > 0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 223. > not ok 44 - .. bad SQL spotted > # Failed test '.. bad SQL spotted' > # at t/10database.t line 186. > # 'err=incomplete input, sql=[SELECT], args[] at > t/10database.t line 185. > # ' > # doesn't match '(?^:You have an error in your SQL syntax|syntax > error)' > ok 45 - .. empty SQL to do_query > ok 46 - .. got a result with valid SQL > DBD::SQLite::db do failed: near "array": syntax error at > /usr/home/jkeenan/var/tad/testing/perl- > 5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils- > 0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 334. > ok 47 - .. bad SQL spotted > ok 48 - .. empty SQL to id_query > ok 49 - .. got a result with valid SQL > ok 50 # skip Driver 'mysql' not supported > [snip] > ok 98 # skip Driver 'mysql' not supported > # Looks like you failed 2 tests of 98. > Dubious, test returned 2 (wstat 512, 0x200) > Failed 2/98 subtests > (less 52 skipped subtests: 44 okay) > > Test Summary Report > ------------------- > t/10database.t (Wstat: 512 Tests: 98 Failed: 2) > Failed tests: 41, 44 > Non-zero exit status: 2 > Files=1, Tests=98, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.23 cusr > 0.08 csys = 0.38 CPU) > Result: FAIL > > Failed 2/98 subtests > (less 52 skipped subtests: 44 okay) > > Test Summary Report > ------------------- > t/10database.t (Wstat: 512 Tests: 98 Failed: 2) > Failed tests: 41, 44 > Non-zero exit status: 2 > Files=1, Tests=98, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.23 cusr > 0.08 csys = 0.38 CPU) > Result: FAIL > ##### > > Thank you very much. > Jim Keenan

I this this error on other systems too, regardless of perl version or OS (perl 5.8.9 .. 5.28.0-RC2, linux + freebsd).

Sat Jun 09 04:54:46 2018 The RT System itself - Status changed from 'new' to 'open'

Sat Jun 09 05:03:15 2018 SREZIC [...] cpan.org - Correspondence added

On 2018-06-09 04:54:46, SREZIC wrote: Show quoted text

> On 2018-05-19 22:52:57, JKEENAN wrote:

> > Today, as part of an effort to assess the perl-5.28.0-readiness of > > "CPAN river" modules, I attempted to install this library against > > perl-5.27.11 on FreeBSD-11.1. I got these failures (excerpt): > > > > ##### > > $ this_prove -vb t/10database.t > > t/10database.t .. # drivers all: (CSV DBM Pg SQLite SQLite2 mysql), > > available: (CSV DBM Pg SQLite mysql) > > ok 1 - An object of class 'CPAN::Testers::Common::DBUtils' isa > > 'CPAN::Testers::Common::DBUtils' > > [snip] > > ok 33 - .. quoted > > ok 34 - .. inserted all records [SQLite] > > ok 35 - .. inserted all records > > ok 36 - .. inserted all records > > ok 37 - .. inserted all records > > ok 38 - .. inserted all records > > ok 39 - .. empty SQL to get_query > > ok 40 - .. got a result with valid SQL > > DBD::SQLite::db prepare failed: incomplete input at > > /usr/home/jkeenan/var/tad/testing/perl- > > 5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils- > > 0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 167. > > not ok 41 - .. bad SQL spotted > > # Failed test '.. bad SQL spotted' > > # at t/10database.t line 179. > > # 'err=incomplete input, sql=[SELECT], args[] at > > t/10database.t line 178. > > # ' > > # doesn't match '(?^:You have an error in your SQL syntax|syntax > > error)' > > ok 42 - .. empty SQL to iterator > > ok 43 - .. got a result with valid SQL > > DBD::SQLite::db prepare failed: incomplete input at > > /usr/home/jkeenan/var/tad/testing/perl- > > 5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils- > > 0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 223. > > not ok 44 - .. bad SQL spotted > > # Failed test '.. bad SQL spotted' > > # at t/10database.t line 186. > > # 'err=incomplete input, sql=[SELECT], args[] at > > t/10database.t line 185. > > # ' > > # doesn't match '(?^:You have an error in your SQL syntax|syntax > > error)' > > ok 45 - .. empty SQL to do_query > > ok 46 - .. got a result with valid SQL > > DBD::SQLite::db do failed: near "array": syntax error at > > /usr/home/jkeenan/var/tad/testing/perl- > > 5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils- > > 0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 334. > > ok 47 - .. bad SQL spotted > > ok 48 - .. empty SQL to id_query > > ok 49 - .. got a result with valid SQL > > ok 50 # skip Driver 'mysql' not supported > > [snip] > > ok 98 # skip Driver 'mysql' not supported > > # Looks like you failed 2 tests of 98. > > Dubious, test returned 2 (wstat 512, 0x200) > > Failed 2/98 subtests > > (less 52 skipped subtests: 44 okay) > > > > Test Summary Report > > ------------------- > > t/10database.t (Wstat: 512 Tests: 98 Failed: 2) > > Failed tests: 41, 44 > > Non-zero exit status: 2 > > Files=1, Tests=98, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.23 > > cusr > > 0.08 csys = 0.38 CPU) > > Result: FAIL > > > > Failed 2/98 subtests > > (less 52 skipped subtests: 44 okay) > > > > Test Summary Report > > ------------------- > > t/10database.t (Wstat: 512 Tests: 98 Failed: 2) > > Failed tests: 41, 44 > > Non-zero exit status: 2 > > Files=1, Tests=98, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.23 > > cusr > > 0.08 csys = 0.38 CPU) > > Result: FAIL > > ##### > > > > Thank you very much. > > Jim Keenan

> > I this this error on other systems too, regardless of perl version or > OS (perl 5.8.9 .. 5.28.0-RC2, linux + freebsd).

To reproduce the failure it seems that is necessary to install Test::Database (otherwise the test is skipped) and DBD::SQLite, possibly a recent version.

Fri Jul 06 22:31:47 2018 preaction [...] cpan.org - Correspondence added

On Sat Jun 09 05:03:15 2018, SREZIC wrote: Show quoted text

> On 2018-06-09 04:54:46, SREZIC wrote:

> > On 2018-05-19 22:52:57, JKEENAN wrote:

> > > Today, as part of an effort to assess the perl-5.28.0-readiness of > > > "CPAN river" modules, I attempted to install this library against > > > perl-5.27.11 on FreeBSD-11.1. I got these failures (excerpt): > > > > > > ##### > > > $ this_prove -vb t/10database.t > > > t/10database.t .. # drivers all: (CSV DBM Pg SQLite SQLite2 mysql), > > > available: (CSV DBM Pg SQLite mysql) > > > ok 1 - An object of class 'CPAN::Testers::Common::DBUtils' isa > > > 'CPAN::Testers::Common::DBUtils' > > > [snip] > > > ok 33 - .. quoted > > > ok 34 - .. inserted all records [SQLite] > > > ok 35 - .. inserted all records > > > ok 36 - .. inserted all records > > > ok 37 - .. inserted all records > > > ok 38 - .. inserted all records > > > ok 39 - .. empty SQL to get_query > > > ok 40 - .. got a result with valid SQL > > > DBD::SQLite::db prepare failed: incomplete input at > > > /usr/home/jkeenan/var/tad/testing/perl- > > > 5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils- > > > 0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 167. > > > not ok 41 - .. bad SQL spotted > > > # Failed test '.. bad SQL spotted' > > > # at t/10database.t line 179. > > > # 'err=incomplete input, sql=[SELECT], args[] at > > > t/10database.t line 178. > > > # ' > > > # doesn't match '(?^:You have an error in your SQL > > > syntax|syntax > > > error)' > > > ok 42 - .. empty SQL to iterator > > > ok 43 - .. got a result with valid SQL > > > DBD::SQLite::db prepare failed: incomplete input at > > > /usr/home/jkeenan/var/tad/testing/perl- > > > 5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils- > > > 0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 223. > > > not ok 44 - .. bad SQL spotted > > > # Failed test '.. bad SQL spotted' > > > # at t/10database.t line 186. > > > # 'err=incomplete input, sql=[SELECT], args[] at > > > t/10database.t line 185. > > > # ' > > > # doesn't match '(?^:You have an error in your SQL > > > syntax|syntax > > > error)' > > > ok 45 - .. empty SQL to do_query > > > ok 46 - .. got a result with valid SQL > > > DBD::SQLite::db do failed: near "array": syntax error at > > > /usr/home/jkeenan/var/tad/testing/perl- > > > 5.27.11/.cpanm/work/1526784354.95112/CPAN-Testers-Common-DBUtils- > > > 0.11/blib/lib/CPAN/Testers/Common/DBUtils.pm line 334. > > > ok 47 - .. bad SQL spotted > > > ok 48 - .. empty SQL to id_query > > > ok 49 - .. got a result with valid SQL > > > ok 50 # skip Driver 'mysql' not supported > > > [snip] > > > ok 98 # skip Driver 'mysql' not supported > > > # Looks like you failed 2 tests of 98. > > > Dubious, test returned 2 (wstat 512, 0x200) > > > Failed 2/98 subtests > > > (less 52 skipped subtests: 44 okay) > > > > > > Test Summary Report > > > ------------------- > > > t/10database.t (Wstat: 512 Tests: 98 Failed: 2) > > > Failed tests: 41, 44 > > > Non-zero exit status: 2 > > > Files=1, Tests=98, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.23 > > > cusr > > > 0.08 csys = 0.38 CPU) > > > Result: FAIL > > > > > > Failed 2/98 subtests > > > (less 52 skipped subtests: 44 okay) > > > > > > Test Summary Report > > > ------------------- > > > t/10database.t (Wstat: 512 Tests: 98 Failed: 2) > > > Failed tests: 41, 44 > > > Non-zero exit status: 2 > > > Files=1, Tests=98, 0 wallclock secs ( 0.05 usr 0.02 sys + 0.23 > > > cusr > > > 0.08 csys = 0.38 CPU) > > > Result: FAIL > > > ##### > > > > > > Thank you very much. > > > Jim Keenan

> > > > I this this error on other systems too, regardless of perl version or > > OS (perl 5.8.9 .. 5.28.0-RC2, linux + freebsd).

> > To reproduce the failure it seems that is necessary to install > Test::Database (otherwise the test is skipped) and DBD::SQLite, > possibly a recent version.

Looks like newer versions of SQLite distinguish between an invalid SQL statement and one that is incomplete (but valid so far). I've added the new error message to the tests, and released v0.12 to CPAN. Thanks for the report and the triage!

Fri Jul 06 22:31:48 2018 preaction [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Jul 06 22:31:48 2018 preaction [...] cpan.org - Fixed in 0.11 deleted