Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-Git-Contributors CPAN distribution.

Report information
The Basics
Id: 125329
Status: rejected
Priority: 0/
Queue: Dist-Zilla-Plugin-Git-Contributors
People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Wed May 16 14:56:36 2018 dagolden [...] cpan.org - Ticket created
Subject: Add config flag to turn off the non-ascii warning
I've been publishing non-ascii JSON files for years and have received zero bug reports about poor souls on Perl 5.8.6 and earlier. The warning serves no purpose for me and I only ever ignore it. I'd like to suppress it as I have no plans to do anything about it.
  Wed May 16 16:11:13 2018 ether [...] cpan.org - Correspondence added
On 2018-05-16 11:56:36, DAGOLDEN wrote: Show quoted text
> I've been publishing non-ascii JSON files for years and have received > zero bug reports about poor souls on Perl 5.8.6 and earlier. The > warning serves no purpose for me and I only ever ignore it. I'd like > to suppress it as I have no plans to do anything about it.
Show quoted text
> I .. have received > zero bug reports about poor souls on Perl 5.8.6 and earlier
I have (and experienced the bug personally, too) -- some of these could have easily been in your dists, e.g. CApture::Tiny or Path::Tiny which is used in lots of places. However, Dist::Zilla itself hasn't published non-ascii META.json files since 5.045, so the warning is invalid for newer dzil. I'll add a check for the Dist::Zilla version to the warning to limit it to places where it's relevant, which should shut it up for you since you keep your modules updated.
  Wed May 16 16:11:14 2018 The RT System itself - Status changed from 'new' to 'open'
  Wed May 16 18:30:47 2018 ether [...] cpan.org - Correspondence added
On 2018-05-16 13:11:13, ETHER wrote: Show quoted text
> However, Dist::Zilla itself hasn't published non-ascii META.json files > since 5.045, so the warning is invalid for newer dzil. I'll add a > check for the Dist::Zilla version to the warning to limit it to places > where it's relevant, which should shut it up for you since you keep > your modules updated.
I see I made this change already (way back when 5.045 was brand new) in release 0.021, and backed it out again in 0.022, so I guess a config option it is then.
  Thu May 17 11:50:41 2018 ether [...] cpan.org - Correspondence added
On 2018-05-16 11:56:36, DAGOLDEN wrote: Show quoted text
> I've been publishing non-ascii JSON files for years and have received > zero bug reports about poor souls on Perl 5.8.6 and earlier. The > warning serves no purpose for me and I only ever ignore it. I'd like > to suppress it as I have no plans to do anything about it.
We determined that shuffling the plugin order so MinimumPerl appeared before Git::Contributors in Dist::Zilla::PluginBundle::DAGOLDEN was sufficient for David's needs, so I'm punting on this.
  Thu May 17 11:50:41 2018 ether [...] cpan.org - Status changed from 'open' to 'rejected'