Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-Git-Contributors CPAN distribution.

Report information
The Basics
Id: 125328
Status: rejected
Priority: 0/
Queue: Dist-Zilla-Plugin-Git-Contributors

People
Owner: Nobody in particular
Requestors: dagolden [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: Suppress non-ASCII warning if the minimum perl version is 5.8.7 or later
I don't know if prereqs are known at the right point, but if the minimum perl requires 5.8.7 or later, the warning is moot and should be suppressed.
On 2018-05-16 11:54:59, DAGOLDEN wrote: Show quoted text
> I don't know if prereqs are known at the right point, but if the > minimum perl requires 5.8.7 or later, the warning is moot and should > be suppressed.
There is indeed a check for exactly this, provided the perl-prereq-setting plugin runs first (see "dzil build -VGit::Contributors" for more insight): https://metacpan.org/source/ETHER/Dist-Zilla-Plugin-Git-Contributors-0.034/lib/Dist/Zilla/Plugin/Git/Contributors.pm#L95-109