Skip Menu |

This queue is for tickets about the Unix-Statgrab CPAN distribution.

Report information
The Basics
Id: 125204
Status: resolved
Priority: 0/
Queue: Unix-Statgrab
People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.111
Fixed in: 0.112

History Show all quoted text
  Wed Apr 25 01:40:56 2018 SREZIC [...] cpan.org - Ticket created
Subject: Undefined symbol "sg_get_disk_io_stats_diff_between"
The test suite started to fail on all of my smokers: ... Bailout called. Further testing stopped: Couldn't load Unix::Statgrab # Failed test 'use Unix::Statgrab;' # at t/00-load.t line 7. # Tried to use 'Unix::Statgrab'. # Error: Can't load '/home/cpansand/.cpan/build/2018042409/Unix-Statgrab-0.111-JuEyfq/blib/arch/auto/Unix/Statgrab/Statgrab.so' for module Unix::Statgrab: /home/cpansand/.cpan/build/2018042409/Unix-Statgrab-0.111-JuEyfq/blib/arch/auto/Unix/Statgrab/Statgrab.so: Undefined symbol "sg_get_disk_io_stats_diff_between" at /usr/perl5.22.4p/lib/5.22.4/amd64-freebsd/DynaLoader.pm line 193. # # Compilation failed in require at t/00-load.t line 7. # BEGIN failed--compilation aborted at t/00-load.t line 7. FAILED--Further testing stopped: Couldn't load Unix::Statgrab *** Error code 255 ... Possible reason: a change in Config::AutoConf. Statistical analysis: **************************************************************** Regression 'mod:Config::AutoConf' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0261 38.32 [1='eq_0.313'] -0.0192 0.0276 -0.70 [2='eq_0.314'] -0.0000 0.0309 -0.00 [3='eq_0.315'] -0.0000 0.0309 -0.00 [4='eq_0.316'] -1.0000 0.0283 -35.37 R^2= 0.961, N= 245, K= 5 ****************************************************************
  Wed Apr 25 03:20:07 2018 REHSACK [...] cpan.org - Correspondence added
On Wed Apr 25 01:40:56 2018, SREZIC wrote: Show quoted text
> The test suite started to fail on all of my smokers: > > ... > Bailout called. Further testing stopped: Couldn't load > Unix::Statgrab > # Failed test 'use Unix::Statgrab;' > # at t/00-load.t line 7. > # Tried to use 'Unix::Statgrab'. > # Error: Can't load '/home/cpansand/.cpan/build/2018042409/Unix- > Statgrab-0.111-JuEyfq/blib/arch/auto/Unix/Statgrab/Statgrab.so' for > module Unix::Statgrab: /home/cpansand/.cpan/build/2018042409/Unix- > Statgrab-0.111-JuEyfq/blib/arch/auto/Unix/Statgrab/Statgrab.so: > Undefined symbol "sg_get_disk_io_stats_diff_between" at > /usr/perl5.22.4p/lib/5.22.4/amd64-freebsd/DynaLoader.pm line 193. > # # Compilation failed in require at t/00-load.t line 7. > # BEGIN failed--compilation aborted at t/00-load.t line 7. > FAILED--Further testing stopped: Couldn't load Unix::Statgrab > *** Error code 255 > ... > > > Possible reason: a change in Config::AutoConf. Statistical analysis: > > **************************************************************** > Regression 'mod:Config::AutoConf' > **************************************************************** > Name Theta StdErr T-stat > [0='const'] 1.0000 0.0261 38.32 > [1='eq_0.313'] -0.0192 0.0276 -0.70 > [2='eq_0.314'] -0.0000 0.0309 -0.00 > [3='eq_0.315'] -0.0000 0.0309 -0.00 > [4='eq_0.316'] -1.0000 0.0283 -35.37 > > R^2= 0.961, N= 245, K= 5 > ****************************************************************
You're right. Seems I need to do an intermediate release.
  Wed Apr 25 03:20:08 2018 The RT System itself - Status changed from 'new' to 'open'
  Fri May 04 07:53:37 2018 ppisar [...] redhat.com - Correspondence added
Dne St 25.dub.2018 01:40:56, SREZIC napsal(a): Show quoted text
> # Error: Can't load '/home/cpansand/.cpan/build/2018042409/Unix- > Statgrab-0.111-JuEyfq/blib/arch/auto/Unix/Statgrab/Statgrab.so' for > module Unix::Statgrab: /home/cpansand/.cpan/build/2018042409/Unix- > Statgrab-0.111-JuEyfq/blib/arch/auto/Unix/Statgrab/Statgrab.so: > Undefined symbol "sg_get_disk_io_stats_diff_between" at > /usr/perl5.22.4p/lib/5.22.4/amd64-freebsd/DynaLoader.pm line 193.
It looks like Config::AutoConf 0.316 provides data in this way: $autoconf->{extra_link_flags} "" $autoconf->{extra_libs} "statgrab" $autoconf->_get_extra_linker_flags "-lstatgrab" Also the Makefile.PL should populate LIBS (with [$autoconf->_get_extra_linker_flags]) and not setting internal EXTRALIBS and LDLOADLIBS. ExtUtils::MakeMaker complains about that.
  Fri May 04 08:12:01 2018 REHSACK [...] cpan.org - Correspondence added
Petr, thanks for the analysis. You're completely right and when the damned real life wouldn't had interfered, I would have released an update already. I schedule it as soon as possible, but it might take some more days :(
  Fri May 04 08:28:04 2018 ppisar [...] redhat.com - Reference by ticket #125274 added
  Fri Jun 08 08:04:57 2018 ppisar [...] redhat.com - Correspondence added
A fix is attached.
Subject: Unix-Statgrab-0.111-Adapt-to-Config-AutoConf-0.316.patch
From 60a05203c58fa24c434390deab6ca61110b22a49 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Fri, 8 Jun 2018 13:34:28 +0200 Subject: [PATCH] Adapt to Config::AutoConf 0.316 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit CPAN RT#125204 Signed-off-by: Petr Písař <ppisar@redhat.com> --- Makefile.PL | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index f158f33..abfffe2 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -23,7 +23,7 @@ my %CONFIGURE_DEPS = ( 'ExtUtils::Constant' => '0.21', 'Capture::Tiny' => '0.06', 'ExtUtils::CBuilder' => '0.27', - 'Config::AutoConf' => '0.308', + 'Config::AutoConf' => '0.316', 'File::Basename' => 0, 'File::Spec' => 0, 'Text::ParseWords' => 0, @@ -106,9 +106,8 @@ WriteMakefile1( AUTHOR => [ 'Tassilo von Parseval <tassilo.von.parseval@rwth-aachen.de>', 'Jens Rehsack <sno@NetBSD.org>' ], XS => { $xsfile => "Statgrab.c" }, OBJECT => q/$(O_FILES)/, - INC => join( " ", @{ $autoconf->{extra_preprocess_flags} } ), - EXTRALIBS => join( " ", @{ $autoconf->{extra_link_flags} } ), - LDLOADLIBS => join( " ", @{ $autoconf->{extra_link_flags} } ), + INC => $autoconf->_get_extra_compiler_flags, + LIBS => $autoconf->_get_extra_linker_flags, CONFIGURE_REQUIRES => \%CONFIGURE_DEPS, PREREQ_PM => \%RUN_DEPS, BUILD_REQUIRES => \%BUILD_DEPS, -- 2.14.4
  Sat Jun 09 07:21:22 2018 REHSACK [...] cpan.org - Correspondence added
I decided to bump to 0.317 - but beside from that, I think it's done.
  Sat Jun 09 07:21:23 2018 REHSACK [...] cpan.org - Status changed from 'open' to 'resolved'
  Sat Jun 09 07:21:23 2018 REHSACK [...] cpan.org - Fixed in 0.112 added