On Fri Apr 20 09:30:28 2018, DMUEY wrote:
Show quoted text> Thanks! patches in
https://github.com/drmuey/p5-File-Copy-Recursive/pull/13
>
> On Fri Apr 20 01:31:13 2018, SREZIC wrote:
> > A test fails if File::Find::Rule is not installed --- so the prereq
> > list should be adjusted, or the failing test should be skipped if the
> > prereq is not met:
> >
> > ...
> > Can't locate File/Find/Rule.pm in @INC (you may need to install the
> > File::Find::Rule module) (@INC contains:
> > /home/cpansand/.cpan/build/2018042000/File-Copy-Recursive-0.41-
> > xaN2Nk/blib/lib /home/cpansand/.cpan/build/2018042000/File-Copy-
> > Recursive-0.41-xaN2Nk/blib/arch
> > /home/cpansand/.cpan/build/2018042000/Test-File-1.443-AGM8VQ/blib/arch
> > /home/cpansand/.cpan/build/2018042000/Test-File-1.443-AGM8VQ/blib/lib
> > /home/cpansand/.cpan/build/2018042000/Test-utf8-1.01-wjJITp/blib/arch
> > /home/cpansand/.cpan/build/2018042000/Test-utf8-1.01-wjJITp/blib/lib
> > /home/cpansand/.cpan/build/2018042000/Test-File-1.443-AGM8VQ/blib/arch
> > /home/cpansand/.cpan/build/2018042000/Test-File-1.443-AGM8VQ/blib/lib
> > /home/cpansand/.cpan/build/2018042000/Test-utf8-1.01-wjJITp/blib/arch
> > /home/cpansand/.cpan/build/2018042000/Test-utf8-1.01-wjJITp/blib/lib
> > /usr/perl5.22.4p/lib/site_perl/5.22.4/amd64-freebsd
> > /usr/perl5.22.4p/lib/site_perl/5.22.4
> > /usr/perl5.22.4p/lib/5.22.4/amd64-freebsd /usr/perl5.22.4p/lib/5.22.4
> > .) at t/05.legacy-pathmk_unc.t line 6.
> > BEGIN failed--compilation aborted at t/05.legacy-pathmk_unc.t line 6.
> > t/05.legacy-pathmk_unc.t ..
> > Dubious, test returned 2 (wstat 512, 0x200)
> > No subtests run
> > ...
>
>
This problem cannot be considered resolved until a new release of File-Copy-Recursive which includes File-Find-Rule in its Makefile.PL prerequisites has been released to CPAN.
Today, in the wake of yesterday's release of perl-5.27.11, I ran my program which installs the dev release and then uses 'cpanm' to install 1000 CPAN distributions in the order in which they appear in the "CPAN river", i.e., the dependency order inferred from their metadata. File-Copy-Recursive failed at the point described in this RT (excerpt of build.log attached). As a consequence, 'cpanm' abandoned its attempts to install all other distributions in the top 1000 which declare File-Copy-Recursive as a dependency. There are over 30 such distributions, including DateTime and Dist-Zilla.
Though the specific problem reported in
https://rt.cpan.org/Ticket/Display.html?id=123964 was resolved by the release of version 0.41 has been resolved, the *general* problem remains: File-Copy-Recursive has so many reverse dependencies that any build or test failures which cause it to fail to be installed prevents those other distributions from being reached by 'cpan' and 'cpanm'. Unlike the situation in RT 123964, this specific problem is not OS-specific; this version of my test-against-dev program runs on Linux.
I see from your github.com repository that you are planning a 0.42 release. I hope that includes a fix for this prerequisite problem.
I note also that Karen Etheridge, who has tremendous experience with Perl toolchain libraries, has filed a pull request (
https://github.com/drmuey/p5-File-Copy-Recursive/pull/16), part of which (
https://github.com/drmuey/p5-File-Copy-Recursive/pull/16/commits/7a6affe863a832857838c8f5e6af15f56c05fd0f) removes FCR's dependency on File-Find-Rule entirely. This p.r. certainly deserves consideration. However, if it's going to take time to fully evaluate her p.r., I recommend releasing to CPAN a version which declares the dependency so that the immediate problem gets fixed. That would restore installability of FCR's revdeps and give you time to evaluate the other aspects of her pull request.
Thank you very much.
Jim Keenan
{
author => "DMUEY",
dist => "File-Copy-Recursive",
distname => "File-Copy-Recursive-0.41",
distversion => 0.41,
grade => "FAIL",
prereqs => undef,
test_output => [
"Building and testing File-Copy-Recursive-0.41",
"cp lib/File/Copy/Recursive.pm blib/lib/File/Copy/Recursive.pm",
"PERL_DL_NONLAZY=1 \"/home/jkeenan/var/tad/testing/perl-5.27.11/bin/perl\" \"-MExtUtils::Command::MM\" \"-MTest::Harness\" \"-e\" \"undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')\" t/*.t",
"t/00.load.t ............... ok",
"t/01.legacy.t ............. ok",
"t/02.legacy-symtogsafe.t .. ok",
"t/03.github-issue-5.t ..... ok",
"t/04.readonly-dir.t ....... ok",
"Can't locate File/Find/Rule.pm in \@INC (you may need to install the File::Find::Rule module) (\@INC contains: /home/jkeenan/var/tad/testing/perl-5.27.11/.cpanm/work/1524305196.5745/File-Copy-Recursive-0.41/blib/lib /home/jkeenan/var/tad/testing/perl-5.27.11/.cpanm/work/1524305196.5745/File-Copy-Recursive-0.41/blib/arch /home/jkeenan/var/tad/testing/perl-5.27.11/lib/site_perl/5.27.11/x86_64-linux /home/jkeenan/var/tad/testing/perl-5.27.11/lib/site_perl/5.27.11 /home/jkeenan/var/tad/testing/perl-5.27.11/lib/5.27.11/x86_64-linux /home/jkeenan/var/tad/testing/perl-5.27.11/lib/5.27.11 .) at t/05.legacy-pathmk_unc.t line 6.",
"BEGIN failed--compilation aborted at t/05.legacy-pathmk_unc.t line 6.",
"t/05.legacy-pathmk_unc.t .. ",
"Dubious, test returned 2 (wstat 512, 0x200)",
"No subtests run ",
"",
"Test Summary Report",
"-------------------",
"t/05.legacy-pathmk_unc.t (Wstat: 512 Tests: 0 Failed: 0)",
" Non-zero exit status: 2",
" Parse errors: No plan found in TAP output",
"Files=6, Tests=156, 1 wallclock secs ( 0.05 usr 0.01 sys + 0.75 cusr 0.24 csys = 1.05 CPU)",
"Result: FAIL",
],
via => "App::cpanminus::reporter 0.17 (1.7043)",
}
