| Subject: | truncated_utf8.t TODO test pass in blead |
| Date: | Thu, 19 Apr 2018 14:39:28 +0100 |
| To: | bug-Encode [...] rt.cpan.org |
| From: | Dave Mitchell <davem [...] iabyn.com> |
I've just applied the commit below to bleadperl.
I'm making the assumption that the TODO issue is genuinely fixed.
Author: David Mitchell <davem@iabyn.com>
AuthorDate: Thu Apr 19 14:10:35 2018 +0100
Encode: truncated_utf8.t TODO passes
This TODO test has been passing since the combination of:
v5.27.8-40-g37657a5b6c
which added utf8n_to_uvchr_msgs to the perl API
v5.27.8-252-gc31ca2013f
which upgraded blead to Encode 2.96, which makes use of this new
function if available.
So stop marking it as TODO in blead.
This is patching a cpan/ distribution, but its only a test, and its a
bit late in code freeze to install a newer Encode released, while we
don't want a production perl with spurious passing TODO tests.
....
diff --git a/cpan/Encode/t/truncated_utf8.t b/cpan/Encode/t/truncated_utf8.t
index 7de8bb9ac1..b379267664 100644
--- a/cpan/Encode/t/truncated_utf8.t
+++ b/cpan/Encode/t/truncated_utf8.t
@@ -45,7 +45,7 @@ SKIP: {
is($str2, ("x" x 1023) . ("\x{fffd}" x 3) . "x");
TODO: {
- local $TODO = "bug in perlio";
+ local $TODO = "bug in perlio" if $] < 5.027009;
my $str = ("x" x 1023) . "\xfd\xfe\xff";
open my $fh, '<:encoding(UTF-8)', \$str;
my $str2 = <$fh>;
--
Indomitable in retreat, invincible in advance, insufferable in victory
-- Churchill on Montgomery