Skip Menu |

This queue is for tickets about the Parse-DMIDecode CPAN distribution.

Report information
The Basics
Id: 125088
Status: open
Priority: 0/
Queue: Parse-DMIDecode

People
Owner: Nobody in particular
Requestors: POTATOGIM [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: (no value)
Fixed in: (no value)



Subject: Memory leaks in Parse::DMIDecode::Handle
Hello. I used this package to get SMBIOS data with dmidecode. Meanwhile, I found some weird leaks when I call probe() method. On closer examination, It caused by absence of destructor for Parse::DMIDecode::Handle's instance. I attach a patch in order to resolve this bug.
Subject: handle.patch
--- Parse/DMIDecode/Handle.pm 2018-04-14 20:49:43.095570423 +0900 +++ Parse/DMIDecode/Handle.pm.new 2018-04-14 20:49:14.208129469 +0900 @@ -285,6 +285,10 @@ return (\%data,\%keywords); } +sub DESTROY { + my $self = shift; + delete $objstore->{_refaddr($self)}; +} sub TRACE { return unless $DEBUG;
Subject: Re: [rt.cpan.org #125088] Memory leaks in Parse::DMIDecode::Handle
Date: Sat, 14 Apr 2018 17:14:28 +0100
To: bug-Parse-DMIDecode [...] rt.cpan.org
From: Nicola Worthington <nicolaw [...] tfb.net>
Patch has been applied to source repository - many thanks for the patch. Much appreciated. I'll attempt to push this to PAUSE shortly. (I've not pushed anything in a decade!) On 14 April 2018 at 12:53, Ji-Hyeon Gim via RT < bug-Parse-DMIDecode@rt.cpan.org> wrote: Show quoted text
> Sat Apr 14 07:53:07 2018: Request 125088 was acted upon. > Transaction: Ticket created by POTATOGIM > Queue: Parse-DMIDecode > Subject: Memory leaks in Parse::DMIDecode::Handle > Broken in: (no value) > Severity: Critical > Owner: Nobody > Requestors: POTATOGIM@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=125088 > > > > Hello. > > I used this package to get SMBIOS data with dmidecode. > > Meanwhile, I found some weird leaks when I call probe() method. > > On closer examination, It caused by absence of destructor for > Parse::DMIDecode::Handle's instance. > > I attach a patch in order to resolve this bug. >
-- Nicola Worthington +44 (0)3333 406 333 https://nicolaw.uk nicolaw@tfb.net