Skip Menu |

This queue is for tickets about the DBD-SQLite CPAN distribution.

Report information
The Basics
Id: 125068
Status: resolved
Priority: 0/
Queue: DBD-SQLite

People
Owner: Nobody in particular
Requestors: blgl [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: make test fails under some shells.
Some shells interpret the special glob pattern **/ to mean any number of subdirectory levels, including 0. The expansion of t/*.t t/**/*.t will then include duplicate filenames, which elicits complaints from the test harness.
Subject: 0001-Some-shells-interpret-the-special-glob-pattern-to-me.patch
From f8062e26d65e916b973ac5e2ec9e1880a117b40b Mon Sep 17 00:00:00 2001 From: Bo Lindbergh <blgl@stacken.kth.se> Date: Wed, 11 Apr 2018 01:35:59 +0200 Subject: [PATCH] Some shells interpret the special glob pattern **/ to mean any number of subdirectory levels, including 0. --- Makefile.PL | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index aca8187..1175783 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -395,7 +395,7 @@ WriteMakefile( FILES => 'SQLite.xsi config.h tv.log *.old', }, test => { - TESTS => 't/*.t t/**/*.t', + TESTS => 't/*.t t/*/*.t', }, PL_FILES => {}, EXE_FILES => [], -- 2.16.3
On Wed Apr 11 09:06:19 2018, BLGL wrote: Show quoted text
> Some shells interpret the special glob pattern **/ to mean any number > of subdirectory levels, including 0. The expansion of t/*.t t/**/*.t > will then include duplicate filenames, which elicits complaints > from the test harness.
Thanks. Applied. https://github.com/DBD-SQLite/DBD-SQLite/commit/817956ba5b390cecac52f485c651ab8bc91e5bda
On Tue May 01 14:22:28 2018, ISHIGAKI wrote: Show quoted text
> On Wed Apr 11 09:06:19 2018, BLGL wrote:
> > Some shells interpret the special glob pattern **/ to mean any number > > of subdirectory levels, including 0. The expansion of t/*.t t/**/*.t > > will then include duplicate filenames, which elicits complaints > > from the test harness.
> > Thanks. Applied. > https://github.com/DBD-SQLite/DBD- > SQLite/commit/817956ba5b390cecac52f485c651ab8bc91e5bda
DBD::SQLite 1.60 with this patch was released. Thanks.