| Subject: | "If-Modified-Since" comparison is inverted in not_cached() |
| Date: | Wed, 28 Mar 2018 14:17:00 +0200 |
| To: | bug-Catalyst-Plugin-Cache-HTTP-Preempt [...] rt.cpan.org |
| From: | Martijn van de Streek <martijn [...] vandestreek.net> |
In our project we're using Catalyst::Plugin::Cache::HTTP::Preempt, and
we found that sometimes pages weren't being reloaded despite the
Last-Modified having changed.
Usually this isn't a problem, because an "ETag"-header is also generated
(and if that doesn't match, "not_cached" returns true anyway) but on
some of our responses we turned off the "ETag" explicitly, and those are
behaving strangely.
I've attached a patch that fixes the problem, by swapping the operands
of the "If-Modified-Since" comparison.
Regards,
Martijn
Message body is not shown because sender requested not to inline it.