Skip Menu |

This queue is for tickets about the DB_File CPAN distribution.

Report information
The Basics
Id: 124944
Status: resolved
Priority: 0/
Queue: DB_File

People
Owner: Nobody in particular
Requestors: BULKDD [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.840
Fixed in: 1.841



Subject: [PATCH] allow ppport.h-less builds in core
A non-functioning provision for not #including ppport.h has existed in DB_file.xs since 1.800. An unconditional -D in Makefile.PL was added in 1.818 but implementation still broken for not including ppport inside core. Fix the Makefile.PL so the no-ppport code works. This change will allow for this module to be removed from mkppport.lst and eventually removal of the mkppport script and more parallelzation while building everything inside the core p5p makefile.
Subject: 0001-allow-ppport.h-less-builds-in-core.patch
From fe49986ea15a375308015f1218b6cc7ce712aef2 Mon Sep 17 00:00:00 2001 From: Daniel Dragan <bulk88@hotmail.com> Date: Tue, 27 Mar 2018 18:53:49 -0400 Subject: [PATCH] allow ppport.h-less builds in core A non-functioning provision for not #including ppport.h has existed in DB_file.xs since 1.800. An unconditional -D in Makefile.PL was added in 1.818 but implementation still broken for not including ppport inside core. Fix the Makefile.PL so the no-ppport code works. This change will allow for this module to be removed from mkppport.lst and eventually removal of the mkppport script and more parallelzation while building everything inside the core p5p makefile. --- cpan/DB_File/Makefile.PL | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/cpan/DB_File/Makefile.PL b/cpan/DB_File/Makefile.PL index f5ef7c8..0e8b4d3 100644 --- a/cpan/DB_File/Makefile.PL +++ b/cpan/DB_File/Makefile.PL @@ -41,6 +41,8 @@ $OS2 = "-DOS2" if $Config{'osname'} eq 'os2' ; my $WALL = '' ; #$WALL = ' -Wall '; +my $CORE = $ENV{PERL_CORE} ? '' : '-D_NOT_CORE'; + WriteMakefile( NAME => 'DB_File', LIBS => ["-L${LIB_DIR} $LIBS"], @@ -48,7 +50,7 @@ WriteMakefile( VERSION_FROM => 'DB_File.pm', XS_VERSION => eval MM->parse_version('DB_File.pm'), XSPROTOARG => '-noprototypes', - DEFINE => "-D_NOT_CORE $OS2 $VER_INFO $COMPAT185 $WALL", + DEFINE => "$CORE $OS2 $VER_INFO $COMPAT185 $WALL", OBJECT => 'version$(OBJ_EXT) DB_File$(OBJ_EXT)', ((ExtUtils::MakeMaker->VERSION() gt '6.30') ? ('LICENSE' => 'perl') -- 1.8.0.msysgit.0
Patch applied. Version 1.841 just uploaded to CPAN