Skip Menu |

This queue is for tickets about the Dist-Zilla-Plugin-MinimumPerl CPAN distribution.

Report information
The Basics
Id: 124900
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Plugin-MinimumPerl

People
Owner: Nobody in particular
Requestors: hartzell [...] alerce.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



The MinimumPerl plugin does not catch the fact that the TestCompile plugin requires 5.006. This results in META.{yml,json} files that require 5.004 and/but Makefile.PL's the require 5.006. See https://github.com/hartzell/moox-strictconstructor/issues/12 for the backstory. This dist.ini file: <------------ snip --------------> name = MinTest author = George Hartzell <hartzell@cpan.org> license = Perl_5 copyright_holder = George Hartzell main_module = lib/MinTest.pm version = 1.0.0 [@Basic] [Test::Compile] [MinimumPerl] <------------ snip --------------> and this lib/MinPerl.pm: <------------ snip --------------> package MinTest; # ABSTRACT: turns baubles into trinkets 1; <------------ snip --------------> will reproduce the problem (run `dzil build`, check the META.yml and Makefile.PL files).
Sorry, forgot to say: Tested with Show quoted text
> This is perl 5, version 26, subversion 1 (v5.26.1) built for darwin-thread-multi-2level
built via Homebrew on a Mac running 10.11.6.
On 2018-03-24 13:53:07, HARTZELL wrote: Show quoted text
> The MinimumPerl plugin does not catch the fact that the TestCompile > plugin requires 5.006. This results in META.{yml,json} files that > require 5.004 and/but Makefile.PL's the require 5.006.
Yes it did. Makefile.PL has MINIMUM_PERL_VERSION set to 5.006, which is correct. META.yml also specifies 5.006 in build_requires (which is where test prereqs go in meta spec 1.4 -- if you want to see 'test' phase prereqs, add META.json to your distribution via the [MetaJSON] plugin.
@karenetheridge pointed out that I was missing the distinction between a module's prereqs and it's test prereqs. This was a false alarm. Sorry for the distraction.