Skip Menu |

This queue is for tickets about the HTTP-Caching CPAN distribution.

Report information
The Basics
Id: 124849
Status: resolved
Priority: 0/
Queue: HTTP-Caching

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc: oalders [...] cpan.org
AdminCc:

Bug Information
Severity: Important
Broken in: 0.11
Fixed in: (no value)



CC: oalders [...] cpan.org
Subject: Tests started to fail (with latest HTTP::Message?)
The test suite started to fail: ... # Failed test 'use HTTP::Caching;' # at t/00_use_ok_and_methods.t line 9. # Tried to use 'HTTP::Caching'. # Error: Adding HTTP::Status::is_cacheable_by_default: must not already exist at /home/cpansand/.cpan/build/2018032109/Monkey-Patch-Action-0.05-0/blib/lib/Monkey/Patch/Action.pm line 28. # Compilation failed in require at t/00_use_ok_and_methods.t line 9. # BEGIN failed--compilation aborted at t/00_use_ok_and_methods.t line 9. # Looks like you failed 1 test of 1. # Failed test 'HTTP::Caching' # at t/00_use_ok_and_methods.t line 10. # Looks like you failed 1 test of 4. t/00_use_ok_and_methods.t ............ Dubious, test returned 1 (wstat 256, 0x100) Failed 1/4 subtests ... This seems to happen with the latest HTTP-Message release. Statistical analysis: **************************************************************** Regression 'mod:HTTP::Request' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0000 34273577915320768.00 [1='eq_6.13'] -0.0000 0.0000 -2.57 [2='eq_6.14'] -0.0000 0.0000 -3.70 [3='eq_6.15'] -1.0000 0.0000 -30655220020317108.00 R^2= 1.000, N= 80, K= 4 **************************************************************** (12) **************************************************************** Regression 'mod:HTTP::Response' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0000 34273577915320768.00 [1='eq_6.13'] -0.0000 0.0000 -2.57 [2='eq_6.14'] -0.0000 0.0000 -3.70 [3='eq_6.15'] -1.0000 0.0000 -30655220020317108.00 R^2= 1.000, N= 80, K= 4 ****************************************************************
Subject: Re: [rt.cpan.org #124849] Tests started to fail (with latest HTTP::Message?)
Date: Wed, 21 Mar 2018 22:01:40 +0100
To: bug-HTTP-Caching [...] rt.cpan.org
From: Theo van Hoesel <th.j.v.hoesel [...] gmail.com>
Oh... actually that is great news ! I monkey-patched that method, but than lately I made a merge request to have it ‘officially’ included in the HTTP::Message.... However I wasn’t aware that it would cause breakage once it was ‘officially’ already installed... Will come with a fix soon THANKS!!!! Show quoted text
> On 21 Mar 2018, at 21:30, Slaven_Rezic via RT <bug-HTTP-Caching@rt.cpan.org> wrote: > > Wed Mar 21 16:30:14 2018: Request 124849 was acted upon. > Transaction: Ticket created by SREZIC > Queue: HTTP-Caching > Subject: Tests started to fail (with latest HTTP::Message?) > Broken in: 0.11 > Severity: (no value) > Owner: Nobody > Requestors: SREZIC@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124849 > > > > The test suite started to fail: > > ... > # Failed test 'use HTTP::Caching;' > # at t/00_use_ok_and_methods.t line 9. > # Tried to use 'HTTP::Caching'. > # Error: Adding HTTP::Status::is_cacheable_by_default: must not already exist at /home/cpansand/.cpan/build/2018032109/Monkey-Patch-Action-0.05-0/blib/lib/Monkey/Patch/Action.pm line 28. > # Compilation failed in require at t/00_use_ok_and_methods.t line 9. > # BEGIN failed--compilation aborted at t/00_use_ok_and_methods.t line 9. > # Looks like you failed 1 test of 1. > > # Failed test 'HTTP::Caching' > # at t/00_use_ok_and_methods.t line 10. > # Looks like you failed 1 test of 4. > t/00_use_ok_and_methods.t ............ > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/4 subtests > ... > > This seems to happen with the latest HTTP-Message release. Statistical analysis: > > **************************************************************** > Regression 'mod:HTTP::Request' > **************************************************************** > Name Theta StdErr T-stat > [0='const'] 1.0000 0.0000 34273577915320768.00 > [1='eq_6.13'] -0.0000 0.0000 -2.57 > [2='eq_6.14'] -0.0000 0.0000 -3.70 > [3='eq_6.15'] -1.0000 0.0000 -30655220020317108.00 > > R^2= 1.000, N= 80, K= 4 > **************************************************************** > (12) > **************************************************************** > Regression 'mod:HTTP::Response' > **************************************************************** > Name Theta StdErr T-stat > [0='const'] 1.0000 0.0000 34273577915320768.00 > [1='eq_6.13'] -0.0000 0.0000 -2.57 > [2='eq_6.14'] -0.0000 0.0000 -3.70 > [3='eq_6.15'] -1.0000 0.0000 -30655220020317108.00 > > R^2= 1.000, N= 80, K= 4 > **************************************************************** >
Fixed, removed the Monkey Patch