Bug #124763 for CGI-Session: Store expiry TS to make cleaning stale sessions easier.

Mon Mar 12 15:36:48 2018 IKEGAMI [...] cpan.org - Ticket created

Subject:

Store expiry TS to make cleaning stale sessions easier.

Hi, Could you pass C<< atime >> and C<< defined(etime) ? atime+etime : undef >> as extra arguments to C<< $driver->store >>, and modify C<< $driver->store >> to store those values? Then, we could do something like the following to clean up stale sessions rather than loading each one individually: DELETE FROM `Session` WHERE `etime` >= NOW(); Of course, at least part of this change would have to be optional for backwards compatibility.

Mon Mar 12 15:38:00 2018 IKEGAMI [...] cpan.org - Correspondence added

If you are amenable to this change, I can provide a patch. On Mon Mar 12 15:36:48 2018, ikegami wrote: Show quoted text

> Hi, > > Could you pass C<< atime >> and C<< defined(etime) ? atime+etime : > undef >> as extra arguments to C<< $driver->store >>, and modify C<< > $driver->store >> to store those values? > > Then, we could do something like the following to clean up stale > sessions rather than loading each one individually: > > DELETE FROM `Session` WHERE `etime` >= NOW(); > > Of course, at least part of this change would have to be optional for > backwards compatibility.

Mon Mar 12 19:00:26 2018 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #124763] Store expiry TS to make cleaning stale sessions easier.
Date:	Tue, 13 Mar 2018 09:53:06 +1100
To:	bug-CGI-Session [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi Thanx for the 2 emails. Firstly, have you seen my version of CGI::Session, called Data::Session? It has some extras: https://metacpan.org/pod/Data::Session#check_expiry() On 13/03/18 06:38, ikegami via RT wrote: Show quoted text

> Queue: CGI-Session > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124763 > > > If you are amenable to this change, I can provide a patch. > > On Mon Mar 12 15:36:48 2018, ikegami wrote:

>> Hi, >> >> Could you pass C<< atime >> and C<< defined(etime) ? atime+etime : >> undef >> as extra arguments to C<< $driver->store >>, and modify C<< >> $driver->store >> to store those values? >> >> Then, we could do something like the following to clean up stale >> sessions rather than loading each one individually: >> >> DELETE FROM `Session` WHERE `etime` >= NOW(); >> >> Of course, at least part of this change would have to be optional for >> backwards compatibility.

-- Ron Savage - savage.net.au

Mon Mar 12 19:00:27 2018 The RT System itself - Status changed from 'new' to 'open'

Tue Mar 13 03:03:06 2018 ikegami [...] adaelis.com - Correspondence added

CC:	IKEGAMI [...] cpan.org
Subject:	Re: [rt.cpan.org #124763] Store expiry TS to make cleaning stale sessions easier.
Date:	Tue, 13 Mar 2018 03:02:56 -0400
To:	bug-CGI-Session [...] rt.cpan.org
From:	Eric Brine <ikegami [...] adaelis.com>

Data::Session->check_expiry doesn't do anything CGI::Session->load doesn't already do. I don't see how that helps in the least. On Mon, Mar 12, 2018 at 7:00 PM, ron@savage.net.au via RT < bug-CGI-Session@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=124763 > > > Hi > > Thanx for the 2 emails. > > Firstly, have you seen my version of CGI::Session, called Data::Session? > > It has some extras: > > https://metacpan.org/pod/Data::Session#check_expiry() > > On 13/03/18 06:38, ikegami via RT wrote:

> > Queue: CGI-Session > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124763 > > > > > If you are amenable to this change, I can provide a patch. > > > > On Mon Mar 12 15:36:48 2018, ikegami wrote:

> >> Hi, > >> > >> Could you pass C<< atime >> and C<< defined(etime) ? atime+etime : > >> undef >> as extra arguments to C<< $driver->store >>, and modify C<< > >> $driver->store >> to store those values? > >> > >> Then, we could do something like the following to clean up stale > >> sessions rather than loading each one individually: > >> > >> DELETE FROM `Session` WHERE `etime` >= NOW(); > >> > >> Of course, at least part of this change would have to be optional for > >> backwards compatibility.

> > -- > Ron Savage - savage.net.au >

Tue Mar 13 03:08:18 2018 ron [...] savage.net.au - Correspondence added

Subject:	Re: [rt.cpan.org #124763] Store expiry TS to make cleaning stale sessions easier.
Date:	Tue, 13 Mar 2018 18:08:01 +1100
To:	bug-CGI-Session [...] rt.cpan.org
From:	Ron Savage <ron [...] savage.net.au>

Hi Just an idea. And now I look forward to your patch :-). On 13/03/18 18:03, ikegami@adaelis.com via RT wrote: Show quoted text

> Queue: CGI-Session > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124763 > > > Data::Session->check_expiry doesn't do anything CGI::Session->load doesn't > already do. I don't see how that helps in the least. > > On Mon, Mar 12, 2018 at 7:00 PM, ron@savage.net.au via RT < > bug-CGI-Session@rt.cpan.org> wrote: >

>> <URL: https://rt.cpan.org/Ticket/Display.html?id=124763 > >> >> Hi >> >> Thanx for the 2 emails. >> >> Firstly, have you seen my version of CGI::Session, called Data::Session? >> >> It has some extras: >> >> https://metacpan.org/pod/Data::Session#check_expiry() >> >> On 13/03/18 06:38, ikegami via RT wrote:

>>> Queue: CGI-Session >>> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124763 > >>> >>> If you are amenable to this change, I can provide a patch. >>> >>> On Mon Mar 12 15:36:48 2018, ikegami wrote:

>>>> Hi, >>>> >>>> Could you pass C<< atime >> and C<< defined(etime) ? atime+etime : >>>> undef >> as extra arguments to C<< $driver->store >>, and modify C<< >>>> $driver->store >> to store those values? >>>> >>>> Then, we could do something like the following to clean up stale >>>> sessions rather than loading each one individually: >>>> >>>> DELETE FROM `Session` WHERE `etime` >= NOW(); >>>> >>>> Of course, at least part of this change would have to be optional for >>>> backwards compatibility.

>> >> -- >> Ron Savage - savage.net.au >>

-- Ron Savage - savage.net.au

Tue Mar 13 08:49:55 2018 ikegami [...] adaelis.com - Correspondence added

CC:	IKEGAMI [...] cpan.org
Subject:	Re: [rt.cpan.org #124763] Store expiry TS to make cleaning stale sessions easier.
Date:	Tue, 13 Mar 2018 08:49:36 -0400
To:	bug-CGI-Session [...] rt.cpan.org
From:	Eric Brine <ikegami [...] adaelis.com>

okie dokie! I don't have it written yet. Probably this weekend. On Tue, Mar 13, 2018 at 3:08 AM, ron@savage.net.au via RT < bug-CGI-Session@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=124763 > > > Hi > > Just an idea. > > And now I look forward to your patch :-). > > On 13/03/18 18:03, ikegami@adaelis.com via RT wrote:

> > Queue: CGI-Session > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124763 > > > > > Data::Session->check_expiry doesn't do anything CGI::Session->load

> doesn't

> > already do. I don't see how that helps in the least. > > > > On Mon, Mar 12, 2018 at 7:00 PM, ron@savage.net.au via RT < > > bug-CGI-Session@rt.cpan.org> wrote: > >

> >> <URL: https://rt.cpan.org/Ticket/Display.html?id=124763 > > >> > >> Hi > >> > >> Thanx for the 2 emails. > >> > >> Firstly, have you seen my version of CGI::Session, called Data::Session? > >> > >> It has some extras: > >> > >> https://metacpan.org/pod/Data::Session#check_expiry() > >> > >> On 13/03/18 06:38, ikegami via RT wrote:

> >>> Queue: CGI-Session > >>> Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124763 > > >>> > >>> If you are amenable to this change, I can provide a patch. > >>> > >>> On Mon Mar 12 15:36:48 2018, ikegami wrote:

> >>>> Hi, > >>>> > >>>> Could you pass C<< atime >> and C<< defined(etime) ? atime+etime : > >>>> undef >> as extra arguments to C<< $driver->store >>, and modify C<< > >>>> $driver->store >> to store those values? > >>>> > >>>> Then, we could do something like the following to clean up stale > >>>> sessions rather than loading each one individually: > >>>> > >>>> DELETE FROM `Session` WHERE `etime` >= NOW(); > >>>> > >>>> Of course, at least part of this change would have to be optional for > >>>> backwards compatibility.

> >> > >> -- > >> Ron Savage - savage.net.au > >>

> > -- > Ron Savage - savage.net.au >