Bug #124748 for XML-XSH: Perl 5.22+

Fri Mar 09 18:01:53 2018 ETJ [...] cpan.org - Ticket created

Subject:

Perl 5.22+ - no defined(@array)

As seen in https://www.cpantesters.org/cpan/report/256581a6-df89-11e7-90de-9bb3705be811 and others, this line in https://metacpan.org/source/CHOROBA/XML-XSH-1.8.5/lib/XML/XSH/Completion.pm#L111 unless (defined @PATH_HASH) { is a fatal error on at least 5.22. Could you just remove the "defined"?

Fri Mar 09 18:42:18 2018 CHOROBA [...] cpan.org - Correspondence added

This distribution is deprecated. Use XML::XSH2 instead. I'll try to avoid automatic test runs in the future release.

Fri Mar 09 18:42:19 2018 The RT System itself - Status changed from 'new' to 'open'

Fri Mar 09 18:43:08 2018 CHOROBA [...] cpan.org - TimeWorked changed from (no value) to '15'

Fri Mar 09 18:43:08 2018 CHOROBA [...] cpan.org - Status changed from 'open' to 'rejected'

Fri Mar 09 18:43:08 2018 CHOROBA [...] cpan.org - Taken

Fri Mar 09 20:51:10 2018 ETJ [...] cpan.org - Correspondence added

On Fri Mar 09 18:42:18 2018, CHOROBA wrote: Show quoted text

> This distribution is deprecated. Use XML::XSH2 instead. I'll try to > avoid automatic test runs in the future release.

I did see the deprecation notice. I noticed the issue because Inline::XSH is installed on a Perl 5.22 and it's generating test failures for PDL there. Basically I think that just skipping all the tests (as I notice you are doing) because it's deprecated isn't doing anyone any favours; it's generating completely spurious fails for others. Therefore, I think the least harm would be done by de-skipping the tests so that the distro doesn't get installed anymore and then create pain for others.

Fri Mar 09 20:52:15 2018 ETJ [...] cpan.org - Correspondence added

Sorry: "doesn't get installed anymore" = "doesn't get installed anymore where the tests fail because something breaks the distro completely"

Bug #124748 for XML-XSH: Perl 5.22+ - no defined(@array)