Skip Menu |

This queue is for tickets about the HTTP-XSCookies CPAN distribution.

Report information
The Basics
Id: 124742
Status: open
Priority: 0/
Queue: HTTP-XSCookies

People
Owner: Nobody in particular
Requestors: knth [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 0.000017
Fixed in: (no value)



Subject: Non-backcompat change between 0.000016 and 18
While trying to install Dancer2, a test failed, and I've traced it to here... Using 0.000016 and earlier the code: crush_cookie('foo=bar&baz') returns { foo => "bar&baz" } whereas using 0.000018 gives { foo => ["bar", "baz"] } Code in Dancer2::Core::Request expects a string to pick apart itself so it breaks on this. As far as I can tell by Changes, this is introduced in 0.000017, but was it really intended to break things downstream in this manner? Thanks, ken1
Subject: Re: [rt.cpan.org #124742] Non-backcompat change between 0.000016 and 18
Date: Fri, 9 Mar 2018 13:24:33 +0100
To: bug-HTTP-XSCookies [...] rt.cpan.org
From: Gonzalo Diethelm <gonzalo.diethelm [...] gmail.com>
Yes, this was caused by something I changed, and was already reported to me. It is being discussed in https://github.com/PerlDancer/Dancer2/issues/1435 Cheers, Gonzo On Fri, Mar 9, 2018 at 12:04 PM, Kenneth Olwing via RT < bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text
> Fri Mar 09 06:04:24 2018: Request 124742 was acted upon. > Transaction: Ticket created by KNTH > Queue: HTTP-XSCookies > Subject: Non-backcompat change between 0.000016 and 18 > Broken in: 0.000017 > Severity: Important > Owner: Nobody > Requestors: knth@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124742 > > > > While trying to install Dancer2, a test failed, and I've traced it to > here... > > Using 0.000016 and earlier the code: > > crush_cookie('foo=bar&baz') > > returns > > { foo => "bar&baz" } > > whereas using 0.000018 gives > > { foo => ["bar", "baz"] } > > Code in Dancer2::Core::Request expects a string to pick apart itself so it > breaks on this. > > As far as I can tell by Changes, this is introduced in 0.000017, but was > it really intended to break things downstream in this manner? > > Thanks, > ken1 >
-- Gonzalo Diethelm gonzalo.diethelm@gmail.com
Subject: Re: [rt.cpan.org #124742] Non-backcompat change between 0.000016 and 18
Date: Fri, 09 Mar 2018 13:41:35 +0100
To: bug-HTTP-XSCookies [...] rt.cpan.org
From: Kenneth Ă–lwing <kenneth [...] olwing.se>
Show quoted text
> Yes, this was caused by something I changed, and was already reported > to > me. It is being discussed in > https://github.com/PerlDancer/Dancer2/issues/1435
Ah ok, I'm happy that it's being worked on; have a good one! Thanks, ken1