Skip Menu |

This queue is for tickets about the HTTP-XSCookies CPAN distribution.

Report information
The Basics
Id: 124727
Status: open
Priority: 0/
Queue: HTTP-XSCookies

People
Owner: Nobody in particular
Requestors: bparees [...] redhat.com
Cc: DBOOK [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: HTTP-XSCookies-0,000017 won't compile?
Date: Thu, 8 Mar 2018 13:12:57 -0500
To: bug-HTTP-XSCookies [...] rt.cpan.org
From: Ben Parees <bparees [...] redhat.com>
installing this module I get: Running Mkbootstrap for XSCookies () chmod 644 "XSCookies.bs" "/opt/rh/rh-perl524/root/usr/bin/perl" -MExtUtils::Command::MM -e 'cp_nonempty' -- XSCooki es.bs blib/arch/auto/HTTP/XSCookies/XSCookies.bs 644 "/opt/rh/rh-perl524/root/usr/bin/perl" "/opt/rh/rh-perl524/root/usr/share/perl5/ExtUtils/x subpp" -typemap '/opt/rh/rh-perl524/root/usr/share/perl5/ExtUtils/typemap' baker.xs > ba ker.xsc mv baker.xsc baker.c gcc -c -I. -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexcept ions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune= generic -fwrapv -fno-strict-aliasing -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFS ET_BITS=64 -Wall -std=c89 -D_XOPEN_SOURCE=700 -g -DVERSION=\"0.000017\" -DXS_VERSION=\"0.000017\" -fPIC "-I/opt/rh/rh-perl524/root/usr/lib64/perl5/CORE" baker.c baker.xs: In function 'get_encoded_value': baker.xs:62:9: error: 'for' loop initial declarations are only allowed in C99 mode for (int j = 0; j <= top; ++j) { ^ baker.xs:62:9: note: use option -std=c99 or -std=gnu99 to compile your code baker.xs: In function 'search_char': baker.xs:203:5: error: 'for' loop initial declarations are only allowed in C99 mode for (int j = start; j < buf->wpos; ++j) { ^ make: *** [baker.o] Error 1 -- Ben Parees | OpenShift
Subject: Re: [rt.cpan.org #124727] HTTP-XSCookies-0,000017 won't compile?
Date: Fri, 9 Mar 2018 09:05:37 +0100
To: bug-HTTP-XSCookies [...] rt.cpan.org
From: Gonzalo Diethelm <gonzalo.diethelm [...] gmail.com>
Thanks for the report. Do you know which platform this is? Weird thing is, I see the "-std=c89" in that compilation line. I compile with "-std=c89" all of the time, and don't see that error. Maybe a GNU vs LLVM thing? Frustrating... Anyway, I reviewed all the code and removed (I hope) all these new-fangled C99-isms.We will see what happens on the next release. BTW, here is some of my platform information, just FTR. $ sw_vers ProductName: Mac OS X ProductVersion: 10.12.6 BuildVersion: 16G1212 $ cc --version Apple LLVM version 9.0.0 (clang-900.0.39.2) Target: x86_64-apple-darwin16.7.0 Thread model: posix InstalledDir: /Library/Developer/CommandLineTools/usr/bin $ perl --version This is perl 5, version 18, subversion 2 (v5.18.2) built for darwin-thread-multi-2level (with 2 registered patches, see perl -V for more detail) On Thu, Mar 8, 2018 at 7:13 PM, Ben Parees via RT < bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text
> Thu Mar 08 13:13:30 2018: Request 124727 was acted upon. > Transaction: Ticket created by bparees@redhat.com > Queue: HTTP-XSCookies > Subject: HTTP-XSCookies-0,000017 won't compile? > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: bparees@redhat.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124727 > > > > installing this module I get: > > > Running Mkbootstrap for XSCookies () > chmod 644 "XSCookies.bs" > "/opt/rh/rh-perl524/root/usr/bin/perl" -MExtUtils::Command::MM -e > 'cp_nonempty' -- XSCooki > es.bs blib/arch/auto/HTTP/XSCookies/XSCookies.bs 644 > "/opt/rh/rh-perl524/root/usr/bin/perl" > "/opt/rh/rh-perl524/root/usr/share/perl5/ExtUtils/x > subpp" -typemap > '/opt/rh/rh-perl524/root/usr/share/perl5/ExtUtils/typemap' baker.xs > ba > ker.xsc > mv baker.xsc baker.c > gcc -c -I. -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe -Wall > -Wp,-D_FORTIFY_SOURCE=2 -fexcept > ions -fstack-protector-strong --param=ssp-buffer-size=4 > -grecord-gcc-switches -m64 -mtune= > generic -fwrapv -fno-strict-aliasing -I/usr/local/include > -D_LARGEFILE_SOURCE -D_FILE_OFFS > ET_BITS=64 -Wall -std=c89 -D_XOPEN_SOURCE=700 -g -DVERSION=\"0.000017\" > -DXS_VERSION=\"0.000017\" -fPIC > "-I/opt/rh/rh-perl524/root/usr/lib64/perl5/CORE" baker.c > baker.xs: In function 'get_encoded_value': > baker.xs:62:9: error: 'for' loop initial declarations are only allowed in > C99 mode > for (int j = 0; j <= top; ++j) { > ^ > baker.xs:62:9: note: use option -std=c99 or -std=gnu99 to compile your code > baker.xs: In function 'search_char': > baker.xs:203:5: error: 'for' loop initial declarations are only allowed in > C99 mode > for (int j = start; j < buf->wpos; ++j) { > ^ > make: *** [baker.o] Error 1 > > -- > Ben Parees | OpenShift >
-- Gonzalo Diethelm gonzalo.diethelm@gmail.com
Subject: Re: [rt.cpan.org #124727] HTTP-XSCookies-0,000017 won't compile?
Date: Fri, 9 Mar 2018 10:54:42 -0500
To: bug-HTTP-XSCookies [...] rt.cpan.org
From: Ben Parees <bparees [...] redhat.com>
Thanks for the quick response! For what it's worth I moved back to the 0.000016 release and that seems to work fine. The platform is a centos based docker image: docker.io/centos/perl-524-centos7 so you can pull that image and poke around test in it (docker run -it docker.io/centos/perl-524-centos7 /bin/sh) $ perl -version This is perl 5, version 24, subversion 0 (v5.24.0) built for x86_64-linux-thread-multi $ gcc --version gcc (GCC) 4.8.5 20150623 (Red Hat 4.8.5-16) On Fri, Mar 9, 2018 at 3:05 AM, Gonzalo Diethelm via RT < bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=124727 > > > Thanks for the report. Do you know which platform this is? > > Weird thing is, I see the "-std=c89" in that compilation line. I compile > with "-std=c89" all of the time, and don't see that error. Maybe a GNU vs > LLVM thing? Frustrating... > > Anyway, I reviewed all the code and removed (I hope) all these new-fangled > C99-isms.We will see what happens on the next release. > > BTW, here is some of my platform information, just FTR. > > $ sw_vers > ProductName: Mac OS X > ProductVersion: 10.12.6 > BuildVersion: 16G1212 > > $ cc --version > Apple LLVM version 9.0.0 (clang-900.0.39.2) > Target: x86_64-apple-darwin16.7.0 > Thread model: posix > InstalledDir: /Library/Developer/CommandLineTools/usr/bin > > $ perl --version > > This is perl 5, version 18, subversion 2 (v5.18.2) built for > darwin-thread-multi-2level > (with 2 registered patches, see perl -V for more detail) > > > On Thu, Mar 8, 2018 at 7:13 PM, Ben Parees via RT < > bug-HTTP-XSCookies@rt.cpan.org> wrote: >
> > Thu Mar 08 13:13:30 2018: Request 124727 was acted upon. > > Transaction: Ticket created by bparees@redhat.com > > Queue: HTTP-XSCookies > > Subject: HTTP-XSCookies-0,000017 won't compile? > > Broken in: (no value) > > Severity: (no value) > > Owner: Nobody > > Requestors: bparees@redhat.com > > Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124727 > > > > > > > installing this module I get: > > > > > > Running Mkbootstrap for XSCookies () > > chmod 644 "XSCookies.bs" > > "/opt/rh/rh-perl524/root/usr/bin/perl" -MExtUtils::Command::MM -e > > 'cp_nonempty' -- XSCooki > > es.bs blib/arch/auto/HTTP/XSCookies/XSCookies.bs 644 > > "/opt/rh/rh-perl524/root/usr/bin/perl" > > "/opt/rh/rh-perl524/root/usr/share/perl5/ExtUtils/x > > subpp" -typemap > > '/opt/rh/rh-perl524/root/usr/share/perl5/ExtUtils/typemap' baker.xs >
> ba
> > ker.xsc > > mv baker.xsc baker.c > > gcc -c -I. -D_REENTRANT -D_GNU_SOURCE -O2 -g -pipe -Wall > > -Wp,-D_FORTIFY_SOURCE=2 -fexcept > > ions -fstack-protector-strong --param=ssp-buffer-size=4 > > -grecord-gcc-switches -m64 -mtune= > > generic -fwrapv -fno-strict-aliasing -I/usr/local/include > > -D_LARGEFILE_SOURCE -D_FILE_OFFS > > ET_BITS=64 -Wall -std=c89 -D_XOPEN_SOURCE=700 -g -DVERSION=\"0.000017\" > > -DXS_VERSION=\"0.000017\" -fPIC > > "-I/opt/rh/rh-perl524/root/usr/lib64/perl5/CORE" baker.c > > baker.xs: In function 'get_encoded_value': > > baker.xs:62:9: error: 'for' loop initial declarations are only allowed in > > C99 mode > > for (int j = 0; j <= top; ++j) { > > ^ > > baker.xs:62:9: note: use option -std=c99 or -std=gnu99 to compile your
> code
> > baker.xs: In function 'search_char': > > baker.xs:203:5: error: 'for' loop initial declarations are only allowed
> in
> > C99 mode > > for (int j = start; j < buf->wpos; ++j) { > > ^ > > make: *** [baker.o] Error 1 > > > > -- > > Ben Parees | OpenShift > >
> > > > -- > Gonzalo Diethelm > gonzalo.diethelm@gmail.com > >
-- Ben Parees | OpenShift
For the record, I saw this same issue on perl 5.26.1 on my Fedora 27 box which should have a very recent compiler toolchain. It seems to be fixed in 0.000018+. Thanks!
Subject: Re: [rt.cpan.org #124727] HTTP-XSCookies-0,000017 won't compile?
Date: Fri, 9 Mar 2018 18:52:25 +0100
To: bug-HTTP-XSCookies [...] rt.cpan.org
From: Gonzalo Diethelm <gonzalo.diethelm [...] gmail.com>
Awesome! For some reason my toolchain just will not warn about for(int j...) snippets, even with -std=c89. But I'm glad I caught them all. On Fri, Mar 9, 2018 at 6:50 PM, Dan Book via RT < bug-HTTP-XSCookies@rt.cpan.org> wrote: Show quoted text
> Queue: HTTP-XSCookies > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124727 > > > For the record, I saw this same issue on perl 5.26.1 on my Fedora 27 box > which should have a very recent compiler toolchain. It seems to be fixed in > 0.000018+. Thanks! >
-- Gonzalo Diethelm gonzalo.diethelm@gmail.com