Skip Menu |

This queue is for tickets about the Net-Ping CPAN distribution.

Report information
The Basics
Id: 124693
Status: resolved
Priority: 0/
Queue: Net-Ping
People
Owner: Nobody in particular
Requestors: DBOOK [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Mar 05 17:15:40 2018 DBOOK [...] cpan.org - Ticket created
Subject: Build dependency on Text::Template for README.md.PL
A build dependency on Text::Template was added in this PR: https://github.com/rurban/net-ping/pull/1 , simply to maintain an installed README.md. Text::Template is not a core module, so this does not seem appropriate for a dual-life module. In addition, the generated README.md seems contradictory as the file will only be generated at install time, after the user has already presumably followed its instructions. It seems like it would make more sense to generate this file in the repository only, leave README.md.PL out of the distribution, and classify Text::Template as a develop phase prerequisite.
  Wed Mar 07 00:42:09 2018 RURBAN [...] cpan.org - Correspondence added
Subject: Re: [rt.cpan.org #124693] Build dependency on Text::Template for README.md.PL
Date: Wed, 7 Mar 2018 06:41:57 +0100
To: bug-Net-Ping [...] rt.cpan.org
From: Reini Urban <rurban [...] cpan.org>
On Mon, Mar 5, 2018 at 11:15 PM, Dan Book via RT <bug-Net-Ping@rt.cpan.org> wrote: Show quoted text
> Mon Mar 05 17:15:40 2018: Request 124693 was acted upon. > Transaction: Ticket created by DBOOK > Queue: Net-Ping > Subject: Build dependency on Text::Template for README.md.PL > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: DBOOK@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124693 > > > > A build dependency on Text::Template was added in this PR: > https://github.com/rurban/net-ping/pull/1 , simply to maintain an > installed README.md. Text::Template is not a core module, so this does not > seem appropriate for a dual-life module. > > In addition, the generated README.md seems contradictory as the file will > only be generated at install time, after the user has already presumably > followed its instructions. It seems like it would make more sense to > generate this file in the repository only, leave README.md.PL out of the > distribution, and classify Text::Template as a develop phase prerequisite. >
Yes, I agree. Forgot about the dual-life nature when accepting this PR. -- Reini
  Wed Mar 07 00:42:10 2018 The RT System itself - Status changed from 'new' to 'open'
  Wed Mar 07 03:52:02 2018 RURBAN [...] cpan.org - Correspondence added
I deleted it, and changed it to using pod2text for the generated README, as everywhere else. Fixed with 2.65 -- Reini Urban
  Wed Mar 07 03:52:04 2018 RURBAN [...] cpan.org - Status changed from 'open' to 'resolved'