Dne St 28.úno.2018 08:47:48, ppisar napsal(a):
Show quoted text> After upgrading fribidi from 0.19.7 to 1.0.1, Text-Bidi tests fail:
The attached patch allows building against fribidi-1.0.
More complex fix like supporting pre-1.0 fribidi or support for new 1.0 features are not addressed.
From 0b3ae800b6da1387cf996b0129a3222cffa21188 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com>
Date: Wed, 28 Feb 2018 15:13:57 +0100
Subject: [PATCH] Adapt to fribidi-1.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Fribidi-1.0 deprecated fribidi_get_par_embedding_levels() in favor of
fribidi_get_par_embedding_levels_ex():
commit 7588059c7d3378baf60d12f3217324781b2f7669
Author: Dov Grobgeld <dov.grobgeld@gmail.com>
Date: Tue Nov 7 21:55:06 2017 +0200
Restored the old API and made it deprecated.
* fribidi_get_par_embedding_levels() is now a deprecated interface to
the new fribidi_get_par_embedding_levels_ex() function with a
NULL pointer for the bracket type.
This causes a test failure:
t/00-version.t ......... ok
Undefined subroutine &Text::Bidi::private::get_par_embedding_levels called at /home/test/fedora/perl-Text-Bidi/Text-Bidi-2.12/blib/lib/Text/Bidi.pm line 128.
# Looks like your test exited with 255 before it could output anything.
t/shape.t ..............
Dubious, test returned 255 (wstat 65280, 0xff00) Failed 3/3 subtests
This patch replaces the call to fribidi_get_par_embedding_levels() with a call
to fribidi_get_par_embedding_levels_ex().
Proper support for new fribidi-1.0 features is left to Text-Bidi author.
CPAN RT#124618
Signed-off-by: Petr PÃsaÅ <ppisar@redhat.com>
---
lib/Text/Bidi.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Text/Bidi.pm b/lib/Text/Bidi.pm
index 07604bd..17100ee 100644
--- a/lib/Text/Bidi.pm
+++ b/lib/Text/Bidi.pm
@@ -332,7 +332,7 @@ sub get_par_embedding_levels {
my $bt = shift;
my $p = shift // $Text::Bidi::private::FRIBIDI_PAR_ON;
my ($lev, $par, $out) =
- Text::Bidi::private::get_par_embedding_levels($$bt, $p);
+ Text::Bidi::private::get_par_embedding_levels_ex($$bt, undef, $p);
my $res = $self->tie_byte($out);
($par, $res)
}
--
2.13.6
