Bug #124598 for Module-Release: Kwalitee test fails

Mon Feb 26 14:18:03 2018 SREZIC [...] cpan.org - Ticket created

Subject:

Kwalitee test fails

On some of my smoker systems t/kwalitee/check_kwalitee.t fails: ... Uncaught exception from user code: You need Module::CPANTS::Analyse and App::CPANTS::Lint to check kwalitee at /home/cpansand/.cpan/build/2018022612/Module-Release-2.124-0/blib/lib/Module/Release/Kwalitee.pm line 40. Capture::Tiny::_capture_tee(1, 0, 0, 0, CODE(0x47d269c0)) called at /usr/perl5.27.9p/lib/site_perl/5.27.9/Test/Output.pm line 801 Test::Output::stdout_from(CODE(0x47d8a720)) called at /usr/perl5.27.9p/lib/site_perl/5.27.9/Test/Output.pm line 207 Test::Output::stdout_like(CODE(0x47d8a720), qr(done)i, "Good kwalitee reports 'Done'") called at t/kwalitee/check_kwalitee.t line 91 # Looks like your test exited with 255 just after 13. t/kwalitee/check_kwalitee.t .. Dubious, test returned 255 (wstat 65280, 0xff00) All 13 subtests passed ...

Mon Feb 26 14:53:48 2018 ether [...] cpan.org - Correspondence added

On 2018-02-26 11:18:03, SREZIC wrote: Show quoted text

> On some of my smoker systems t/kwalitee/check_kwalitee.t fails:

While this test failure is indeed an issue that should be corrected, please don't allow pod, critic, coverage or kwalitee tests to run for normal user installs, as they make the installation fail unnecessarily when newer versions of the tester module introduces errors that you cannot anticipate. Also spelling tests are dependent on what dictionaries are installed locally, and critic tests use all plugins that are installed, neither of which can be predicted in advance. Either move these tests to xt/, or guard them with: plan skip_all => "These tests are for authors only!" unless $ENV{AUTHOR_TESTING} or $ENV{RELEASE_TESTING};

Mon Feb 26 14:53:49 2018 The RT System itself - Status changed from 'new' to 'open'

Mon Feb 26 16:14:32 2018 bdfoy [...] cpan.org - Correspondence added

It looks like I didn't guard against the second module that the kwalitee tests needs. I've fixed that thing and uploaded a new dev version. Thanks,

Mon Feb 26 16:16:23 2018 bdfoy [...] cpan.org - Correspondence added

Kwalitee checking is a feature of this module. This is not an author test.

Mon Feb 26 16:16:46 2018 bdfoy [...] cpan.org - Status changed from 'open' to 'patched'

Mon Feb 26 23:01:42 2018 ether [...] cpan.org - Correspondence added

On 2018-02-26 13:16:23, BDFOY wrote: Show quoted text

> Kwalitee checking is a feature of this module. This is not an author test.

Oops, sorry about that!