Bug #124565 for Plack-Middleware-Auth-JWT: t/decode_args.t started to fail (with newer Crypt::JWT?)

Sat Feb 24 15:37:54 2018 SREZIC [...] cpan.org - Ticket created

CC:	MIK [...] cpan.org
Subject:	t/decode_args.t started to fail (with newer Crypt::JWT?)

I see a new test failure: ... # Failed test 'cannot decode' # at t/decode_args.t line 205. # 'Cannot decode JWT: JWS: invalid header part at /home/cpansand/.cpan/build/2018022418/Plack-Middleware-Auth-JWT-0.901-0/blib/lib/Plack/Middleware/Auth/JWT.pm line 76. # ' # doesn't match '(?^:malformed JSON string)' # Looks like you failed 1 test of 2. # Failed test 'not a JWT' # at t/decode_args.t line 210. # Looks like you failed 1 test of 3. # Failed test 'some bad tokens' # at t/decode_args.t line 213. # Looks like you failed 1 test of 5. t/decode_args.t ...... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests ... Statistical analysis suggests that this happens with the recent Crypt::JWT: **************************************************************** Regression 'mod:Crypt::JWT' **************************************************************** Name Theta StdErr T-stat [0='const'] 1.0000 0.0000 159827017913310400.00 [1='eq_0.020'] -1.0000 0.0000 -58490699415279776.00 R^2= 1.000, N= 112, K= 2 ****************************************************************

Sun Feb 25 14:57:27 2018 domm [...] cpan.org - Correspondence added

RT-Send-CC:

MIK [...] cpan.org

Thanks for the hint, Crypt::JWT did indeed changed it's error handling a tiny bit, which cause t/decode_args.t to fail. I fixed the test, so now all is good! Greetings, domm

Sun Feb 25 14:57:27 2018 The RT System itself - Status changed from 'new' to 'open'

Sun Feb 25 14:57:27 2018 domm [...] cpan.org - Status changed from 'open' to 'resolved'

Sun Feb 25 14:57:28 2018 domm [...] cpan.org - Fixed in 0.901 added

Sun Feb 25 16:19:05 2018 SREZIC [...] cpan.org - Correspondence added

On 2018-02-25 14:57:27, DOMM wrote: Show quoted text

> Thanks for the hint, Crypt::JWT did indeed changed it's error handling > a tiny bit, which cause t/decode_args.t to fail. > > I fixed the test, so now all is good!

Well, it works now if Crypt::JWT 0.020 is installed, but it fails now with older Crypt::JWT versions. Probably the minimum version in PREREQ_PM should be adjusted. # Failed test 'cannot decode' # at t/decode_args.t line 205. # 'Cannot decode JWT: malformed JSON string, neither tag, array, object, number, string or atom, at character offset 0 (before "\x{fffd}\x{fffd}") at /usr/perl5.18.4p/lib/site_perl/5.18.4/Crypt/JWT.pm line 108. # ' # doesn't match '(?^:invalid header part)' # Looks like you failed 1 test of 2. # Failed test 'not a JWT' # at t/decode_args.t line 210. # Looks like you failed 1 test of 3. # Failed test 'some bad tokens' # at t/decode_args.t line 213. # Looks like you failed 1 test of 5. t/decode_args.t ...... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/5 subtests

Sun Feb 25 16:43:01 2018 domm [...] cpan.org - Correspondence added

On Sun Feb 25 16:19:05 2018, SREZIC wrote: Show quoted text

> On 2018-02-25 14:57:27, DOMM wrote:

> > Thanks for the hint, Crypt::JWT did indeed changed it's error > > handling > > a tiny bit, which cause t/decode_args.t to fail. > > > > I fixed the test, so now all is good!

> > Well, it works now if Crypt::JWT 0.020 is installed, but it fails now > with older Crypt::JWT versions. Probably the minimum version in > PREREQ_PM should be adjusted.

argh, yes, of course you're right. I now explicitly require Crypt::JWT 0.020. Thanks again for providing such detailed & helpful feedback via CPAN testers! Greetings, domm