Skip Menu |

This queue is for tickets about the Gtk2-Ex-FormFactory CPAN distribution.

Report information
The Basics
Id: 124546
Status: new
Priority: 0/
Queue: Gtk2-Ex-FormFactory

People
Owner: Nobody in particular
Requestors: bitcardbmw [...] lsmod.de
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.67
Fixed in: (no value)



Subject: timelocal should be called with 4-digit year
man Time::Local says Whenever possible, use an absolute four digit year instead. With a detailed explanation about ambiguity of 2-digit years above that. Please review/test/merge the attached patch (not tested)
Subject: fix.patch
Index: Gtk2-Ex-FormFactory-0.67/lib/Gtk2/Ex/FormFactory/Timestamp.pm =================================================================== --- Gtk2-Ex-FormFactory-0.67.orig/lib/Gtk2/Ex/FormFactory/Timestamp.pm +++ Gtk2-Ex-FormFactory-0.67/lib/Gtk2/Ex/FormFactory/Timestamp.pm @@ -84,7 +84,7 @@ sub get_widget_unix_time { my @d = (0, 0, 0, 1, 0, 0); - $d[5] = $self->get_gtk_year_widget->get_text-1900 + $d[5] = $self->get_gtk_year_widget->get_text if $format =~ /%Y/; $d[4] = $self->get_gtk_mon_widget->get_text-1 if $format =~ /%m/;