Skip Menu |

This queue is for tickets about the Dist-Zilla-Role-TextTemplater CPAN distribution.

Report information
The Basics
Id: 124540
Status: resolved
Priority: 0/
Queue: Dist-Zilla-Role-TextTemplater

People
Owner: VDB [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc: MSCHOUT [...] cpan.org
AdminCc:

Bug Information
Severity: (no value)
Broken in: v0.8.6
Fixed in: v0.8.7



CC: MSCHOUT [...] cpan.org
Subject: Tests fail (with newest Text::Template?)
My smoker systems started to report test failures: ... # Failed test 'messages' # at /home/cpansand/.cpan/build/2018022221/Test-Dist-Zilla-v0.4.4-5DNhqj/blib/lib/Test/Dist/Zilla/Build.pm line 99. # Compared array length of $data # got : array with 29 element(s) # expect : array with 18 element(s) # Failed test 'Build' # at /home/cpansand/.cpan/build/2018022221/Test-Dist-Zilla-v0.4.4-5DNhqj/blib/lib/Test/Dist/Zilla/Build.pm line 103. # | Full log: # | 1: [=TextTemplaterTestPlugin] Useless use of a constant (7) in void context at template line 7, <GEN11> line 32. # | 2: [=TextTemplaterTestPlugin] Useless use of a constant (8) in void context at template line 8, <GEN11> line 32. ... (snip) ... # | 7: [=TextTemplaterTestPlugin] 3: die; # 3 # | 8: [=TextTemplaterTestPlugin] 4: }} 4 # | 9: [=TextTemplaterTestPlugin] ... skipped 3 lines ... # | Exception: Aborting... # Failed test 'Fill_in_file error message + filename has no effect' # at /home/cpansand/.cpan/build/2018022221/Test-Routine-0.025-M0LRr8/blib/lib/Test/Routine/Runner.pm line 101. # Looks like you failed 3 tests of 38. t/text-templater.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/38 subtests Test Summary Report ------------------- t/text-templater.t (Wstat: 768 Tests: 38 Failed: 3) Failed tests: 12-13, 34 Non-zero exit status: 3 Files=2, Tests=39, 6 wallclock secs ( 0.01 usr 0.10 sys + 0.35 cusr 1.39 csys = 1.85 CPU) Result: FAIL Statistical analysis suggests that the problem happens with the latest Text::Template version (though probability is not 100%): **************************************************************** Regression 'mod:Text::Template' **************************************************************** Name Theta StdErr T-stat [0='const'] 0.9877 0.0077 128.69 [1='eq_1.47'] 0.0123 0.0109 1.13 [2='eq_1.50'] -0.9877 0.0125 -79.01 R^2= 0.974, N= 210, K= 3 ****************************************************************
I can confirm that. There are 3 failures I see using Text::Template v1.50. Essentially these all distill down to the fact that you get slightly different warnings/error messages from newer Text::Template. 1: Fill_in_file error message + filename has no effect This test is testing that Text::Template's filename parameter has no effect. This was a long standing bug in Text::Template, which was fixed in v1.48 (see RT #106093). Not sure why Dist::Zilla::Role::TextTemplater is testing for this as it was a bug in Text::Template. Solution is either for the test to be skipped for Text::Template v1.48 and higher, or, rewrite the test to match the output that v1.48+ gives for that test. 2: Long template Due to the fact that Text::Template now has warnings and strict on, the expected warnings/output differ from what Dist::Zilla::Role::TextTemplater expects. (you now get several "Useless use of a constant in void context" warnings. 3: Not so long template Same problem as "Long template" Probably the easiest solution of all would be for Dist::Zilla::Role::TextTemplater to require Text::Template v1.50 and update the expected warnings to match what v1.50 gives. -- Regards, Michael Schout
Thanks for reporting. Looks like the problem fixed in v0.8.6.1-TRIAL. There are few failues there <http://matrix.cpantesters.org/?dist=Dist-Zilla-Role-TextTemplater%20v0.8.6.1-TRIAL>, but they are caused by Text::Template v1.48 (<https://github.com/mschout/perl-text-template/issues/8>).
Should be fixed in v0.8.7.