Skip Menu |

This queue is for tickets about the libnet CPAN distribution.

Report information
The Basics
Id: 124534
Status: resolved
Priority: 0/
Queue: libnet
People
Owner: Nobody in particular
Requestors: perlbugbmw [...] lsmod.de
Cc: jkeenan [...] cpan.org
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 3.12

History Show all quoted text
  Thu Feb 22 09:39:49 2018 jkeenan [...] cpan.org - Ticket created
CC: jkeenan [...] cpan.org
Some items originally reported in the Perl 5 bug tracker: ##### 1. https://rt.perl.org/Ticket/Display.html?id=132896 #132896: timegm should be called with 4-digit year This is a bug report for perl from perlbugbmw@lsmod.de, generated with the help of perlbug 1.39 running under perl 5.18.2. timegm should be called with 4-digit year to avoid ambiguities in Time::Local with 2-digit years please review/test/merge this fix: --- perl-5.26.1.orig/cpan/libnet/lib/Net/NNTP.pm +++ perl-5.26.1/cpan/libnet/lib/Net/NNTP.pm @@ -601 +601 @@ sub date { - ? timegm($6, $5, $4, $3, $2 - 1, $1 - 1900) + ? timegm($6, $5, $4, $3, $2 - 1, $1) ##### ##### 2. https://rt.perl.org/Ticket/Display.html?id=132898 #132898: timegm should be called with 4-digit year This is a bug report for perl from perlbugbmw@lsmod.de, generated with the help of perlbug 1.39 running under perl 5.18.2. timegm should be called with 4-digit year to avoid ambiguities in Time::Local with 2-digit years please review/test/merge this fix: --- perl-5.26.1.orig/cpan/libnet/lib/Net/FTP.pm +++ perl-5.26.1/cpan/libnet/lib/Net/FTP.pm @@ -267 +267 @@ sub mdtm { - ? timegm($8, $7, $6, $5, $4 - 1, $2 eq '19' ? $3 : ($1 - 1900)) + ? timegm($8, $7, $6, $5, $4 - 1, $2 eq '19' ? ($3 + 1900) : $1) #####
  Thu Feb 22 09:40:26 2018 jkeenan [...] cpan.org - Reference to perl ticket #132896 added
  Thu Feb 22 09:40:26 2018 jkeenan [...] cpan.org - Reference to perl ticket #132898 added
  Thu Feb 22 09:41:54 2018 jkeenan [...] cpan.org - Correspondence added
Subject: timegm should be called with 4-digit year
On Thu Feb 22 09:39:49 2018, JKEENAN wrote: Show quoted text
> Some items originally reported in the Perl 5 bug tracker: > > ##### > 1. https://rt.perl.org/Ticket/Display.html?id=132896 > #132896: timegm should be called with 4-digit year > > This is a bug report for perl from perlbugbmw@lsmod.de, > generated with the help of perlbug 1.39 running under perl 5.18.2. > > timegm should be called with 4-digit year > to avoid ambiguities in Time::Local with 2-digit years > > please review/test/merge this fix: > > --- perl-5.26.1.orig/cpan/libnet/lib/Net/NNTP.pm > +++ perl-5.26.1/cpan/libnet/lib/Net/NNTP.pm > @@ -601 +601 @@ sub date { > - ? timegm($6, $5, $4, $3, $2 - 1, $1 - 1900) > + ? timegm($6, $5, $4, $3, $2 - 1, $1) > ##### > > ##### > 2. https://rt.perl.org/Ticket/Display.html?id=132898 > #132898: timegm should be called with 4-digit year > > This is a bug report for perl from perlbugbmw@lsmod.de, > generated with the help of perlbug 1.39 running under perl 5.18.2. > > timegm should be called with 4-digit year > to avoid ambiguities in Time::Local with 2-digit years > > please review/test/merge this fix: > > --- perl-5.26.1.orig/cpan/libnet/lib/Net/FTP.pm > +++ perl-5.26.1/cpan/libnet/lib/Net/FTP.pm > @@ -267 +267 @@ sub mdtm { > - ? timegm($8, $7, $6, $5, $4 - 1, $2 eq '19' ? $3 : ($1 - 1900)) > + ? timegm($8, $7, $6, $5, $4 - 1, $2 eq '19' ? ($3 + 1900) : $1) > #####
  Thu Feb 22 09:41:54 2018 The RT System itself - Status changed from 'new' to 'open'
  Tue Dec 01 08:16:24 2020 shay [...] cpan.org - Correspondence added
Thanks for the patches (and apologies for the slow response). These are now in commit 04a931cd6b and will be released soon in version 3.12.
  Thu Dec 10 08:28:09 2020 shay [...] cpan.org - Correspondence added
Thanks again. This is now fixed in version 3.12, released yesterday.
  Thu Dec 10 08:28:11 2020 shay [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Dec 10 08:28:11 2020 shay [...] cpan.org - Fixed in 3.12 added