Bug #124513 for OLE-Storage_Lite: dates misinterpreted after 2020

Wed Feb 21 07:43:51 2018 bitcardbmw [...] lsmod.de - Ticket created

Subject:

dates misinterpreted after 2020

similar to https://rt.cpan.org/Public/Bug/Display.html?id=124508 after 2020-01-01 tests were failing because year 70 was now interpreted as 2070 # Failed test ' LocalDate2OLE: Thu Jan 1 00:00:00 1970 # at t/01_date_conversion.t line 40. # got: '0040352757CF0D02' # expected: '00803ED5DEB19D01' This patch fixed it for me, but it may change how an input of year=18 is parsed (1918 instead of 2018) Index: OLE-Storage_Lite-0.19/lib/OLE/Storage_Lite.pm =================================================================== --- OLE-Storage_Lite-0.19.orig/lib/OLE/Storage_Lite.pm +++ OLE-Storage_Lite-0.19/lib/OLE/Storage_Lite.pm @@ -1364,7 +1364,9 @@ sub LocalDate2OLE { return "\x00" x 8 unless $localtime; # Convert from localtime (actually gmtime) to seconds. - my $time = timegm( @{$localtime} ); + my @localtimecopy = @{$localtime}; + $localtimecopy[5] += 1900 unless $localtimecopy[5] > 99; + my $time = timegm( @localtimecopy ); # Add the number of seconds between the 1601 and 1970 epochs. $time += 11644473600;

Wed Jan 01 12:50:55 2020 SREZIC [...] cpan.org - Correspondence added

On 2018-02-21 07:43:51, bmwiedemann wrote: Show quoted text

> similar to https://rt.cpan.org/Public/Bug/Display.html?id=124508 > > after 2020-01-01 tests were failing because year 70 was now > interpreted as 2070 > > # Failed test ' LocalDate2OLE: Thu Jan 1 00:00:00 1970 > # at t/01_date_conversion.t line 40. > # got: '0040352757CF0D02' > # expected: '00803ED5DEB19D01' > > This patch fixed it for me, but it may change how an input of year=18 > is parsed (1918 instead of 2018) > > Index: OLE-Storage_Lite-0.19/lib/OLE/Storage_Lite.pm > =================================================================== > --- OLE-Storage_Lite-0.19.orig/lib/OLE/Storage_Lite.pm > +++ OLE-Storage_Lite-0.19/lib/OLE/Storage_Lite.pm > @@ -1364,7 +1364,9 @@ sub LocalDate2OLE { > return "\x00" x 8 unless $localtime; > > # Convert from localtime (actually gmtime) to seconds. > - my $time = timegm( @{$localtime} ); > + my @localtimecopy = @{$localtime}; > + $localtimecopy[5] += 1900 unless $localtimecopy[5] > 99; > + my $time = timegm( @localtimecopy ); > > # Add the number of seconds between the 1601 and 1970 epochs. > $time += 11644473600;

So, now it's 2020, and the test suite is really failing.

Wed Jan 01 12:50:56 2020 The RT System itself - Status changed from 'new' to 'open'

Thu Jan 02 04:52:45 2020 SREZIC [...] cpan.org - Correspondence added

On 2020-01-01 12:50:55, SREZIC wrote: Show quoted text

> On 2018-02-21 07:43:51, bmwiedemann wrote:

> > similar to https://rt.cpan.org/Public/Bug/Display.html?id=124508 > > > > after 2020-01-01 tests were failing because year 70 was now > > interpreted as 2070 > > > > # Failed test ' LocalDate2OLE: Thu Jan 1 00:00:00 1970 > > # at t/01_date_conversion.t line 40. > > # got: '0040352757CF0D02' > > # expected: '00803ED5DEB19D01' > > > > This patch fixed it for me, but it may change how an input of year=18 > > is parsed (1918 instead of 2018) > > > > Index: OLE-Storage_Lite-0.19/lib/OLE/Storage_Lite.pm > > =================================================================== > > --- OLE-Storage_Lite-0.19.orig/lib/OLE/Storage_Lite.pm > > +++ OLE-Storage_Lite-0.19/lib/OLE/Storage_Lite.pm > > @@ -1364,7 +1364,9 @@ sub LocalDate2OLE { > > return "\x00" x 8 unless $localtime; > > > > # Convert from localtime (actually gmtime) to seconds. > > - my $time = timegm( @{$localtime} ); > > + my @localtimecopy = @{$localtime}; > > + $localtimecopy[5] += 1900 unless $localtimecopy[5] > 99; > > + my $time = timegm( @localtimecopy ); > > > > # Add the number of seconds between the 1601 and 1970 epochs. > > $time += 11644473600;

> > So, now it's 2020, and the test suite is really failing.

CPAN.pm users may use the following distroprefs file for automatically applying the proposed patch: https://github.com/eserte/srezic-cpan-distroprefs/blob/master/OLE-Storage_Lite.yml

Thu Jan 02 04:53:03 2020 SREZIC [...] cpan.org - Severity Important added

Thu Jan 02 08:41:30 2020 jmcnamara [...] cpan.org - Correspondence added

Thanks. Fixed in version 0.20 just uploaded to CPAN.

Thu Jan 02 08:41:31 2020 jmcnamara [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Jan 02 08:41:31 2020 jmcnamara [...] cpan.org - Taken