Skip Menu |

This queue is for tickets about the POE CPAN distribution.

Report information
The Basics
Id: 124496
Status: new
Priority: 0/
Queue: POE

People
Owner: Nobody in particular
Requestors: limeytexan [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: POE-1.367 failed t/10_units/01_pod/04_pod_linkcheck.t
Date: Tue, 20 Feb 2018 11:50:43 +0000
To: bug-POE [...] rt.cpan.org
From: Michael Brantley <limeytexan [...] gmail.com>
The t/10_units/01_pod/04_pod_linkcheck.t test failed on NixOS with Perl 5.24.3 and RELEASE_TESTING=1: # Failed test 'LinkCheck test for blib/lib/POE/Filter/HTTPD.pm' # at /nix/store/lisn3xvpmgni1db6ksrlp0m9sp7yw0hi-perl-Test-Pod-LinkCheck-0.008/lib/perl5/site_perl/5.24.3/Test/Pod/LinkCheck.pm line 284. # Erroneous links: # * blib/lib/POE/Filter/HTTPD.pm:624:22 - Unknown link type(pod) to(utf8::is_utf8) - module doesn't exist in CPAN # * blib/lib/POE/Filter/HTTPD.pm:627:16 - Unknown link type(pod) to(utf8::downgrade) - module doesn't exist in CPAN # * blib/lib/POE/Filter/HTTPD.pm:654:38 - Unknown link type(pod) to() section(Streaming request) - section doesn't exist! # * blib/lib/POE/Filter/HTTPD.pm:655:19 - Unknown link type(pod) to() section(MaxContent) - section doesn't exist! # Looks like you failed 1 test of 47. t/10_units/01_pod/04_pod_linkcheck.t ............... ... Test Summary Report ------------------- t/10_units/01_pod/04_pod_linkcheck.t (Wstat: 256 Tests: 47 Failed: 1) Failed test: 39 Non-zero exit status: 1 These can be addressed by updating the Pod in lib/POE/Filter/HTTPD.pm with the following patch: diff --git a/lib/POE/Filter/HTTPD.pm b/lib/POE/Filter/HTTPD.pm index 9d4898e3..517be691 100644 --- a/lib/POE/Filter/HTTPD.pm +++ b/lib/POE/Filter/HTTPD.pm @@ -621,10 +621,10 @@ how to use these objects. HTTP headers are not allowed to have UTF-8 characters; they must be ISO-8859-1. POE::Filter::HTTPD will convert all UTF-8 into the MIME encoded -equivalent. It uses L<utf8::is_utf8> for detection-8 and +equivalent. It uses C<utf8::is_utf8> for detection-8 and L<Email::MIME::RFC2047::Encoder> for convertion. If L<utf8> is not installed, no conversion happens. If L<Email::MIME::RFC2047::Encoder> is -not installed, L<utf8::downgrade> is used instead. In this last case, you will +not installed, C<utf8::downgrade> is used instead. In this last case, you will see a warning if you try to send UTF-8 headers. @@ -651,8 +651,8 @@ streaming mode this filter will return either an HTTP::Request object or a block of content. The HTTP::Request object's content will return empty. The blocks of content will be parts of the request's body, up to Content-Length in size. You distinguish between request objects and content -blocks using C<Scalar::Util/bless> (See L</Streaming request> below). This -option supersedes L</MaxContent>. +blocks using C<Scalar::Util/bless> (See L</Streaming Request> below). This +option supersedes C<MaxContent>. =head1 CAVEATS