Bug #124459 for Catalyst-Runtime: Tests assume too much about Time::HiRes internals

Sun Feb 18 07:39:29 2018 RANDIR [...] cpan.org - Ticket created

Subject:

Tests assume too much about Time::HiRes internals

Starting with Time::HiRes version 1.9754, test t/unit_stats.t from this module started to fail. This is because it redefines gettimeofday() but not tv_interval() and assumes that the latter will call the former. But this is no longer the case due to optimizations in Time::HiRes. The original discussion can be found here https://rt.cpan.org/Ticket/Display.html?id=124450.

Mon Feb 19 01:35:42 2018 SREZIC [...] cpan.org - Reference to ticket #124450 added

Sat Mar 03 11:08:38 2018 SREZIC [...] cpan.org - Correspondence added

On 2018-02-18 07:39:29, RANDIR wrote: Show quoted text

> Starting with Time::HiRes version 1.9754, test t/unit_stats.t from > this module started to fail. This is because it redefines > gettimeofday() but not tv_interval() and assumes that the latter will > call the former. But this is no longer the case due to optimizations > in Time::HiRes. > > The original discussion can be found here > https://rt.cpan.org/Ticket/Display.html?id=124450.

A possible patch: http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/Catalyst-Runtime-5.90117-RT124459.patch CPAN.pm users may use the following distroprefs file for automatic patching: https://github.com/eserte/srezic-cpan-distroprefs/blob/master/Catalyst-Runtime.yml

Sat Mar 03 11:08:40 2018 The RT System itself - Status changed from 'new' to 'open'

Thu Mar 22 09:26:00 2018 jkeenan [...] cpan.org - Correspondence added

On Sat Mar 03 11:08:38 2018, SREZIC wrote: Show quoted text

> On 2018-02-18 07:39:29, RANDIR wrote:

> > Starting with Time::HiRes version 1.9754, test t/unit_stats.t from > > this module started to fail. This is because it redefines > > gettimeofday() but not tv_interval() and assumes that the latter will > > call the former. But this is no longer the case due to optimizations > > in Time::HiRes. > > > > The original discussion can be found here > > https://rt.cpan.org/Ticket/Display.html?id=124450.

> > A possible patch: > http://cpan.cpantesters.org/authors/id/S/SR/SREZIC/patches/Catalyst- > Runtime-5.90117-RT124459.patch >

I concur that that patch fixes t/unit_stats.t. Since the version of Time-HiRes in question has been merged into Perl 5 blead, the patch should be applied before perl-5.28.0 is release in May. Show quoted text

> CPAN.pm users may use the following distroprefs file for automatic > patching: > https://github.com/eserte/srezic-cpan- > distroprefs/blob/master/Catalyst-Runtime.yml

Tue Mar 27 22:12:25 2018 haarg [...] haarg.org - Correspondence added

Fixed in git.

Tue Mar 27 22:12:28 2018 haarg [...] haarg.org - Status changed from 'open' to 'patched'

Sun Oct 21 17:12:24 2018 haarg [...] haarg.org - Status changed from 'patched' to 'resolved'

Sun Oct 21 17:12:25 2018 haarg [...] haarg.org - Fixed in 5.90118 added