Skip Menu |

This queue is for tickets about the Fsdb CPAN distribution.

Report information
The Basics
Id: 124452
Status: open
Priority: 0/
Queue: Fsdb
People
Owner: Nobody in particular
Requestors: zefram [...] fysh.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri Feb 16 13:50:41 2018 zefram [...] fysh.org - Ticket created
Subject: missing import of croak()
Date: Fri, 16 Feb 2018 18:49:59 +0000
To: bug-Fsdb [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
The Fsdb::Filter::dbcolstats module includes what's meant to be a call to croak(), but doesn't import it, so that code doesn't work. The module should import croak() from the Carp module. Incidentally, the way the reference to croak() compiles in the absence of the importation makes the concatenations (meant to construct the argument to croak()) the top-level operators in that expression. This ought to yield a warning about concatenation in void context, but prior to Perl 5.27.7 there was a core bug preventing that from warning. Starting in Perl 5.27.7 that bug has been fixed, and a warning is now generated when compiling that module, which causes Fsdb to fail its test suite. -zefram
  Tue Feb 20 01:54:04 2018 johnh [...] isi.edu - Correspondence added
Subject: Re: [rt.cpan.org #124452] missing import of croak()
Date: Mon, 19 Feb 2018 22:52:38 -0800
To: bug-Fsdb [...] rt.cpan.org
From: John Heidemann <johnh [...] isi.edu>
On Fri, 16 Feb 2018 13:50:42 -0500, Zefram via RT wrote: Show quoted text
>Fri Feb 16 13:50:41 2018: Request 124452 was acted upon. >Transaction: Ticket created by zefram@fysh.org > Queue: Fsdb > Subject: missing import of croak() > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: zefram@fysh.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=124452 > > > >The Fsdb::Filter::dbcolstats module includes what's meant to be a call >to croak(), but doesn't import it, so that code doesn't work. The module >should import croak() from the Carp module. > >Incidentally, the way the reference to croak() compiles in the absence of >the importation makes the concatenations (meant to construct the argument >to croak()) the top-level operators in that expression. This ought to >yield a warning about concatenation in void context, but prior to Perl >5.27.7 there was a core bug preventing that from warning. Starting in >Perl 5.27.7 that bug has been fixed, and a warning is now generated when >compiling that module, which causes Fsdb to fail its test suite. > >-zefram
Thanks for the specific bug report. Fixed in Fsdb-2.65. -John Heidemann
  Tue Feb 20 01:54:04 2018 The RT System itself - Status changed from 'new' to 'open'