Skip Menu |

This queue is for tickets about the Google-Ads-AdWords-Client CPAN distribution.

Report information
The Basics
Id: 124416
Status: open
Priority: 0/
Queue: Google-Ads-AdWords-Client
People
Owner: SUNDQUIST [...] cpan.org
Requestors: jraspass [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 5.1.0

History Show all quoted text
  Tue Feb 13 12:49:12 2018 jraspass [...] gmail.com - Ticket created
Subject: Remove XML::Simple
XML::Simple is only used for one feature in one file, __extract_xml_error in Google::Ads::AdWords::Utilities::BatchJobHandler - https://metacpan.org/source/SUNDQUIST/Google-Ads-AdWords-Client-5.1.0/lib/Google/Ads/AdWords/Utilities/BatchJobHandler.pm#L420 Given we already depend on the very decent XML::LibXML replacing XML::Simple with a new dep of https://metacpan.org/pod/XML::LibXML::Simple should provide the exact same functionality with far less crazy. There seems to be a general movement to remove XML::Simple from CPAN modules, this is the AWS bug for instance - https://github.com/pplu/aws-sdk-perl/issues/66 My motivation is that at work this is the only module we use that still brings in XML::Simple. I'm happy to actually write a patch and run the tests but I thought I'd submit a bug first to gauge interest.
  Thu Feb 15 09:28:42 2018 SUNDQUIST [...] cpan.org - Correspondence added
Hello, Please see my reply on https://github.com/googleads/googleads-perl-lib/issues/24. I'll continue the conversation over there. Thanks for taking the time to go over onto GitHub to raise the question. Best, Nadine Sundquist, AdWords API Team On Tue Feb 13 12:49:12 2018, RAZ wrote: Show quoted text
> XML::Simple is only used for one feature in one file, > __extract_xml_error in > Google::Ads::AdWords::Utilities::BatchJobHandler - > https://metacpan.org/source/SUNDQUIST/Google-Ads-AdWords-Client- > 5.1.0/lib/Google/Ads/AdWords/Utilities/BatchJobHandler.pm#L420 > > Given we already depend on the very decent XML::LibXML replacing > XML::Simple with a new dep of > https://metacpan.org/pod/XML::LibXML::Simple should provide the exact > same functionality with far less crazy. > > There seems to be a general movement to remove XML::Simple from CPAN > modules, this is the AWS bug for instance - > https://github.com/pplu/aws-sdk-perl/issues/66 > > My motivation is that at work this is the only module we use that > still brings in XML::Simple. > > I'm happy to actually write a patch and run the tests but I thought > I'd submit a bug first to gauge interest.
  Thu Feb 15 09:28:43 2018 The RT System itself - Status changed from 'new' to 'open'
  Thu Feb 15 09:28:43 2018 SUNDQUIST [...] cpan.org - Taken
  Thu Feb 15 09:28:44 2018 SUNDQUIST [...] cpan.org - Fixed in 5.1.0 added