Skip Menu |

This queue is for tickets about the HTML-WikiConverter CPAN distribution.

Report information
The Basics
Id: 12433
Status: resolved
Worked: 20 min
Priority: 0/
Queue: HTML-WikiConverter
People
Owner: diberri [...] cpan.org
Requestors: bugzilla [...] blorf.net
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 0.21
Fixed in: (no value)

History Show all quoted text
  Wed Apr 27 14:26:46 2005 Guest - Ticket created
Subject: Missing attributes for TR tag in MediaWiki
I noticed that some TR tags that had VALIGN="top" attributes were not being preserved by the MediaWiki table conversion. I checked the w3.org docs to see that both ALIGN and VALIGN are listed as official attributes, so I just added them to the list of attributes in the _tr_start() subroutine in the MediaWiki.pm file and it fixed the problem. (Note that I would have filed this bug against 0.22 if it had been an option in the bug-report form as this bug appears to still be present in 0.22.)
  Wed Apr 27 17:14:43 2005 diberri [...] cpan.org - Taken
  Wed Apr 27 17:14:47 2005 diberri [...] cpan.org - Status changed from 'new' to 'open'
  Wed Apr 27 19:32:32 2005 diberri [...] cpan.org - Correspondence added 20 min
Show quoted text
> I noticed that some TR tags that had VALIGN="top" attributes were not > being preserved by the MediaWiki table conversion. I checked the > w3.org docs to see that both ALIGN and VALIGN are listed as > official attributes, so I just added them to the list of attributes > in the _tr_start() subroutine in the MediaWiki.pm file and it fixed > the problem.
Thanks for catching that. I had originally just included the whitelisted HTML *elements* from MediaWiki's Sanitizer.php module [1], but for some reason overlooked the whitelisted attributes. I've checked in a patch for 0.23 so HTML::WikiConverter::MediaWiki includes both HTML elements and attributes from the Sanitizer.php whitelists. Show quoted text
> (Note that I would have filed this bug against 0.22 if it had been an > option in the bug-report form as this bug appears to still be > present in 0.22.)
Indeed. It appears rt.cpan.org lags behind the rest of CPAN for at least a couple days and doesn't yet know about the 0.22 release. -- David Iberri [1] http://cvs.sourceforge.net/viewcvs.py/wikipedia/phase3/includes/Sanitizer.php?rev=1.8&view=auto
  Wed Apr 27 19:32:33 2005 diberri [...] cpan.org - Status changed from 'open' to 'resolved'