Bug #124318 for PerlX-AsyncAwait: Can't "goto" into a binary or list expression

Sun Feb 04 11:37:14 2018 SREZIC [...] cpan.org - Ticket created

Subject:

Can't "goto" into a binary or list expression

t/generator_runtime.t started to fail with perl 5.27.8: $ perl5.27.8 -Mblib t/generator_runtime.t Can't "goto" into a binary or list expression at t/generator_runtime.t line 12. This matches a new error described in perl5.27.8's perldelta: New Diagnostics New Errors * Can't "goto" into a binary or list expression Use of "goto" to jump into the parameter of a binary or list operator has been prohibited, to prevent crashes and stack corruption. [perl #130936]

Sun Feb 04 20:20:23 2018 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Sun Feb 04 11:37:14 2018, SREZIC wrote: Show quoted text

> t/generator_runtime.t started to fail with perl 5.27.8: > > $ perl5.27.8 -Mblib t/generator_runtime.t > Can't "goto" into a binary or list expression at t/generator_runtime.t > line 12. > > This matches a new error described in perl5.27.8's perldelta: > > New Diagnostics > New Errors > * Can't "goto" into a binary or list expression > > Use of "goto" to jump into the parameter of a binary or list > operator has been prohibited, to prevent crashes and stack > corruption. [perl #130936]

This may warrant reprieving some cases of goto-into-expression. I don’t see offhand why this module is triggering the error. I will look into it.

Sun Feb 04 20:20:23 2018 The RT System itself - Status changed from 'new' to 'open'

Mon Feb 05 11:27:09 2018 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Sun Feb 04 20:20:23 2018, SPROUT wrote: Show quoted text

> On Sun Feb 04 11:37:14 2018, SREZIC wrote:

> > t/generator_runtime.t started to fail with perl 5.27.8: > > > > $ perl5.27.8 -Mblib t/generator_runtime.t > > Can't "goto" into a binary or list expression at > > t/generator_runtime.t > > line 12. > > > > This matches a new error described in perl5.27.8's perldelta: > > > > New Diagnostics > > New Errors > > * Can't "goto" into a binary or list expression > > > > Use of "goto" to jump into the parameter of a binary or list > > operator has been prohibited, to prevent crashes and stack > > corruption. [perl #130936]

> > This may warrant reprieving some cases of goto-into-expression. I > don’t see offhand why this module is triggering the error. I will > look into it.

This may be the same bug as perl #132799, which I have just fixed in blead commit 88980524f2d09. I have not tested it yet.

Mon Feb 05 11:35:03 2018 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Mon Feb 05 11:27:09 2018, SPROUT wrote: Show quoted text

> On Sun Feb 04 20:20:23 2018, SPROUT wrote:

> > On Sun Feb 04 11:37:14 2018, SREZIC wrote:

> > > t/generator_runtime.t started to fail with perl 5.27.8: > > > > > > $ perl5.27.8 -Mblib t/generator_runtime.t > > > Can't "goto" into a binary or list expression at > > > t/generator_runtime.t > > > line 12. > > > > > > This matches a new error described in perl5.27.8's perldelta: > > > > > > New Diagnostics > > > New Errors > > > * Can't "goto" into a binary or list expression > > > > > > Use of "goto" to jump into the parameter of a binary or list > > > operator has been prohibited, to prevent crashes and stack > > > corruption. [perl #130936]

> > > > This may warrant reprieving some cases of goto-into-expression. I > > don’t see offhand why this module is triggering the error. I will > > look into it.

> > This may be the same bug as perl #132799, which I have just fixed in > blead commit 88980524f2d09. I have not tested it yet.

No, it is still broken. This does still look to me like a perl bug.

Mon Feb 05 13:51:10 2018 SREZIC [...] cpan.org - Correspondence added

RT-Send-CC:

sprout [...] cpan.org

On 2018-02-05 11:35:03, SPROUT wrote: Show quoted text

> On Mon Feb 05 11:27:09 2018, SPROUT wrote:

> > On Sun Feb 04 20:20:23 2018, SPROUT wrote:

> > > On Sun Feb 04 11:37:14 2018, SREZIC wrote:

> > > > t/generator_runtime.t started to fail with perl 5.27.8: > > > > > > > > $ perl5.27.8 -Mblib t/generator_runtime.t > > > > Can't "goto" into a binary or list expression at > > > > t/generator_runtime.t > > > > line 12. > > > > > > > > This matches a new error described in perl5.27.8's perldelta: > > > > > > > > New Diagnostics > > > > New Errors > > > > * Can't "goto" into a binary or list expression > > > > > > > > Use of "goto" to jump into the parameter of a binary or list > > > > operator has been prohibited, to prevent crashes and stack > > > > corruption. [perl #130936]

> > > > > > This may warrant reprieving some cases of goto-into-expression. I > > > don’t see offhand why this module is triggering the error. I will > > > look into it.

> > > > This may be the same bug as perl #132799, which I have just fixed in > > blead commit 88980524f2d09. I have not tested it yet.

> > No, it is still broken. This does still look to me like a perl bug.

Should I open a BBC?

Sun Feb 11 14:36:25 2018 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Mon Feb 05 13:51:10 2018, SREZIC wrote: Show quoted text

> On 2018-02-05 11:35:03, SPROUT wrote:

> > On Mon Feb 05 11:27:09 2018, SPROUT wrote:

> > > On Sun Feb 04 20:20:23 2018, SPROUT wrote:

> > > > On Sun Feb 04 11:37:14 2018, SREZIC wrote:

> > > > > t/generator_runtime.t started to fail with perl 5.27.8: > > > > > > > > > > $ perl5.27.8 -Mblib t/generator_runtime.t > > > > > Can't "goto" into a binary or list expression at > > > > > t/generator_runtime.t > > > > > line 12. > > > > > > > > > > This matches a new error described in perl5.27.8's perldelta: > > > > > > > > > > New Diagnostics > > > > > New Errors > > > > > * Can't "goto" into a binary or list expression > > > > > > > > > > Use of "goto" to jump into the parameter of a binary or list > > > > > operator has been prohibited, to prevent crashes and stack > > > > > corruption. [perl #130936]

> > > > > > > > This may warrant reprieving some cases of goto-into-expression. I > > > > don’t see offhand why this module is triggering the error. I will > > > > look into it.

> > > > > > This may be the same bug as perl #132799, which I have just fixed in > > > blead commit 88980524f2d09. I have not tested it yet.

> > > > No, it is still broken. This does still look to me like a perl bug.

> > Should I open a BBC?

Please do. BTW, I have reduced this to: goto __GEN_2; my $sent = do { __GEN_2: }; which seems perfectly reasonable code to me.

Sun Feb 11 15:35:45 2018 SREZIC [...] cpan.org - Dependency on perl ticket #132854 added

Sat Feb 24 13:17:15 2018 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Sun Feb 11 14:36:25 2018, SPROUT wrote: Show quoted text

> On Mon Feb 05 13:51:10 2018, SREZIC wrote:

> > On 2018-02-05 11:35:03, SPROUT wrote:

> > > On Mon Feb 05 11:27:09 2018, SPROUT wrote:

> > > > On Sun Feb 04 20:20:23 2018, SPROUT wrote:

> > > > > On Sun Feb 04 11:37:14 2018, SREZIC wrote:

> > > > > > t/generator_runtime.t started to fail with perl 5.27.8: > > > > > > > > > > > > $ perl5.27.8 -Mblib t/generator_runtime.t > > > > > > Can't "goto" into a binary or list expression at > > > > > > t/generator_runtime.t > > > > > > line 12. > > > > > > > > > > > > This matches a new error described in perl5.27.8's perldelta: > > > > > > > > > > > > New Diagnostics > > > > > > New Errors > > > > > > * Can't "goto" into a binary or list expression > > > > > > > > > > > > Use of "goto" to jump into the parameter of a binary or list > > > > > > operator has been prohibited, to prevent crashes and stack > > > > > > corruption. [perl #130936]

> > > > > > > > > > This may warrant reprieving some cases of goto-into-expression. I > > > > > don’t see offhand why this module is triggering the error. I will > > > > > look into it.

> > > > > > > > This may be the same bug as perl #132799, which I have just fixed in > > > > blead commit 88980524f2d09. I have not tested it yet.

> > > > > > No, it is still broken. This does still look to me like a perl bug.

> > > > Should I open a BBC?

> > Please do. BTW, I have reduced this to: > > goto __GEN_2; > my $sent = do { > __GEN_2: > }; > > which seems perfectly reasonable code to me.

Could you try testing the module as of blead commit b4dcd72d7c1fd970?

Sat Feb 24 16:25:27 2018 SREZIC [...] cpan.org - Correspondence added

RT-Send-CC:

sprout [...] cpan.org

On 2018-02-24 13:17:15, SPROUT wrote: Show quoted text

> On Sun Feb 11 14:36:25 2018, SPROUT wrote:

> > On Mon Feb 05 13:51:10 2018, SREZIC wrote:

> > > On 2018-02-05 11:35:03, SPROUT wrote:

> > > > On Mon Feb 05 11:27:09 2018, SPROUT wrote:

> > > > > On Sun Feb 04 20:20:23 2018, SPROUT wrote:

> > > > > > On Sun Feb 04 11:37:14 2018, SREZIC wrote:

> > > > > > > t/generator_runtime.t started to fail with perl 5.27.8: > > > > > > > > > > > > > > $ perl5.27.8 -Mblib t/generator_runtime.t > > > > > > > Can't "goto" into a binary or list expression at > > > > > > > t/generator_runtime.t > > > > > > > line 12. > > > > > > > > > > > > > > This matches a new error described in perl5.27.8's perldelta: > > > > > > > > > > > > > > New Diagnostics > > > > > > > New Errors > > > > > > > * Can't "goto" into a binary or list expression > > > > > > > > > > > > > > Use of "goto" to jump into the parameter of a binary or list > > > > > > > operator has been prohibited, to prevent crashes and stack > > > > > > > corruption. [perl #130936]

> > > > > > > > > > > > This may warrant reprieving some cases of goto-into-expression. I > > > > > > don’t see offhand why this module is triggering the error. I will > > > > > > look into it.

> > > > > > > > > > This may be the same bug as perl #132799, which I have just fixed in > > > > > blead commit 88980524f2d09. I have not tested it yet.

> > > > > > > > No, it is still broken. This does still look to me like a perl bug.

> > > > > > Should I open a BBC?

> > > > Please do. BTW, I have reduced this to: > > > > goto __GEN_2; > > my $sent = do { > > __GEN_2: > > }; > > > > which seems perfectly reasonable code to me.

> > Could you try testing the module as of blead commit b4dcd72d7c1fd970?

I tried v5.27.8-374-gc4a2ac4 (which is a later commit) and the module tested fine.

Sun Feb 25 14:33:26 2018 $_ = 'spro^^*%*^6ut# [...] &$%*c>#!^!#&!pan.org'; y/a-z.@//cd; print - Correspondence added

On Sat Feb 24 16:25:27 2018, SREZIC wrote: Show quoted text

> I tried v5.27.8-374-gc4a2ac4 (which is a later commit) and the module > tested fine.

Thank you. This ticket can be resolved.

Sun Feb 25 14:37:56 2018 SREZIC [...] cpan.org - Status changed from 'open' to 'resolved'