Bug #124262 for Data-Password-zxcvbn: Minor differences from the JS implementation

Mon Jan 29 13:56:13 2018 OSCHWALD [...] cpan.org - Ticket created

Subject:

Minor differences from the JS implementation

First, thanks so much for providing this library. The code looks to be of high quality and it seems to be a faithful port of the algorithm. While evaluating this library using a list of leaked passwords, I found two minor variations in score: 1. "pool" is 0 in the JS implementation and 1 in the Perl implementation. 2. "quatrain" is 1 in the JS implementation and 2 in the Perl implementation. I didn't dig into these at all. It is possible it is an unavoidable rounding difference or something along those lines, but I thought it was worth raising here. Thank you! Greg

Mon Jan 29 14:05:13 2018 OSCHWALD [...] cpan.org - Correspondence added

Show quoted text

> While evaluating this library using a list of leaked passwords, I > found two minor variations in score:

Here is a third that I missed the first time around. I mostly raise it as, unlike the other two, the Perl score is lower: 3. "relations" is 1 in the JS implementation and 0 in the Perl implementation.

Mon May 13 08:30:07 2019 DAKKAR [...] cpan.org - Correspondence added

I suspect the issue is that the dictionary packaged with the JS implementation is malformed, so that some words are not parsed correctly. To compare my implementation with the JS one I had to patch my dictionary ☹

Mon May 13 08:30:07 2019 The RT System itself - Status changed from 'new' to 'open'

Mon May 13 08:30:08 2019 DAKKAR [...] cpan.org - Status changed from 'open' to 'rejected'