Bug #124166 for File-Copy-Recursive: tests fail in 0.40

Sun Jan 21 15:58:56 2018 ether [...] cpan.org - Ticket created

Subject:

tests fail in 0.40

This is on OSX, perl 5.27.6: : [ether@jaeger git/File-Copy-Recursive]$; prove -lr t t/00.load.t ............... ok t/03.github-issue-5.t ..... ok t/04.readonly-dir.t ....... ok ===( 12;0 3/? 1/33 )============================================# File [/tmp/d5dThAWGKr/what/what] mode is not 0751! # Failed test 'DirPerms in pathmk() effects initial new dir' # at t/01.legacy.t line 208. # File [/tmp/d5dThAWGKr/what/what/what] mode is not 0751! # Failed test 'DirPerms in pathmk() effects subsequent new dir' # at t/01.legacy.t line 209. # File [/tmp/d5dThAWGKr/new] mode is not 0751! # Failed test 'DirPerms in dircopy() effects dir (new)' # at t/01.legacy.t line 215. # File [/tmp/d5dThAWGKr/new/foo] mode is not 0751! # Failed test 'DirPerms in dircopy() effects dir (new/foo)' # at t/01.legacy.t line 215. # File [/tmp/d5dThAWGKr/new/foo/bar] mode is not 0751! # Failed test 'DirPerms in dircopy() effects dir (new/foo/bar)' # at t/01.legacy.t line 215. # File [/tmp/d5dThAWGKr/new/foo/baz] mode is not 0751! # Failed test 'DirPerms in dircopy() effects dir (new/foo/baz)' # at t/01.legacy.t line 215. # File [/tmp/d5dThAWGKr/new/foo/bar/wop] mode is not 0751! # Failed test 'DirPerms in dircopy() effects dir (new/foo/bar/wop)' # at t/01.legacy.t line 215. # Looks like you failed 7 tests of 109. t/01.legacy.t ............. Dubious, test returned 7 (wstat 1792, 0x700) Failed 7/109 subtests t/02.legacy-symtogsafe.t .. ok Test Summary Report ------------------- t/01.legacy.t (Wstat: 1792 Tests: 109 Failed: 7) Failed tests: 67-73 Non-zero exit status: 7 Files=5, Tests=150, 2 wallclock secs ( 0.05 usr 0.02 sys + 1.46 cusr 0.79 csys = 2.32 CPU) Result: FAIL

Sun Jan 21 16:39:34 2018 dmuey [...] cpan.org - Correspondence added

Odd, works for me w/ 5.27.8, I wonder what the difference is between our OSXs. Mine is 10.11.6 all out of the box as far as low level stuff like disk mounting/partitions go. • [dmuey@multivac:p5-File-Copy-Recursive] (master)$ perl -v This is perl 5, version 27, subversion 8 (v5.27.8) built for darwin-2level (with 1 registered patch, see perl -V for more detail) Copyright 1987-2018, Larry Wall Perl may be copied only under the terms of either the Artistic License or the GNU General Public License, which may be found in the Perl 5 source kit. Complete documentation for Perl, including FAQ lists, should be found on this system using "man perl" or "perldoc perl". If you have access to the Internet, point your browser at http://www.perl.org/, the Perl Home Page. • [dmuey@multivac:p5-File-Copy-Recursive] (master)$ prove -lr t t/00.load.t ............... ok t/01.legacy.t ............. ok t/02.legacy-symtogsafe.t .. ok t/03.github-issue-5.t ..... ok t/04.readonly-dir.t ....... ok All tests successful. Files=5, Tests=150, 1 wallclock secs ( 0.04 usr 0.01 sys + 0.56 cusr 0.53 csys = 1.14 CPU) Result: PASS • [dmuey@multivac:p5-File-Copy-Recursive] (master)$

Sun Jan 21 16:39:34 2018 The RT System itself - Status changed from 'new' to 'open'

Sun Jan 21 17:31:07 2018 ether [...] cpan.org - Correspondence added

On 2018-01-21 13:39:34, DMUEY wrote: Show quoted text

> Odd, works for me w/ 5.27.8, I wonder what the difference is between > our OSXs. > > Mine is 10.11.6 all out of the box as far as low level stuff like disk > mounting/partitions go.

: [ether@jaeger git/File-Copy-Recursive]$; sw_vers ProductName: Mac OS X ProductVersion: 10.12.6 BuildVersion: 16G1114 The perl version doesn't seem to matter; I see the same failures with 5.10.1, 5.12.5, 5.27.6 and 5.27.8.

Tue Jan 30 19:22:07 2018 sisyphus [...] cpan.org - Correspondence added

Same failures for me on Windows 7 for perls 5.16.0, 5.27.6 and 5.27.8 (which are the only versions I've tested). And there's a report at http://www.perlmonks.org/?node_id=1208146 of the same errors occurring on RHEL 7.2.

Tue Jan 30 20:38:27 2018 sisyphus [...] cpan.org - Correspondence added

On Tue Jan 30 19:22:07 2018, SISYPHUS wrote: Show quoted text

> Same failures for me on Windows 7 for perls 5.16.0, 5.27.6 and 5.27.8

I was a bit too hasty. It's the same test file that's failing, but the failure is quite different: ###################### C:\Users\sisyphus\.cpan\build\File-Copy-Recursive-0.40-0>perl -Mblib t/01.legacy .t # functionality w/ default globals ok 1 - DirPerms default is 0777 ok 2 - CPRFComp default is false ok 3 - RMTrgFil default is false not ok 4 - dircopy() defaults as expected when target does not exist # Failed test 'dircopy() defaults as expected when target does not exist' # at t/01.legacy.t line 331. # Structures begin differing at: # $got->{C:/Users/sisyphus/AppData/Local/Temp/tNBiHmA0Z3/orig/data} = Does not exist # $expected->{C:/Users/sisyphus/AppData/Local/Temp/tNBiHmA0Z3/orig/data} = 'file' Error open (<) on 'C:/Users/sisyphus/AppData/Local/Temp/tNBiHmA0Z3/new/C:/Users/sisyphus/AppData/Local/Temp/tNBiHmA0Z3/new/data': Invalid argument at t/01.legacy.t line 338. # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 22 just after 4. ###################### Line 338 of t/01.legacy.t is: is( path("$got_dir/$path")->slurp, path("$expected_dir/$path")->slurp, " - file contents preserved (…$path)" ); Cheers, Rob

Thu Apr 19 16:41:39 2018 dmuey [...] cpan.org - Correspondence added

Thanks, this should be fixed in v0.41: error 1: a52b355 Issue #12 and rt 124166 - set umask for reliability (thanks teoric and ether) error 2: https://github.com/drmuey/p5-File-Copy-Recursive/issues/7

Thu Apr 19 16:41:39 2018 dmuey [...] cpan.org - Status changed from 'open' to 'resolved'