Skip Menu |

This queue is for tickets about the MVC-Neaf CPAN distribution.

Report information
The Basics
Id: 124124
Status: resolved
Priority: 0/
Queue: MVC-Neaf
People
Owner: khedin [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 0.2201
Fixed in: 0.2202

History Show all quoted text
  Thu Jan 18 02:21:23 2018 SREZIC [...] cpan.org - Ticket created
Subject: header_in_keys may fail (with older Plack?)
On some of my smoker systems the test suite fails: # Failed test 'header_in_keys (who needs it anyway?)' # at t/907-neader_in_keys.0.25.t line 17. # Structures begin differing at: # $got->[0] = 'COOKIE' # $expected->[0] = 'Cookie' # Looks like you failed 1 test of 2. t/907-neader_in_keys.0.25.t ........... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests This seems to happen if Plack is too old (Plack::Request < 1.0043). Statistical analysis: **************************************************************** Regression 'mod:Plack::Request' **************************************************************** Name Theta StdErr T-stat [0='const'] 0.0000 0.0000 0.00 [1='eq_1.0042'] -0.0000 0.0000 -0.43 [2='eq_1.0043'] 1.0000 0.0000 2987657678422188.50 [3='eq_1.0044'] 1.0000 0.0000 6468468618313140.00 [4='eq_1.0045'] 1.0000 0.0000 6234718827154026.00 R^2= 1.000, N= 94, K= 5 ****************************************************************
  Thu Jan 18 08:07:28 2018 khedin [...] cpan.org - Correspondence added
Hello Slaven, Thanks for your report. It looks like HTTP::Headers::Fast doesn't convert header names as expected, and Plack::Request works around that in 1.043: https://github.com/plack/Plack/pull/585 I think I'll just remove Cookie from this test in the next release since the test has only 3 more releases to live. On Thu Jan 18 02:21:23 2018, SREZIC wrote: Show quoted text
> On some of my smoker systems the test suite fails: > > # Failed test 'header_in_keys (who needs it anyway?)' > # at t/907-neader_in_keys.0.25.t line 17. > # Structures begin differing at: > # $got->[0] = 'COOKIE' > # $expected->[0] = 'Cookie' > # Looks like you failed 1 test of 2. > t/907-neader_in_keys.0.25.t ........... > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/2 subtests > > > This seems to happen if Plack is too old (Plack::Request < 1.0043). > Statistical analysis: > > **************************************************************** > Regression 'mod:Plack::Request' > **************************************************************** > Name Theta StdErr T-stat > [0='const'] 0.0000 0.0000 0.00 > [1='eq_1.0042'] -0.0000 0.0000 -0.43 > [2='eq_1.0043'] 1.0000 0.0000 2987657678422188.50 > [3='eq_1.0044'] 1.0000 0.0000 6468468618313140.00 > [4='eq_1.0045'] 1.0000 0.0000 6234718827154026.00 > > R^2= 1.000, N= 94, K= 5 > ****************************************************************
  Thu Jan 18 08:07:28 2018 The RT System itself - Status changed from 'new' to 'open'
  Thu Jan 18 08:07:29 2018 khedin [...] cpan.org - Taken
  Fri Jan 19 14:10:16 2018 khedin [...] cpan.org - Correspondence added
I seem to have fixed this one in 0.2202, but let's wait until test reports start showing up.
  Thu Jan 25 09:11:22 2018 khedin [...] cpan.org - Correspondence added
http://cpantesters.org/cpan/report/817226c1-6bf3-1014-ae09-fa2ff351589d Earned a PASS with Plack::Request 1.0039 So I mark this as resolved, until some other problem surfaces. Thanks for your contribution, Slaven!
  Thu Jan 25 09:11:22 2018 khedin [...] cpan.org - Status changed from 'open' to 'resolved'
  Thu Jan 25 09:11:22 2018 khedin [...] cpan.org - Fixed in 0.2202 added