Skip Menu |

This queue is for tickets about the IPTables-libiptc CPAN distribution.

Report information
The Basics
Id: 124095
Status: new
Priority: 0/
Queue: IPTables-libiptc

People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 0.52
Fixed in: (no value)



Subject: Useless linking to nsl library
Makefile.PL explicitly links to nsl library: WriteMakefile( [...] ## LIBS => ['-ldl -lnsl -liptc'], # e.g., '-lm' # Notice, perl Makefile.PL will detect if ip4tc is available LIBS => ['-ldl -lnsl -liptc -lip4tc -lxtables'], # e.g., '-lm' ## LIBS => ['-ldl -lnsl'], # e.g., '-lm' This breaks on developmental glibc. glibc-2.26 deprecated the library in favor of standalone libnsl implementation and future glibc will remove it. I believe there is no reason to link against the library and I recommend removing "-lnsl" from LIBS.
From: ppisar [...] redhat.com
Dne Út 16.led.2018 02:47:50, ppisar napsal(a): Show quoted text
> I believe there is no reason to link against the library and I > recommend removing "-lnsl" from LIBS.
Attached patch implements it.
Subject: IPTables-libiptc-0.52-Stop-linking-against-nsl-library.patch
From 95d166247b688dd8c0575b234d023f561deb6ffc Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 16 Jan 2018 08:48:37 +0100 Subject: [PATCH] Stop linking against nsl library MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There is not need for it and it will be removed from glibc. CPAN RT#124095 Signed-off-by: Petr Písař <ppisar@redhat.com> --- Makefile.PL | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 959f86b..16f4df9 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -251,8 +251,8 @@ WriteMakefile( AUTHOR => 'Jesper Dangaard Brouer <hawk@comx.dk>') : ()), ## LIBS => ['-ldl -lnsl -liptc'], # e.g., '-lm' # Notice, perl Makefile.PL will detect if ip4tc is available - LIBS => ['-ldl -lnsl -liptc -lip4tc -lxtables'], # e.g., '-lm' -## LIBS => ['-ldl -lnsl'], # e.g., '-lm' + LIBS => ['-ldl -liptc -lip4tc -lxtables'], # e.g., '-lm' +## LIBS => ['-ldl ], # e.g., '-lm' LDDLFLAGS => '-shared -L$(PREFIX)/lib', ## LDDLFLAGS => '-shared $(LOCAL_LIB_IPTC) -L$(PREFIX)/lib', LDFLAGS => '-L$(PREFIX)/lib', -- 2.13.6
From: ppisar [...] redhat.com
Dne Út 16.led.2018 02:51:29, ppisar napsal(a): Show quoted text
> Dne Út 16.led.2018 02:47:50, ppisar napsal(a):
> > I believe there is no reason to link against the library and I > > recommend removing "-lnsl" from LIBS.
> > Attached patch implements it. >
More thorough removal.
Subject: IPTables-libiptc-0.52-Stop-linking-against-nsl-library.patch
From e47c9bfbfc007abbbb007dc6856824aad4b80580 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Tue, 16 Jan 2018 08:48:37 +0100 Subject: [PATCH] Stop linking against nsl library MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit There is not need for it and it will be removed from glibc. CPAN RT#124095 Signed-off-by: Petr Písař <ppisar@redhat.com> --- Makefile.PL | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile.PL b/Makefile.PL index 959f86b..31907d8 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -249,10 +249,10 @@ WriteMakefile( ($] >= 5.005 ? ## Add these new keywords supported since 5.005 (ABSTRACT_FROM => 'lib/IPTables/libiptc.pm', # retrieve abstract from module AUTHOR => 'Jesper Dangaard Brouer <hawk@comx.dk>') : ()), -## LIBS => ['-ldl -lnsl -liptc'], # e.g., '-lm' +## LIBS => ['-ldl -liptc'], # e.g., '-lm' # Notice, perl Makefile.PL will detect if ip4tc is available - LIBS => ['-ldl -lnsl -liptc -lip4tc -lxtables'], # e.g., '-lm' -## LIBS => ['-ldl -lnsl'], # e.g., '-lm' + LIBS => ['-ldl -liptc -lip4tc -lxtables'], # e.g., '-lm' +## LIBS => ['-ldl ], # e.g., '-lm' LDDLFLAGS => '-shared -L$(PREFIX)/lib', ## LDDLFLAGS => '-shared $(LOCAL_LIB_IPTC) -L$(PREFIX)/lib', LDFLAGS => '-L$(PREFIX)/lib', -- 2.13.6