Skip Menu |

This queue is for tickets about the Net-Patricia CPAN distribution.

Report information
The Basics
Id: 124088
Status: new
Priority: 0/
Queue: Net-Patricia
People
Owner: Nobody in particular
Requestors: ppisar [...] redhat.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.22
Fixed in: (no value)

History Show all quoted text
  Mon Jan 15 09:28:15 2018 ppisar [...] redhat.com - Ticket created
Subject: Useless linking to nsl library
Net-Patricia's Makefile.PL:8 explicitly links to libnsl: WriteMakefile( 'NAME' => 'Net::Patricia', 'VERSION_FROM' => 'Patricia.pm', # finds $VERSION → 'LIBS' => ['-lnsl'], # e.g., '-lm' That causes a build failure with developmental GNU libc library that removed the library and header files in favor of standalone libnsl implementation <https://github.com/thkukuk/libnsl> that supports IPv6. Quick search through Net-Patricia-1.22 sources reveals no libnsl headers files are included. I recommend removing the '-lnsl' from LIBS in the Makefile.PL.
  Mon Feb 12 05:08:46 2018 ppisar [...] redhat.com - Correspondence added
From: ppisar [...] redhat.com
Dne Po 15.led.2018 09:28:15, ppisar napsal(a): Show quoted text
> I recommend removing the '-lnsl' from LIBS in the Makefile.PL.
Attached patch implements it.
Subject: Net-Patricia-1.22-Do-not-link-to-nsl-library.patch
From 4ac454f3d239df546f92056d70dfef1257bbda7a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> Date: Mon, 12 Feb 2018 11:05:08 +0100 Subject: [PATCH] Do not link to nsl library MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Net-Patricia code does not uses any symbols from nsl library, there is no need to link to it. Actually it causes build failures on systems that moved nsl library from glibc to separate project <https://github.com/thkukuk/libnsl>. CPAN RT#124088 Signed-off-by: Petr Písař <ppisar@redhat.com> --- Makefile.PL | 1 - 1 file changed, 1 deletion(-) diff --git a/Makefile.PL b/Makefile.PL index acd0918..c023e43 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -5,7 +5,6 @@ use ExtUtils::MakeMaker; WriteMakefile( 'NAME' => 'Net::Patricia', 'VERSION_FROM' => 'Patricia.pm', # finds $VERSION - 'LIBS' => ['-lnsl'], # e.g., '-lm' 'DEFINE' => '', # e.g., '-DHAVE_SOMETHING' 'INC' => '', # e.g., '-I/usr/include/other' 'MYEXTLIB' => 'libpatricia/libpatricia$(LIB_EXT)', # e.g., '-I/usr/include/other' -- 2.13.6