Bug #123964 for File-Copy-Recursive: BSD: Failed test 'fcopy() returns false if source is a directory'

Fri Dec 29 15:20:28 2017 SREZIC [...] cpan.org - Ticket created

Subject:

Tests fail on freebsd systems (0.39)

On all my freebsd smokers (from version 9 to 12): ... # Failed test 'fcopy() returns false if source is a directory' # at t/01.legacy.t line 76. # Looks like you failed 1 test of 301. t/01.legacy.t ............. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/301 subtests ...

Fri Dec 29 16:38:37 2017 dmuey [...] cpan.org - Correspondence added

thanks! will look into it (and the others one) ASAP! much appreciated ;)

Fri Dec 29 16:38:37 2017 The RT System itself - Status changed from 'new' to 'open'

Wed Jan 03 18:06:13 2018 dmuey [...] cpan.org - Correspondence added

thanks! will rectify ASAP :) On Fri Dec 29 15:20:28 2017, SREZIC wrote: Show quoted text

> On all my freebsd smokers (from version 9 to 12): > > ... > # Failed test 'fcopy() returns false if source is a directory' > # at t/01.legacy.t line 76. > # Looks like you failed 1 test of 301. > t/01.legacy.t ............. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/301 subtests > ...

Tue Jan 16 12:28:42 2018 dmuey [...] cpan.org - Correspondence added

On Fri Dec 29 15:20:28 2017, SREZIC wrote: Show quoted text

> On all my freebsd smokers (from version 9 to 12): > > ... > # Failed test 'fcopy() returns false if source is a directory' > # at t/01.legacy.t line 76. > # Looks like you failed 1 test of 301. > t/01.legacy.t ............. > Dubious, test returned 1 (wstat 256, 0x100) > Failed 1/301 subtests > ...

I am unable to reproduce ATM, what does this output on one of these boxes: mkdir rt123964; perl -Ilib -MFile::Copy::Recursive -e 'print "-",File::Copy::Recursive::fcopy("rt123964","whatevs"), "- ($File::Copy::Recursive::VERSION)\n"' If it returns true, can you add some debuggery to see where it is returning true? that will help make it apparent what is falling down. Thanks!

Tue Jan 16 12:42:25 2018 dmuey [...] cpan.org - Subject changed from 'Tests fail on freebsd systems (0.39)' to 'Tests fail on freebsd systems (0.39) - needs more info'

Tue Jan 16 14:51:45 2018 SREZIC [...] cpan.org - Correspondence added

On 2018-01-16 12:28:42, DMUEY wrote: Show quoted text

> On Fri Dec 29 15:20:28 2017, SREZIC wrote:

> > On all my freebsd smokers (from version 9 to 12): > > > > ... > > # Failed test 'fcopy() returns false if source is a directory' > > # at t/01.legacy.t line 76. > > # Looks like you failed 1 test of 301. > > t/01.legacy.t ............. > > Dubious, test returned 1 (wstat 256, 0x100) > > Failed 1/301 subtests > > ...

> > I am unable to reproduce ATM, what does this output on one of these > boxes: > > mkdir rt123964; perl -Ilib -MFile::Copy::Recursive -e 'print "- > ",File::Copy::Recursive::fcopy("rt123964","whatevs"), "- > ($File::Copy::Recursive::VERSION)\n"' > > If it returns true, can you add some debuggery to see where it is > returning true? that will help make it apparent what is falling down. >

On a FreeBSD 12 system: $ mkdir rt123964; perl -Ilib -MFile::Copy::Recursive -e 'print "-",File::Copy::Recursive::fcopy("rt123964","whatevs"), "- ($File::Copy::Recursive::VERSION)\n"' -100- (0.40)

Tue Jan 16 14:58:05 2018 SREZIC [...] cpan.org - Correspondence added

On 2018-01-16 14:51:45, SREZIC wrote: Show quoted text

> On 2018-01-16 12:28:42, DMUEY wrote:

> > On Fri Dec 29 15:20:28 2017, SREZIC wrote:

> > > On all my freebsd smokers (from version 9 to 12): > > > > > > ... > > > # Failed test 'fcopy() returns false if source is a directory' > > > # at t/01.legacy.t line 76. > > > # Looks like you failed 1 test of 301. > > > t/01.legacy.t ............. > > > Dubious, test returned 1 (wstat 256, 0x100) > > > Failed 1/301 subtests > > > ...

> > > > I am unable to reproduce ATM, what does this output on one of these > > boxes: > > > > mkdir rt123964; perl -Ilib -MFile::Copy::Recursive -e 'print "- > > ",File::Copy::Recursive::fcopy("rt123964","whatevs"), "- > > ($File::Copy::Recursive::VERSION)\n"' > > > > If it returns true, can you add some debuggery to see where it is > > returning true? that will help make it apparent what is falling down. > >

> > On a FreeBSD 12 system: > > $ mkdir rt123964; perl -Ilib -MFile::Copy::Recursive -e 'print "- > ",File::Copy::Recursive::fcopy("rt123964","whatevs"), "- > ($File::Copy::Recursive::VERSION)\n"' > -100- (0.40)

The difference between FreeBSD and Linux: on FreeBSD it's possible to sysread from a directory handle. The following oneliner behaves differently: FreeBSD: $ perl -Mautodie -Mstrict -e 'open my $fh, "rt123964"; sysread($fh,my($buf),512)' (no error) Linux: $ perl -Mautodie -Mstrict -e 'open my $fh, "rt123964"; sysread($fh,my($buf),512)' Can't sysread(GLOB(0x13b7ac0), <BUFFER>, 512): Is a directory at -e line 1

Tue Jan 16 16:23:29 2018 dmuey [...] cpan.org - Correspondence added

Show quoted text

> > On a FreeBSD 12 system: > > > > $ mkdir rt123964; perl -Ilib -MFile::Copy::Recursive -e 'print "- > > ",File::Copy::Recursive::fcopy("rt123964","whatevs"), "- > > ($File::Copy::Recursive::VERSION)\n"' > > -100- (0.40)

> > The difference between FreeBSD and Linux: on FreeBSD it's possible to > sysread from a directory handle. The following oneliner behaves > differently: > > FreeBSD: > $ perl -Mautodie -Mstrict -e 'open my $fh, "rt123964"; > sysread($fh,my($buf),512)' > (no error) > > Linux: > $ perl -Mautodie -Mstrict -e 'open my $fh, "rt123964"; > sysread($fh,my($buf),512)' > Can't sysread(GLOB(0x13b7ac0), <BUFFER>, 512): Is a directory at -e > line 1

awesome, thanks! that's a good starting point :)

Thu Jan 18 09:25:54 2018 dmuey [...] cpan.org - Correspondence added

another e.g. http://www.cpantesters.org/cpan/report/cd755a2a-fbad-11e7-a1cf-bb670eaac09d

Thu Jan 18 09:27:01 2018 dmuey [...] cpan.org - Subject changed from 'Tests fail on freebsd systems (0.39) - needs more info' to 'BSD: Failed test 'fcopy() returns false if source is a directory''

Wed Jan 24 06:39:53 2018 tom [...] eborcom.com - Correspondence added

I have proposed a fix for this at https://github.com/drmuey/p5-File-Copy-Recursive/pull/11

Thu Mar 22 16:04:02 2018 jkeenan [...] cpan.org - Correspondence added

On Wed Jan 24 06:39:53 2018, TOMHUKINS wrote: Show quoted text

> I have proposed a fix for this at https://github.com/drmuey/p5-File- > Copy-Recursive/pull/11

DMUEY: The problem persists. Here's what I got this week attempting to install File-Copy-Recursive via 'cpanm' on FreeBSD-11.0 using perl-5.27.10 and clang 3.8.0: ##### { author => "DMUEY", dist => "File-Copy-Recursive", distname => "File-Copy-Recursive-0.40", distversion => "0.40", grade => "FAIL", prereqs => undef, test_output => [ "Building and testing File-Copy-Recursive-0.40", "cp lib/File/Copy/Recursive.pm blib/lib/File/Copy/Recursive.pm", "PERL_DL_NONLAZY=1 \"/usr/home/jkeenan/prep528/testing/perl-5.27.10/bin/perl\" \"-MExtUtils::Command::MM\" \"-MTest::Harness\" \"-e\" \"undef *Test::Harness::Switches; test_harness(0, 'blib/lib', 'blib/arch')\" t/*.t", "t/00.load.t ............... ok", "", "# Failed test 'fcopy() returns false if source is a directory'", "# at t/01.legacy.t line 76.", "# Looks like you failed 1 test of 109.", "t/01.legacy.t ............. ", "Dubious, test returned 1 (wstat 256, 0x100)", "Failed 1/109 subtests ", "t/02.legacy-symtogsafe.t .. ok", "t/03.github-issue-5.t ..... ok", "t/04.readonly-dir.t ....... ok", "", "Test Summary Report", "-------------------", "t/01.legacy.t (Wstat: 256 Tests: 109 Failed: 1)", " Failed test: 42", " Non-zero exit status: 1", "Files=5, Tests=150, 1 wallclock secs ( 0.03 usr 0.02 sys + 0.48 cusr 0.40 csys = 0.93 CPU)", "Result: FAIL", ], via => "App::cpanminus::reporter 0.17 (1.7043)", } ##### File-Copy-Recursive has *many* other CPAN distributions depending on it. All of those will break in FCR is not fixed before perl-5.28.0 is released. (I have not yet tested TOMHUKINS patch, but it's probably a good starting point.) Thank you very much. Jim Keenan

Thu Mar 22 16:50:35 2018 dmuey [...] cpan.org - Correspondence added

thanks! Good point, I'll prioritize that for this weekend ;) On Thu Mar 22 16:04:02 2018, JKEENAN wrote: Show quoted text

> On Wed Jan 24 06:39:53 2018, TOMHUKINS wrote:

> > I have proposed a fix for this at https://github.com/drmuey/p5-File- > > Copy-Recursive/pull/11

> > > DMUEY: The problem persists. Here's what I got this week attempting > to install File-Copy-Recursive via 'cpanm' on FreeBSD-11.0 using perl- > 5.27.10 and clang 3.8.0: > > ##### > { > author => "DMUEY", > dist => "File-Copy-Recursive", > distname => "File-Copy-Recursive-0.40", > distversion => "0.40", > grade => "FAIL", > prereqs => undef, > test_output => [ > "Building and testing File-Copy-Recursive-0.40", > "cp lib/File/Copy/Recursive.pm blib/lib/File/Copy/Recursive.pm", > "PERL_DL_NONLAZY=1 \"/usr/home/jkeenan/prep528/testing/perl- > 5.27.10/bin/perl\" \"-MExtUtils::Command::MM\" \"-MTest::Harness\" \"- > e\" \"undef *Test::Harness::Switches; test_harness(0, 'blib/lib', > 'blib/arch')\" t/*.t", > "t/00.load.t ............... ok", > "", > "# Failed test 'fcopy() returns false if source is a > directory'", > "# at t/01.legacy.t line 76.", > "# Looks like you failed 1 test of 109.", > "t/01.legacy.t ............. ", > "Dubious, test returned 1 (wstat 256, 0x100)", > "Failed 1/109 subtests ", > "t/02.legacy-symtogsafe.t .. ok", > "t/03.github-issue-5.t ..... ok", > "t/04.readonly-dir.t ....... ok", > "", > "Test Summary Report", > "-------------------", > "t/01.legacy.t (Wstat: 256 Tests: 109 Failed: 1)", > " Failed test: 42", > " Non-zero exit status: 1", > "Files=5, Tests=150, 1 wallclock secs ( 0.03 usr 0.02 sys + > 0.48 cusr 0.40 csys = 0.93 CPU)", > "Result: FAIL", > ], > via => "App::cpanminus::reporter 0.17 (1.7043)", > } > ##### > > File-Copy-Recursive has *many* other CPAN distributions depending on > it. All of those will break in FCR is not fixed before perl-5.28.0 is > released. (I have not yet tested TOMHUKINS patch, but it's probably a > good starting point.) > > Thank you very much. > Jim Keenan

Sun Apr 01 09:35:23 2018 jkeenan [...] cpan.org - Correspondence added

On Thu Mar 22 16:50:35 2018, DMUEY wrote: Show quoted text

> thanks! Good point, I'll prioritize that for this weekend ;) > > On Thu Mar 22 16:04:02 2018, JKEENAN wrote:

> > On Wed Jan 24 06:39:53 2018, TOMHUKINS wrote:

> > > I have proposed a fix for this at https://github.com/drmuey/p5-File- > > > Copy-Recursive/pull/11

> > > > > > DMUEY: The problem persists. Here's what I got this week attempting > > to install File-Copy-Recursive via 'cpanm' on FreeBSD-11.0 using perl- > > 5.27.10 and clang 3.8.0: > > > > ##### > > { > > author => "DMUEY", > > dist => "File-Copy-Recursive", > > distname => "File-Copy-Recursive-0.40", > > distversion => "0.40", > > grade => "FAIL", > > prereqs => undef, > > test_output => [ > > "Building and testing File-Copy-Recursive-0.40", > > "cp lib/File/Copy/Recursive.pm blib/lib/File/Copy/Recursive.pm", > > "PERL_DL_NONLAZY=1 \"/usr/home/jkeenan/prep528/testing/perl- > > 5.27.10/bin/perl\" \"-MExtUtils::Command::MM\" \"-MTest::Harness\" \"- > > e\" \"undef *Test::Harness::Switches; test_harness(0, 'blib/lib', > > 'blib/arch')\" t/*.t", > > "t/00.load.t ............... ok", > > "", > > "# Failed test 'fcopy() returns false if source is a > > directory'", > > "# at t/01.legacy.t line 76.", > > "# Looks like you failed 1 test of 109.", > > "t/01.legacy.t ............. ", > > "Dubious, test returned 1 (wstat 256, 0x100)", > > "Failed 1/109 subtests ", > > "t/02.legacy-symtogsafe.t .. ok", > > "t/03.github-issue-5.t ..... ok", > > "t/04.readonly-dir.t ....... ok", > > "", > > "Test Summary Report", > > "-------------------", > > "t/01.legacy.t (Wstat: 256 Tests: 109 Failed: 1)", > > " Failed test: 42", > > " Non-zero exit status: 1", > > "Files=5, Tests=150, 1 wallclock secs ( 0.03 usr 0.02 sys + > > 0.48 cusr 0.40 csys = 0.93 CPU)", > > "Result: FAIL", > > ], > > via => "App::cpanminus::reporter 0.17 (1.7043)", > > } > > ##### > > > > File-Copy-Recursive has *many* other CPAN distributions depending on > > it. All of those will break in FCR is not fixed before perl-5.28.0 is > > released. (I have not yet tested TOMHUKINS patch, but it's probably a > > good starting point.) > > > > Thank you very much. > > Jim Keenan

> >

DMUEY: I have tested Tom Hukins's patch and it enables File-Copy-Recursive to test successfully on FreeBSD-11.0. I urge you to apply it ASAP, as without it we are unable to test hundreds of CPAN libraries on this OS in preparation for perl-5.28. For example, all libraries which use DateTime are blocked because it is a (second-generation) reverse dependency of File-Copy-Recursive. Thank you very much. Jim Keenan

Mon Apr 09 08:30:29 2018 jkeenan [...] cpan.org - Correspondence added

On Sun Apr 01 09:35:23 2018, JKEENAN wrote: Show quoted text

> On Thu Mar 22 16:50:35 2018, DMUEY wrote:

> > thanks! Good point, I'll prioritize that for this weekend ;) > > > > On Thu Mar 22 16:04:02 2018, JKEENAN wrote:

> > > On Wed Jan 24 06:39:53 2018, TOMHUKINS wrote:

> > > > I have proposed a fix for this at https://github.com/drmuey/p5- > > > > File- > > > > Copy-Recursive/pull/11

> > > > > > > > > DMUEY: The problem persists. Here's what I got this week > > > attempting > > > to install File-Copy-Recursive via 'cpanm' on FreeBSD-11.0 using > > > perl- > > > 5.27.10 and clang 3.8.0: > > > > > > ##### > > > { > > > author => "DMUEY", > > > dist => "File-Copy-Recursive", > > > distname => "File-Copy-Recursive-0.40", > > > distversion => "0.40", > > > grade => "FAIL", > > > prereqs => undef, > > > test_output => [ > > > "Building and testing File-Copy-Recursive-0.40", > > > "cp lib/File/Copy/Recursive.pm > > > blib/lib/File/Copy/Recursive.pm", > > > "PERL_DL_NONLAZY=1 \"/usr/home/jkeenan/prep528/testing/perl- > > > 5.27.10/bin/perl\" \"-MExtUtils::Command::MM\" \"-MTest::Harness\" > > > \"- > > > e\" \"undef *Test::Harness::Switches; test_harness(0, 'blib/lib', > > > 'blib/arch')\" t/*.t", > > > "t/00.load.t ............... ok", > > > "", > > > "# Failed test 'fcopy() returns false if source is a > > > directory'", > > > "# at t/01.legacy.t line 76.", > > > "# Looks like you failed 1 test of 109.", > > > "t/01.legacy.t ............. ", > > > "Dubious, test returned 1 (wstat 256, 0x100)", > > > "Failed 1/109 subtests ", > > > "t/02.legacy-symtogsafe.t .. ok", > > > "t/03.github-issue-5.t ..... ok", > > > "t/04.readonly-dir.t ....... ok", > > > "", > > > "Test Summary Report", > > > "-------------------", > > > "t/01.legacy.t (Wstat: 256 Tests: 109 Failed: 1)", > > > " Failed test: 42", > > > " Non-zero exit status: 1", > > > "Files=5, Tests=150, 1 wallclock secs ( 0.03 usr 0.02 sys + > > > 0.48 cusr 0.40 csys = 0.93 CPU)", > > > "Result: FAIL", > > > ], > > > via => "App::cpanminus::reporter 0.17 (1.7043)", > > > } > > > ##### > > > > > > File-Copy-Recursive has *many* other CPAN distributions depending > > > on > > > it. All of those will break in FCR is not fixed before perl-5.28.0 > > > is > > > released. (I have not yet tested TOMHUKINS patch, but it's > > > probably a > > > good starting point.) > > > > > > Thank you very much. > > > Jim Keenan

> > > >

> > DMUEY: > > I have tested Tom Hukins's patch and it enables File-Copy-Recursive to > test successfully on FreeBSD-11.0. I urge you to apply it ASAP, as > without it we are unable to test hundreds of CPAN libraries on this OS > in preparation for perl-5.28. For example, all libraries which use > DateTime are blocked because it is a (second-generation) reverse > dependency of File-Copy-Recursive. > > Thank you very much. > Jim Keenan

DMUEY, Have you been able to make any progress toward a new release of File-Copy-Recursive? On April 20, we expect to release perl-5.27.11 -- the last monthly development release prior to the release of perl-5.28.0 in May. If we can get a new CPAN release of a corrected File-Copy-Recursive before April 20, that would greatly facilitate testing of this library and libraries dependent upon it on non-Linux operating systems. Thank you very much. Jim Keenan

Sun Apr 15 21:20:26 2018 ether [...] cpan.org - Severity Critical added

Thu Apr 19 14:49:09 2018 dmuey [...] cpan.org - Correspondence added

https://github.com/drmuey/p5-File-Copy-Recursive/pull/11 is merged into master, thanks! should have a release by the week end

Thu Apr 19 14:49:10 2018 dmuey [...] cpan.org - Status changed from 'open' to 'resolved'