Bug #123947 for EBook-MOBI-Image: Imlib2 save bug

Wed Dec 27 11:41:48 2017 andi [...] go-for-fun.de - Ticket created

Subject:	Imlib2 save bug
Date:	Wed, 27 Dec 2017 16:41:24 +0000
To:	"bug-EBook-MOBI-Image [...] rt.cpan.org" <bug-EBook-MOBI-Image [...] rt.cpan.org>
From:	Andreas Zöllner <andi [...] go-for-fun.de>

Hi, I found a problem with Ebook::MOBI::Image: Imlib2 isn't saving images that don't need resizing on macOS Sierra. I resolved this by adding the following lines to Image.pm: # If the file is below max width/height we dont to anything # NOPE: We do convert to JPG, because PNG fails on Kindle else { $self->_debug( "Image $image_path is of size $width"."x$height - no resizing." ); print "Resolving save bug \n"; my $resized = $image->create_scaled_image($width-1, 0); # BUG: Seems like Kindle Reader can't display PNG in my tests... # SO I CONVERT EVERYTHING TO JPEG $resized->save($outfilename); # this is so that return returns the right value $image_path = $outfilename; } Maybe you want to put this into your code base as well. Regards Andreas

Fri Jan 05 09:58:53 2018 bdaeppen.perl [...] gmail.com - Correspondence added

Subject:	Re: [rt.cpan.org #123947] Imlib2 save bug
Date:	Fri, 5 Jan 2018 15:58:41 +0100
To:	bug-EBook-MOBI-Image [...] rt.cpan.org
From:	Boris Däppen <bdaeppen.perl [...] gmail.com>

can you make a pull request on github? https://github.com/borisdaeppen/EBook--MOBI 2017-12-27 17:41 GMT+01:00 Andreas Zöllner via RT < bug-EBook-MOBI-Image@rt.cpan.org>: Show quoted text

> Wed Dec 27 11:41:48 2017: Request 123947 was acted upon. > Transaction: Ticket created by andi@go-for-fun.de > Queue: EBook-MOBI-Image > Subject: Imlib2 save bug > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: andi@go-for-fun.de > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=123947 > > > > Hi, > > > I found a problem with Ebook::MOBI::Image: Imlib2 isn't saving images that > don't need resizing on macOS Sierra. I resolved this by adding the > following lines to Image.pm: > > > # If the file is below max width/height we dont to anything > > # NOPE: We do convert to JPG, because PNG fails on Kindle > > else { > > $self->_debug( > > "Image $image_path is of size $width"."x$height - no resizing." > > ); > > > print "Resolving save bug \n"; > > my $resized = $image->create_scaled_image($width-1, 0); > > # BUG: Seems like Kindle Reader can't display PNG in my tests... > > # SO I CONVERT EVERYTHING TO JPEG > > $resized->save($outfilename); > > > # this is so that return returns the right value > > $image_path = $outfilename; > > } > > Maybe you want to put this into your code base as well. > > Regards > > Andreas >

Fri Jan 05 09:58:53 2018 The RT System itself - Status changed from 'new' to 'open'

Wed Jan 10 15:55:59 2018 andi [...] go-for-fun.de - Correspondence added

Subject:	Re: [rt.cpan.org #123947] Imlib2 save bug
Date:	Wed, 10 Jan 2018 20:55:01 +0000
To:	"bug-EBook-MOBI-Image [...] rt.cpan.org" <bug-EBook-MOBI-Image [...] rt.cpan.org>
From:	Andreas Zöllner <andi [...] go-for-fun.de>

Just sent you a pull request for EBook::MOB::Image on github. Regards Andreas On 05/01/18 15:59, "Boris Däppen via RT" <bug-EBook-MOBI-Image@rt.cpan.org> wrote: <URL: https://rt.cpan.org/Ticket/Display.html?id=123947 > can you make a pull request on github? https://github.com/borisdaeppen/EBook--MOBI 2017-12-27 17:41 GMT+01:00 Andreas Zöllner via RT < bug-EBook-MOBI-Image@rt.cpan.org>: Show quoted text

> Wed Dec 27 11:41:48 2017: Request 123947 was acted upon. > Transaction: Ticket created by andi@go-for-fun.de > Queue: EBook-MOBI-Image > Subject: Imlib2 save bug > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: andi@go-for-fun.de > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=123947 > > > > Hi, > > > I found a problem with Ebook::MOBI::Image: Imlib2 isn't saving images that > don't need resizing on macOS Sierra. I resolved this by adding the > following lines to Image.pm: > > > # If the file is below max width/height we dont to anything > > # NOPE: We do convert to JPG, because PNG fails on Kindle > > else { > > $self->_debug( > > "Image $image_path is of size $width"."x$height - no resizing." > > ); > > > print "Resolving save bug \n"; > > my $resized = $image->create_scaled_image($width-1, 0); > > # BUG: Seems like Kindle Reader can't display PNG in my tests... > > # SO I CONVERT EVERYTHING TO JPEG > > $resized->save($outfilename); > > > # this is so that return returns the right value > > $image_path = $outfilename; > > } > > Maybe you want to put this into your code base as well. > > Regards > > Andreas >