Skip Menu |

This queue is for tickets about the Digest-SHA CPAN distribution.

Report information
The Basics
Id: 123863
Status: resolved
Worked: 15 min
Priority: 0/
Queue: Digest-SHA
People
Owner: mshelor [...] cpan.org
Requestors: chris [...] bingosnet.co.uk
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 6.01
Attachments
remove_perl_core_boiler.diff
signature.asc

History Show all quoted text
  Tue Dec 12 09:02:06 2017 chris [...] bingosnet.co.uk - Ticket created
Subject: PATCH remove PERL_CORE boilerplate from tests
Date: Tue, 12 Dec 2017 13:59:54 +0000
To: bug-Digest-SHA [...] rt.cpan.org
From: Chris 'BinGOs' Williams <chris [...] bingosnet.co.uk>
Hi, Whilst updating Digest-SHA in core today I found that recent changes to the test files was causing failures in all the tests. Removing the PERL_CORE boiler-plate resolved the issue. I believe that this hasn't been required for a long while now. Attached is a patch to fix the tests. Have confirmed it resolves the issue in core. Many thanks in advance, -- Chris Williams aka BinGOs PGP ID 0x4658671F http://www.gumbynet.org.uk ==========================

Message body is not shown because sender requested not to inline it.

Download signature.asc
application/pgp-signature 181b

Message body not shown because it is not plain text.

  Wed Dec 13 02:04:24 2017 mshelor [...] cpan.org - Taken
  Wed Dec 13 02:09:40 2017 mshelor [...] cpan.org - Correspondence added
On Tue Dec 12 09:02:06 2017, chris@bingosnet.co.uk wrote: Show quoted text
> Hi, > > Whilst updating Digest-SHA in core today I found that recent changes > to the test files > was causing failures in all the tests. > > Removing the PERL_CORE boiler-plate resolved the issue. > > I believe that this hasn't been required for a long while now. > > Attached is a patch to fix the tests. > > Have confirmed it resolves the issue in core. > > Many thanks in advance,
Mungo like patch. Patch make Mungo's code pretty again. Mungo thank Bingos.
  Wed Dec 13 02:09:40 2017 The RT System itself - Status changed from 'new' to 'open'
  Wed Dec 13 14:39:00 2017 mshelor [...] cpan.org - Correspondence added
On Tue Dec 12 09:02:06 2017, chris@bingosnet.co.uk wrote: Show quoted text
> Whilst updating Digest-SHA in core today I found that recent changes > to the test files > was causing failures in all the tests.
This comment did cause a bit of head scratching. The PERL_CORE preambles have been in my test scripts for the past 12 years, ever since Digest::SHA became part of the core. The preambles have remained unchanged for that entire time. No recent change should have caused the test scripts to fail. In any event I am glad you folks finally sorted out the core testing protocols so that preambles are no longer necessary for dual-life modules. Regards, Mark
  Mon Dec 25 17:25:40 2017 mshelor [...] cpan.org - Correspondence added 15 min
Fixed in Version 6.01. Mark
  Mon Dec 25 17:25:40 2017 mshelor [...] cpan.org - Status changed from 'open' to 'resolved'
  Mon Dec 25 17:25:41 2017 mshelor [...] cpan.org - Fixed in 6.01 added
  Mon Sep 03 04:32:37 2018 RURBAN [...] cpan.org - Correspondence added
Explanation: I suppose it was the XSLoader change. Restricting INC to lib in core is not enough with XSLoader, you also need lib/arch, complementing -Mblib in non-core. It was ok with DynaLoader only. core t/TEST runs with -I../.. -MTestInit=U2T for cpan/dist/ext which does proper INC setting already. It also adds . to INC. -- Reini Urban