| Subject: | Coverity #169270: Nesting level does not match indentation |
954
parent: This 'if' statement is the parent, indented to column 9.
955 if (spill)
956 /* the POP_MULTICALL will trigger the SAVEFREESV above;
957 * keep it alive it on the temps stack instead */
nephew: This statement is nested within its parent, indented to column 13.
958 SvREFCNT_inc_simple_void_NN(spill);
CID 169270 (#1 of 1): Nesting level does not match indentation (NESTING_INDENT_MISMATCH)
uncle: This statement is indented to column 13, as if it were nested within the preceding parent statement, but it is not.
959 sv_2mortal((SV*)spill);
960
961 POP_MULTICALL;
So the sv2mortal() call deceptively looks like as if it were at the same level SvREFCNT_... call().
I would suggest adding braces so that"if (spill) { SvREFCNT_... }" and then also indenting the sv_2mortal() correctly.