Bug #123732 for Data-TableReader: Bizarre copy of ARRAY in last (0.001, 0.002)

Fri Nov 24 15:30:34 2017 SREZIC [...] cpan.org - Ticket created

Subject:

Bizarre copy of ARRAY in last (0.001, 0.002)

t/40-locate-table.t fails with older perls (< 5.20): ... t/35-record-iterator.t .... ok # warning: Skipping blank rows from row 2 until row 3 Bizarre copy of ARRAY in last at /usr/home/eserte/.cpan/build/2017112418/Data-TableReader-0.002-2/blib/lib/Data/TableReader.pm line 265. # Tests were run but no plan was declared and done_testing() was not seen. # Looks like your test exited with 255 just after 4. t/40-locate-table.t ....... Dubious, test returned 255 (wstat 65280, 0xff00) All 4 subtests passed # error: row 3: Invalid record: X: not alpha # warning: Skipping blank rows from row 4 until row 5 # warning: row 6: Skipped for data errors: X: not numeric # warning: row 7: Skipped for data errors: X: not numeric # warning: row 8: Skipped for data errors: X: not numeric t/50-validation.t ......... ok ...

Sat Nov 25 18:10:32 2017 NERDVANA [...] cpan.org - Correspondence added

On Fri Nov 24 15:30:34 2017, SREZIC wrote: Show quoted text

> t/40-locate-table.t fails with older perls (< 5.20): > > ... > t/35-record-iterator.t .... ok > # warning: Skipping blank rows from row 2 until row 3 > Bizarre copy of ARRAY in last at > /usr/home/eserte/.cpan/build/2017112418/Data-TableReader-0.002- > 2/blib/lib/Data/TableReader.pm line 265. > # Tests were run but no plan was declared and done_testing() was not > seen. > # Looks like your test exited with 255 just after 4. > t/40-locate-table.t ....... > Dubious, test returned 255 (wstat 65280, 0xff00) > All 4 subtests passed > # error: row 3: Invalid record: X: not alpha > # warning: Skipping blank rows from row 4 until row 5 > # warning: row 6: Skipped for data errors: X: not numeric > # warning: row 7: Skipped for data errors: X: not numeric > # warning: row 8: Skipped for data errors: X: not numeric > t/50-validation.t ......... ok > ...

Interesting. It was actually a perl bug! Was caused by: for ($start .. $end) { push @array, $scalar || last; ... } I fixed that to more sane syntax, and also changed $fh->tell to tell($fh) and now it should work all the way back to 5.8 Fixed in 0.003, whenever that goes live.

Sat Nov 25 18:10:33 2017 The RT System itself - Status changed from 'new' to 'open'

Mon Nov 27 23:10:17 2017 NERDVANA [...] cpan.org - Correspondence added

On Sat Nov 25 18:10:32 2017, NERDVANA wrote: Show quoted text

> On Fri Nov 24 15:30:34 2017, SREZIC wrote:

> > t/40-locate-table.t fails with older perls (< 5.20): > > > > ... > > t/35-record-iterator.t .... ok > > # warning: Skipping blank rows from row 2 until row 3 > > Bizarre copy of ARRAY in last at > > /usr/home/eserte/.cpan/build/2017112418/Data-TableReader-0.002- > > 2/blib/lib/Data/TableReader.pm line 265. > > # Tests were run but no plan was declared and done_testing() was not > > seen. > > # Looks like your test exited with 255 just after 4. > > t/40-locate-table.t ....... > > Dubious, test returned 255 (wstat 65280, 0xff00) > > All 4 subtests passed > > # error: row 3: Invalid record: X: not alpha > > # warning: Skipping blank rows from row 4 until row 5 > > # warning: row 6: Skipped for data errors: X: not numeric > > # warning: row 7: Skipped for data errors: X: not numeric > > # warning: row 8: Skipped for data errors: X: not numeric > > t/50-validation.t ......... ok > > ...

> > Interesting. It was actually a perl bug! Was caused by: > > for ($start .. $end) { > push @array, $scalar || last; > ... > } > > I fixed that to more sane syntax, and also changed $fh->tell to > tell($fh) and now it should work all the way back to 5.8 > > Fixed in 0.003, whenever that goes live.

Mon Nov 27 23:10:18 2017 NERDVANA [...] cpan.org - Status changed from 'open' to 'resolved'

Mon Nov 27 23:10:18 2017 NERDVANA [...] cpan.org - Taken

Mon Nov 27 23:10:18 2017 NERDVANA [...] cpan.org - Fixed in 0.005 added