Skip Menu |

This queue is for tickets about the Compress-Raw-Zlib CPAN distribution.

Report information
The Basics
Id: 123699
Status: resolved
Priority: 0/
Queue: Compress-Raw-Zlib
People
Owner: pmqs [...] cpan.org
Requestors: WERNERMP [...] cpan.org
Cc: marc-philip.werner [...] sap.com
AdminCc:
Bug Information
Severity: Normal
Broken in: 2.069
Fixed in: 2.076

History Show all quoted text
  Tue Nov 21 07:53:18 2017 WERNERMP [...] cpan.org - Ticket created
CC: marc-philip.werner [...] sap.com
Subject: wrong external zlib name used on Windows
When building against a pre-built library of zlib, the link option is -lz on all platforms, where it must be -lzlib on Windows, because the zlib project builds a zlib.lib on Windows. Please find the attached patch as a suggestion how to fix it. Regards Marc-Philip
Subject: win_zlibname.patch
diff -Naur Compress-Raw-Zlib-2.075.orig/Makefile.PL Compress-Raw-Zlib-2.075/Makefile.PL --- Compress-Raw-Zlib-2.075.orig/Makefile.PL 2017-02-04 18:22:32.000000000 +0000 +++ Compress-Raw-Zlib-2.075/Makefile.PL 2017-11-21 12:42:43.477106700 +0000 @@ -85,7 +85,7 @@ ( $BUILD_ZLIB ? zlib_files($ZLIB_LIB) - : (LIBS => [ "-L$ZLIB_LIB -lz " ]) + : (LIBS => [ "-L$ZLIB_LIB -lz".($^O=="MSWin32"?"lib":"")." " ]) ), OPTIMIZE => $OPTIMIZE,
  Tue Nov 21 14:50:43 2017 pmqs [...] cpan.org - Correspondence added
Hey Marc-Philip. thanks for the patch. I'm really surprised that my module has been out in the wild so long without needing this change. The proposed patch looks fine apart from the use of "==", where it should be "eq". I'll tidy the patch a bit & upload once I get my smote tests run. Problem for me is I don't have a Windows environment to test this on. I assume you do? If so, would you mind testing it please? cheers Paul
  Tue Nov 21 14:50:43 2017 The RT System itself - Status changed from 'new' to 'open'
  Tue Nov 21 14:50:44 2017 pmqs [...] cpan.org - Status changed from 'open' to 'patched'
  Tue Nov 21 15:23:41 2017 WERNERMP [...] cpan.org - Correspondence added
On Tue Nov 21 14:50:43 2017, PMQS wrote: Show quoted text
> The proposed patch looks fine apart from the use of "==", where it > should be "eq".
Oh yes, my bad. Grmpf. Show quoted text
> Problem for me is I don't have a Windows environment to test this on. > I assume you do? If so, would you mind testing it please?
Sure, no problem, I will. Show quoted text
> cheers > Paul
Thank you for looking into this! MP
  Tue Nov 21 17:29:32 2017 pmqs [...] cpan.org - Correspondence added
Thanks - updated module just uploaded to CPAN.
  Wed Nov 22 08:36:55 2017 WERNERMP [...] cpan.org - Correspondence added
On Tue Nov 21 17:29:32 2017, PMQS wrote: Show quoted text
> Thanks - updated module just uploaded to CPAN.
2.076 builds fine on Unixes, Linux and Windows (both 32 and 64 bit). Regards MP
  Wed Nov 22 09:56:03 2017 pmqs [...] cpan.org - Correspondence added
On Wed Nov 22 08:36:55 2017, WERNERMP wrote: Show quoted text
> On Tue Nov 21 17:29:32 2017, PMQS wrote: >
> > Thanks - updated module just uploaded to CPAN.
> 2.076 builds fine on Unixes, Linux and Windows (both 32 and 64 bit).
Ta, that's great. Closing ticket. Paul
  Wed Nov 22 09:56:04 2017 pmqs [...] cpan.org - Status changed from 'patched' to 'resolved'
  Wed Nov 22 09:56:04 2017 pmqs [...] cpan.org - Fixed in 2.076 added