Skip Menu |

This queue is for tickets about the Sphinx-Search CPAN distribution.

Report information
The Basics
Id: 123648
Status: resolved
Priority: 0/
Queue: Sphinx-Search
People
Owner: Nobody in particular
Requestors: ivanchenko.michael.work [...] gmail.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Nov 16 12:15:52 2017 ivanchenko.michael.work [...] gmail.com - Ticket created
CC: Michael Ivanchenko <ivanchenko.michael.work [...] gmail.com>
Subject: Typo in Sphinx::Search
Date: Thu, 16 Nov 2017 19:15:10 +0200
To: bug-Sphinx-Search [...] rt.cpan.org
From: Michael Ivanchenko <ivanchenko.michael.work [...] gmail.com>
Hi, I found a typo in `Sphinx-Search-0.29`. The parameter `connectretries` is set in `sub SetConnectRetries`: https://metacpan.org/source/JJSCHUTZ/Sphinx-Search-0.29/lib/Sphinx/Search.pm#L597 but it's not checked in `sub _ProcessRequest`: https://metacpan.org/source/JJSCHUTZ/Sphinx-Search-0.29/lib/Sphinx/Search.pm#L782 So, there are always two attempts made in `sub _ProcessRequest` in case of a connection error regardless of what is set in `sub SetConnectRetries`. The `_connectretries` parameter is checked, but not the `connectretries`. Could you rename `connectretries` to `_connectretries` please? Is there a need to add a test for that? And if so, which one - the unit or the functional one? Thank you.
  Thu Nov 23 05:41:33 2017 JJSCHUTZ [...] cpan.org - Correspondence added
Hi, Thanks for pointing out this issue. I've fixed the typo and uploaded version 0.30. Hope it fixes your problem. This software is in maintenance mode, it's recommended that you change to using the DBI driver which is much faster and supports all the latest features. On Thu Nov 16 12:15:52 2017, ivanchenko.michael.work@gmail.com wrote: Show quoted text
> Hi, I found a typo in `Sphinx-Search-0.29`. > > The parameter `connectretries` is set in `sub SetConnectRetries`: > https://metacpan.org/source/JJSCHUTZ/Sphinx-Search- > 0.29/lib/Sphinx/Search.pm#L597 > > but it's not checked in `sub _ProcessRequest`: > https://metacpan.org/source/JJSCHUTZ/Sphinx-Search- > 0.29/lib/Sphinx/Search.pm#L782 > > So, there are always two attempts made in `sub _ProcessRequest` in > case of > a connection error regardless of what is set in `sub > SetConnectRetries`. > > The `_connectretries` parameter is checked, but not the > `connectretries`. > Could you rename `connectretries` to `_connectretries` please? > Is there a need to add a test for that? > And if so, which one - the unit or the functional one? > > Thank you.
  Thu Nov 23 05:41:33 2017 The RT System itself - Status changed from 'new' to 'open'
  Thu Nov 23 05:41:33 2017 JJSCHUTZ [...] cpan.org - Status changed from 'open' to 'resolved'