Skip Menu |

This queue is for tickets about the Unicode-Collate CPAN distribution.

Report information
The Basics
Id: 123631
Status: resolved
Priority: 0/
Queue: Unicode-Collate

People
Owner: Nobody in particular
Requestors: atoomic [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.25



Subject: Switch Unicode::Collate to XSLoader
p5p has recently switched all CORE modules to XSLoader for performance reasons during the 5.27 development cycle. Note, XSLoader is a problem for Perl versions earlier than 5.6, which at this point can get alternate support, as mentioned in the upstream case. Upstream-Case: RT #132080 Upstream-URL: https://rt.perl.org/SelfService/Display.html?id=132080 Smoked the distro on travis: https://travis-ci.org/atoomic/Unicode-Collate/builds/302103480 Note: travis do not support by default perl 5.6 ____
Subject: 0001-Switch-Unicode-Collate-to-XSLoader.patch
From 5af395aa5f3257c5c2995be5e53f1dbf9f331d12 Mon Sep 17 00:00:00 2001 From: Nicolas R <atoomic@cpan.org> Date: Tue, 14 Nov 2017 13:24:44 -0600 Subject: [PATCH] Switch Unicode::Collate to XSLoader p5p has recently switched all CORE modules to XSLoader for performance reasons during the 5.27 development cycle. Note, XSLoader is a problem for Perl versions earlier than 5.6, which at this point can get alternate support, as mentioned in the upstream case. Upstream-Case: RT #132080 Upstream-URL: https://rt.perl.org/SelfService/Display.html?id=132080 --- Collate.pm | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/Collate.pm b/Collate.pm index e572e7c..414b50b 100644 --- a/Collate.pm +++ b/Collate.pm @@ -21,9 +21,8 @@ our $VERSION = '1.23'; our $PACKAGE = __PACKAGE__; ### begin XS only ### -require DynaLoader; -our @ISA = qw(DynaLoader); -bootstrap Unicode::Collate $VERSION; +use XSLoader (); +XSLoader::load( 'Unicode::Collate', $VERSION ); ### end XS only ### my @Path = qw(Unicode Collate); -- 2.13.6 (Apple Git-96)
From: ppisar [...] redhat.com
Dne Út 14.lis.2017 15:20:05, atoomic@cpan.org napsal(a): Show quoted text
> p5p has recently switched all CORE modules to XSLoader > for performance reasons during the 5.27 development cycle. >
The Makefile.PL in 1.24 still declares dependency on DynaLoader. It should also be replaced with XSLoader.
From: atoomic [...] cpan.org
yeap you are right, just updated the patch with this minor change thanks On Tue Nov 21 04:54:28 2017, ppisar wrote: Show quoted text
> Dne Út 14.lis.2017 15:20:05, atoomic@cpan.org napsal(a):
> > p5p has recently switched all CORE modules to XSLoader > > for performance reasons during the 5.27 development cycle. > >
> The Makefile.PL in 1.24 still declares dependency on DynaLoader. It > should also be replaced with XSLoader.
Subject: 0001-Switch-Unicode-Collate-to-XSLoader.patch
From da28f4a721b5e815fda1e9aa97e2efecb98ca326 Mon Sep 17 00:00:00 2001 From: Nicolas R <atoomic@cpan.org> Date: Tue, 14 Nov 2017 13:24:44 -0600 Subject: [PATCH] Switch Unicode::Collate to XSLoader p5p has recently switched all CORE modules to XSLoader for performance reasons during the 5.27 development cycle. Note, XSLoader is a problem for Perl versions earlier than 5.6, which at this point can get alternate support, as mentioned in the upstream case. Upstream-Case: RT #132080 Upstream-URL: https://rt.perl.org/SelfService/Display.html?id=132080 --- Collate.pm | 5 ++--- Makefile.PL | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/Collate.pm b/Collate.pm index e572e7c..414b50b 100644 --- a/Collate.pm +++ b/Collate.pm @@ -21,9 +21,8 @@ our $VERSION = '1.23'; our $PACKAGE = __PACKAGE__; ### begin XS only ### -require DynaLoader; -our @ISA = qw(DynaLoader); -bootstrap Unicode::Collate $VERSION; +use XSLoader (); +XSLoader::load( 'Unicode::Collate', $VERSION ); ### end XS only ### my @Path = qw(Unicode Collate); diff --git a/Makefile.PL b/Makefile.PL index 63b93e4..503eaba 100644 --- a/Makefile.PL +++ b/Makefile.PL @@ -23,7 +23,7 @@ WriteMakefile( 'PREREQ_PM' => { Carp => 0, constant => 0, - DynaLoader => 0, + XS::Loader => 0, File::Spec => 0, strict => 0, warnings => 0, -- 2.13.6 (Apple Git-96)
Thank you for reports and patches. Applied. Show quoted text
> yeap you are right, just updated the patch with this minor change > thanks > > On Tue Nov 21 04:54:28 2017, ppisar wrote:
> > Dne Út 14.lis.2017 15:20:05, atoomic@cpan.org napsal(a):
> > > p5p has recently switched all CORE modules to XSLoader > > > for performance reasons during the 5.27 development cycle. > > >
> > The Makefile.PL in 1.24 still declares dependency on DynaLoader. It > > should also be replaced with XSLoader.
>