Skip Menu |

This queue is for tickets about the Parallel-PreForkManager CPAN distribution.

Report information
The Basics
Id: 123560
Status: resolved
Priority: 0/
Queue: Parallel-PreForkManager
People
Owner: mbradshaw [...] cpan.org
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.20170417
Fixed in: (no value)

History Show all quoted text
  Wed Nov 08 06:19:14 2017 SREZIC [...] cpan.org - Ticket created
Subject: t/01-process-count-limit.t randomly fails
See subject. Overview of fail reports at CPAN Testers: http://matrix.cpantesters.org/?dist=Parallel-PreForkManager+1.20170417 I am working on a patch.
  Wed Nov 08 08:01:41 2017 SREZIC [...] cpan.org - Correspondence added
On 2017-11-08 06:19:14, SREZIC wrote: Show quoted text
> See subject. Overview of fail reports at CPAN Testers: > http://matrix.cpantesters.org/?dist=Parallel-PreForkManager+1.20170417 > > I am working on a patch.
The patch is here: http://cpan.metacpan.org/authors/id/$cascading_user_path/$cpan_patch_dir/$patch_filename The problem: uniq() must not be used on the worker results, because it's possible that the same worker does two jobs.
  Wed Nov 08 19:31:20 2017 mbradshaw [...] cpan.org - Taken
  Wed Nov 08 19:31:46 2017 mbradshaw [...] cpan.org - Correspondence added
Thanks for that, could you check and repost the patch link, it appears to be broken. -Marc
  Wed Nov 08 19:31:47 2017 The RT System itself - Status changed from 'new' to 'open'
  Wed Nov 08 19:47:40 2017 mbradshaw [...] cpan.org - Correspondence added
Show quoted text
> The problem: uniq() must not be used on the worker results, because > it's possible that the same worker does two jobs.
Looking at this again I think the test could be improved if it were to count the number of forks. I have used your uniq() change and added a further test. Thanks.
  Thu Nov 09 15:55:19 2017 SREZIC [...] cpan.org - Correspondence added
On 2017-11-08 19:31:46, MBRADSHAW wrote: Show quoted text
> Thanks for that, > could you check and repost the patch link, it appears to be broken.
Sorry. It's http://cpan.metacpan.org/authors/id/S/SR/SREZIC/patches/Parallel-PreForkManager-1.20170417-RT123560.patch (but probably you found it already)
  Sun Jan 21 20:08:20 2018 mbradshaw [...] cpan.org - Status changed from 'open' to 'resolved'