Skip Menu |

This queue is for tickets about the Apache-Test CPAN distribution.

Report information
The Basics
Id: 123282
Status: new
Priority: 0/
Queue: Apache-Test
People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sat Oct 14 13:01:23 2017 KENTNL [...] cpan.org - Ticket created
Subject: Missing ";" in Apache::TestConfigPHP

When doing basic compile-testing of Apache::TestConfigPHP, the following error emerged:


syntax error at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 175, near "$file

    my "
Global symbol "$log" requires explicit package name (did you forget to declare "my $log"?) at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 175.
Global symbol "$self" requires explicit package name (did you forget to declare "my $self"?) at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 177.
Global symbol "$dir" requires explicit package name (did you forget to declare "my $dir"?) at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 177.
Global symbol "$self" requires explicit package name (did you forget to declare "my $self"?) at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 178.
Global symbol "$file" requires explicit package name (did you forget to declare "my $file"?) at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 178.
Global symbol "$log" requires explicit package name (did you forget to declare "my $log"?) at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 180.
Global symbol "$file" requires explicit package name (did you forget to declare "my $file"?) at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 183.
Global symbol "$self" requires explicit package name (did you forget to declare "my $self"?) at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 185.
Global symbol "$file" requires explicit package name (did you forget to declare "my $file"?) at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 185.
syntax error at /var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm line 186, near "}"
/var/tmp/portage/dev-perl/Apache-Test-1.400.0-r2/work/Apache-Test-1.40/blib/lib/Apache/TestConfigPHP.pm has too many errors.


The culprit appears to be missing a ';' here, after "return if -e " :

 

https://metacpan.org/source/SHAY/Apache-Test-1.40/lib/Apache/TestConfigPHP.pm#L173-175
-- 
- CPAN kentnl@cpan.org
- Gentoo Perl Maintainer kentnl@gentoo.org ( perl@gentoo.org )
 

  Sat Oct 14 13:57:02 2017 KENTNL [...] cpan.org - Correspondence added
Subject: 0001-Fix-missing.patch
From b2a2cdc1e9a3121ea8848ab4a2410c5dcc68d620 Mon Sep 17 00:00:00 2001 From: Kent Fredric <kentnl@gentoo.org> Date: Sun, 15 Oct 2017 06:15:47 +1300 Subject: Fix missing ";" Bug: https://rt.cpan.org/Ticket/Display.html?id=123282 --- lib/Apache/TestConfigPHP.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/Apache/TestConfigPHP.pm b/lib/Apache/TestConfigPHP.pm index 0ddea0b..1c79865 100644 --- a/lib/Apache/TestConfigPHP.pm +++ b/lib/Apache/TestConfigPHP.pm @@ -170,7 +170,7 @@ sub configure_php_ini { my $dir = catfile $self->{vars}->{serverroot}, 'conf'; my $file = catfile $dir, 'php.ini'; - return if -e $file + return if -e $file; my $log = catfile $self->{vars}->{t_logs}, 'error_log'; -- 2.14.2